**** BEGIN LOGGING AT Fri May 18 03:00:04 2018
May 18 14:13:21 <jkridner[m]> @vaishnav98_ for me, I’ll say nothing else is needed. @anujdeshpande ?
May 18 14:30:21 <jkridner[m]> @vaishnav98_ for me, I’ll say nothing else is needed. @anujdeshpande ?
May 18 15:32:52 <vaishnav98_> jkridner[m]: Thanks! I will tidy up the work(,add tests) , move the examples from the main repository , provide documentation and then submit a PR to jadonk/bonescript, and then proceed with the bug fixes.
May 18 15:33:37 <vaishnav98_> anujdeshpande[m]: It would be really helpful if you could also review the changes and suggest if something more is required.
May 18 20:02:35 <anujdeshpande[m]> vaishnav98_: patch lgtm. I would suggest you amend the commit message though. Fix build issue is very generic - and it doesn't convey much.
May 18 20:03:50 <anujdeshpande[m]> Plus this commit is on the master branch - branch names which explain the issue being solved are usually the norm.
May 18 20:04:33 <anujdeshpande[m]> Updates <filename> as a commit message is not really helpful too - one can see that in the diff anyways. So you are not exactly conveying any additional information.
May 18 20:05:25 <anujdeshpande[m]> as a general rule - you are writing commit messages - not for yourself - but for the guy who works on this after you :)
May 18 20:28:59 <vaishnav98_> anujdeshpande[m]: Thanks! I will certainly make the edit and keep in mind what you have said :)
May 19 01:20:12 <vaishnav98_> jkridner[m]: anujdeshpande[m] Status update on today's work , I have made some slight changes and submitted the C module support implementation here : https://github.com/jadonk/bonescript/pull/170 , and moved the examples , provided description here :https://github.com/vaishnav98/bonescript_ffiexamples/blob/master/README.md
**** ENDING LOGGING AT Sat May 19 03:00:00 2018