**** BEGIN LOGGING AT Tue Jul 07 02:59:58 2020
Jul 07 03:53:47 <pratimugale[m]> vedant16: I'll have a look and get back
**** BEGIN LOGGING AT Tue Jul 07 04:30:36 2020
**** BEGIN LOGGING AT Tue Jul 07 05:23:26 2020
**** BEGIN LOGGING AT Tue Jul 07 05:57:21 2020
Jul 07 08:00:33 <lorforlinux[m]> jkridner ds2 Abhishek pdp7 Hi :)
Jul 07 08:00:44 <ds2> Hello
Jul 07 08:01:10 <lorforlinux[m]> ds2: I am writing my weekly report, will take 5 minutes max.
Jul 07 08:01:25 <lorforlinux[m]> I have updated some things in the compatibility layer code.
Jul 07 08:01:32 <ds2> 'k
Jul 07 08:01:53 <lorforlinux[m]> Load Cape and Relay Cape are now working with with same DT overlays.
Jul 07 08:03:38 <ds2> how are you determining "working"?
Jul 07 08:04:20 <lorforlinux[m]> I have installed the same overlay on both and tested them.
Jul 07 08:04:37 <lorforlinux[m]> using sysfs for now ^
Jul 07 08:05:55 <ds2> ah sysfs so more then just seeing if it loads
Jul 07 08:06:07 <ds2> I don't think either of those really use resources beyond a GPIO
Jul 07 08:06:34 <lorforlinux[m]> yes I am able to see the leds turning ON.
Jul 07 08:07:00 <ds2> got it.
Jul 07 08:07:04 <ds2> so this covers gpios
Jul 07 08:07:53 <lorforlinux[m]> Yeah they both uses gpio, but the tricky part for me was to make the compatible nodes for both boards that used gpio-leds driver.
Jul 07 08:08:17 <ds2> oh nice you got all the way to the gpio leds driver
Jul 07 08:10:11 <lorforlinux[m]> yes, first at first i was looking for some way to make references for input that goes  `gpios = <here>`
Jul 07 08:13:00 <lorforlinux[m]> I tried different things some worked but they were looking more like a hack rather than a good way to do things so I included this -> https://github.com/beagleboard/BeagleBoard-DeviceTrees/pull/17/commits/f3d112c09a89241bda1ed0ef441489e70c025924
Jul 07 08:13:50 <lorforlinux[m]> And I am using those nodes in the overlays -> https://github.com/beagleboard/bb.org-overlays/pull/185/commits/64724dc02ef5b0ff94349c3ca6580ba28610b5d9
Jul 07 08:15:27 <lorforlinux[m]> led_* nodes for BBB are here -> https://github.com/beagleboard/BeagleBoard-DeviceTrees/pull/17/commits/795a7b25c28f6ded87341e51e0252753345b6c59
Jul 07 08:16:51 <lorforlinux[m]>  * yes, at first i was looking for some way to make references for input that goes  `gpios = <here>`
Jul 07 08:17:56 <ds2> for 795a7b2
Jul 07 08:17:57 <ds2> +5c28f6ded87341e51e0252753345b6c59
Jul 07 08:18:14 <ds2> it looks like you fixed white spaces and made functional changes.
Jul 07 08:18:44 <ds2> It would be nice if you could break it into 2 commits - one that changes only white space and another one that does functional changes. Makes it easier to read
Jul 07 08:19:03 <ds2> oops
Jul 07 08:19:08 <ds2> I mean 64724dc02ef5b0ff94349c3ca6580ba28610b5d9
Jul 07 08:21:23 <lorforlinux[m]> the white space changes might be automatic, my editor was causing some problems with tabs before. so i updated some settings 😀
Jul 07 08:24:44 <ds2> nevertheless, it makes it harder to look at it
Jul 07 08:25:23 <lorforlinux[m]> <ds2 "I mean 64724dc02ef5b0ff94349c3ca"> ohh I see, I have totally re-written this overlay don't know about the white spaces.
Jul 07 08:26:14 <lorforlinux[m]> <ds2 "nevertheless, it makes it harder"> okay, I will take a look and try to make it more readable.
Jul 07 08:26:49 <ds2> just break it into 2 commits
Jul 07 08:27:48 <lorforlinux[m]> okay doing it
Jul 07 08:31:06 <lorforlinux[m]> please take a look
Jul 07 08:31:13 <lorforlinux[m]> https://github.com/beagleboard/bb.org-overlays/pull/186
Jul 07 08:31:37 <lorforlinux[m]> doing the same for load Cape overlay.
Jul 07 08:33:35 <ds2> hmm?
Jul 07 08:33:41 <lorforlinux[m]> done https://github.com/beagleboard/bb.org-overlays/pull/185
Jul 07 08:33:49 <ds2> nevermind... cut and paste problem
Jul 07 08:34:19 <ds2> is this an entirely new overlay?
Jul 07 08:34:30 <ds2> not sure why you are removing the other people's copyright
Jul 07 08:35:10 <lorforlinux[m]> I have not used anything from there overlay, should i include that? Please advice
Jul 07 08:35:27 <ds2> Well, I'd think that should be explained somewhere
Jul 07 08:35:48 <ds2> isn't it functionally equiv?
Jul 07 08:36:13 <lorforlinux[m]> yeah both are for same cape so yes.
Jul 07 08:36:39 <ds2> I'd put in a note somewhere that says  based on a previous version by XXXXX
Jul 07 08:37:10 <lorforlinux[m]> okay updating it :)
Jul 07 08:37:35 <ds2> General courtesy when your work is based on/inspired by another.
Jul 07 08:38:00 <ds2> a little more verbose commit messages would be good. I see the commit as rewrite but WHY?
Jul 07 08:38:14 <lorforlinux[m]> okay I will make sure this never happens again.
Jul 07 08:38:43 <lorforlinux[m]> <ds2 "a little more verbose commit mes"> what?
Jul 07 08:39:10 <ds2> rewritting the overlay (deleting old one)
Jul 07 08:39:17 <ds2> That's your commit message
Jul 07 08:39:26 <ds2> It would be nice to know why was it rewritten
Jul 07 08:40:22 <lorforlinux[m]> the overlay i submitted is using different format of DT and all the nodes are different from the older one.
Jul 07 08:40:48 <ds2> no no
Jul 07 08:41:04 <ds2> I mean the commit message. it should briefly say why you did it
Jul 07 08:41:35 <ds2> if I were the maintainer receiving the patch, I should not need to ask 348239148239084902384092348092384 questions on what is going on
Jul 07 08:41:43 <lorforlinux[m]> <lorforlinux[m] "the overlay i submitted is using"> okay I will include this there in simpler terms.
Jul 07 08:41:48 <ds2> the commits should document why it was done and what it was done for
Jul 07 08:42:15 <lorforlinux[m]> Okay i understand that, I will update it now.
Jul 07 08:42:17 <ds2> that message is about as useful as a commit that just says "Edited File"
Jul 07 08:42:31 <ds2> I can see you have rewritten it from the diffs :D
Jul 07 08:47:53 <lorforlinux[m]>  * Based on the BBORG_RELAY-00A2.dts written by
Jul 07 08:47:54 <lorforlinux[m]>  * Robert Nelson & Amilcar Lucas for kernel <=4.14
Jul 07 08:48:03 <lorforlinux[m]>  * Based on the BBORG_RELAY-00A2.dts written byRobert Nelson & Amilcar Lucas for kernel <=4.14
Jul 07 08:48:18 <lorforlinux[m]>  *  Based on the BBORG_RELAY-00A2.dts written by
Jul 07 08:48:18 <lorforlinux[m]>  Robert Nelson & Amilcar Lucas for kernel <=4.14
Jul 07 08:48:40 <lorforlinux[m]> Is this acceptable ^
Jul 07 08:49:29 <ds2> that should be good
Jul 07 08:53:29 <lorforlinux[m]> Rewritting the overlay (deleting this one) to make it compatible for BBB and BBAI by using code from beagleboard/BeagleBoard-DeviceTrees/pull/17 and new DT format.
Jul 07 08:53:46 <lorforlinux[m]> what about this commit message ^
Jul 07 08:55:16 <ds2> that's the idea but a few points about git commits
Jul 07 08:55:19 <ds2> Generally -
Jul 07 08:55:42 <ds2> first line is a headline.... A brief summary of the commit (keep it short)
Jul 07 08:55:45 <ds2> blank line
Jul 07 08:55:49 <ds2> a longer description
Jul 07 08:56:21 <ds2> this what git log will show the full message but you can also ask git to list just the first line so you can see a quick summary
Jul 07 08:56:29 <ds2> one long message just doesn't fit well with this
Jul 07 08:57:33 <lorforlinux[m]> okay i am keeping this as the headline -> Rewriting the overlay
Jul 07 08:58:14 <ds2> 'k
Jul 07 09:01:13 <ds2> I'm going to drop off now
Jul 07 09:01:40 <lorforlinux[m]> okay sure, thank you so much for your valuable time :)
Jul 07 09:14:33 <lorforlinux[m]> ds2: I have updated both of the PRs.
**** BEGIN LOGGING AT Tue Jul 07 10:15:41 2020
**** BEGIN LOGGING AT Tue Jul 07 11:21:56 2020
**** BEGIN LOGGING AT Tue Jul 07 13:53:31 2020
**** BEGIN LOGGING AT Tue Jul 07 17:49:54 2020
Jul 07 19:06:47 <vedant16[m]> Abhishek: pratimugale hendersa https://simppru.readthedocs.io/en/latest/ I have started with docs.
Jul 07 19:07:11 <vedant16[m]> Please take a look at this, 30% language syntax writeup is done.
Jul 07 19:07:17 <vedant16[m]> A lot still remains.