**** BEGIN LOGGING AT Tue Apr 23 02:59:58 2013 Apr 23 18:16:57 hey sugardave, you there? Apr 23 18:20:28 GodGinrai: back and forth, what's up? Apr 23 18:25:08 There was a polyfill that JayCanuck wrote for fixing getComputedStyle in IE8 that got merged into Enyo recently Apr 23 18:25:22 however, it doesn't even work Apr 23 18:27:45 I've written a wrapper object that contains the currentStyle and runtimeStyle objects for a given node that acts as the object the polyfill was trying to create, and it works in IE10 using compatibility mode for IE8. I was wondering what process I should Apr 23 18:27:45 follow to get these changes pulled. Apr 23 18:54:30 hey sugardave, I dc/ed Apr 23 18:54:37 Did you see my messages? Apr 23 18:54:55 and if you sent any after you said you were in or out, I didn't see them Apr 23 18:59:11 GodGinrai: sorry, was afk…so you want to make a fork of the enyojs repo, make a new branch in that fork, apply your changes, then do a pull request of that branch to the original enyojs repo. Make sure you add the DCO part in your comment/commit message (http://enyojs.com/community/contribute/). It would also be awesome if you wrote a JIRA issue first, and named your branch after that number. You can do that here: https://enyojs.atlassian.net/secur Apr 23 19:03:24 DCO? Apr 23 19:03:53 also, I think your JIRA link cut out Apr 23 19:04:13 yeah, it's a string message to put in the commit/comment to basically say you understand the guidelines we have for contributing code Apr 23 19:04:31 you can copy/paste it from that contribute page and change the name/email address Apr 23 19:04:47 k Apr 23 19:04:55 https://enyojs.atlassian.net/secure/Dashboard.jspa should be correct Apr 23 19:05:12 btw, that contribute url is 404ing for me Apr 23 19:05:17 hmm Apr 23 19:05:43 http://enyojs.com/community/contribute/ is working for me Apr 23 19:05:48 also, .jspa? What's the a for? Apr 23 19:06:03 no idea, that's Atalassian;s stuff :) Apr 23 19:06:14 really? weird. I'll check on my work computer. I get a 404 on my phone Apr 23 19:06:57 oh Apr 23 19:07:56 it seems that wIRC included ). in the url Apr 23 19:08:04 nice Apr 23 19:11:58 is there any naming convention that would be required for my object? Apr 23 19:12:31 Currently, it's an enyo.Object derived kind called enyo.IEStyle Apr 23 19:13:56 you can submit it with that name and then the core framework team will likely suggest something different Apr 23 19:14:16 ok Apr 23 19:14:37 or maybe otherwise integrate the functionality in a different way, it all depends Apr 23 19:15:35 I personally think using the kind is the cleanest way to do it. Apr 23 19:16:54 btw, this is unrelated, but is there a way to define a base Kind for a kind when you use one? for example, I made a growing input based on a enyo.Input, but when I'm using Onyx widgets, I want it to be based on an onyx.Input Apr 23 19:17:53 not really….you MIGHT be able to use the new mixins feature of the top-of-tree stuff Apr 23 19:18:02 but I haven't tried that yet Apr 23 19:18:38 Ah, I saw that when I was browsing around, but I'm not sure how that works Apr 23 19:18:53 but onyx.Input should extend enyo.Input anyway... Apr 23 19:19:53 so may be easier to just make a new onyx.GrowingInput that extends your new Input and adds the regular onyx Input stuff to it Apr 23 19:20:00 yes, but anything else that extends enyo.Input would not extend onyx.Input Apr 23 19:20:11 nope Apr 23 19:20:53 so you do this, mixins: ["onyx.Input"] (I think) Apr 23 19:21:53 interesting. And it would mixin everything from the list before it applies the properties and methods already in your object? Apr 23 19:22:29 If so, that could be powerful indeed Apr 23 19:23:19 I think that is the intent, though I'm not sure on the order it applies them Apr 23 19:40:36 sugardave: do you know if new releases of enyo have changed the rules about enforcing a call stack limit? or if something else chaned that might have caused something that worked in Enyo 2.0 to hit the call stack limit? Apr 23 19:41:14 GodGinrai: I haven't gotten to your suggestsions yet, my oral prelims are this week Apr 23 19:45:45 summatusmentis: not that I'm aware of, but I ran into that issue today when I accidentally overwrote the addControl method Apr 23 19:46:20 so it might be something that wouldn't look like an error, but is still giving you problems…what code is it running when it fails? Apr 23 19:47:06 so, basically, it's a data collection app that dynamically builds out a form (in this case, with a 4x4 table, where each cell contains a button) Apr 23 19:47:24 users tap on a pin (on a map) which triggers an event, and sends the proper context data to the form builder Apr 23 19:47:41 it fails when building out the form, specifically when it hits the 4x4 table kind Apr 23 19:48:10 but my stuff is only 4 or 5 chained calls Apr 23 19:48:26 (granted, 1 or 2 of them do a lot of work) Apr 23 19:48:54 what do you mean accidentally overwrote the addControl method? Apr 23 19:50:42 I was writing a fiddle example and in my kind I had an addControl method, not remembering that addControl already exists, so when it went to render my kind, my addControl method ran instead and I got the maximum call stack error (probably because it kept trying to run addControl that wasn't doing what it thought it should) Apr 23 19:50:51 there's an addControl method in UiComponent, IIRC. He probably overwrite it in a kind he was using Apr 23 19:50:53 lol yep Apr 23 19:51:30 *overwrote Apr 23 19:52:47 oh, I see Apr 23 19:52:56 so you did actually overwrite the method Apr 23 19:53:03 summatusmentis: do you have this fiddle-able? Apr 23 19:53:09 not something weird happened that caused it to overwrite Apr 23 19:53:12 sugardave: not easily, no Apr 23 19:53:19 summatusmentis: yeah, I shout my self in the foot Apr 23 19:53:21 does Enyo have support for the onhashchange event? Apr 23 19:53:25 s/shout/shot/ Apr 23 19:55:37 GodGinrai: master branch does Apr 23 19:55:58 but only if you are using a Router kind Apr 23 19:56:18 a Router kind? Is that new? Apr 23 19:56:28 you can always listen to it yourself Apr 23 19:56:38 yes, it's new new new Apr 23 19:57:11 don't ask me how to use it, it's that new :P Apr 23 19:57:20 lol Apr 23 19:57:35 is it listed in the nightly API tool? Apr 23 19:58:01 it should be, I guess I should have a bookmark for that one Apr 23 19:59:20 hmm, it's not Apr 23 19:59:29 damn :/ Apr 23 19:59:36 the source is in kernel/Router.js Apr 23 20:00:02 yea, I already have it pulled up Apr 23 21:49:00 hey sugardave1, What's the reasoning behind ditching the published block w/ the new MVC code? Apr 23 21:55:14 MVC means you shouldn't need to expose which data fields you use Apr 23 21:57:14 I understand that Apr 23 21:57:45 I obviously can't speak for the enyo folks, but that's what makes sense to me Apr 23 21:57:46 but the way they are accomplishing MVC is by exposing everything through a general method, IIRC Apr 23 21:57:58 I haven't looked at it Apr 23 21:58:23 so why can't they just make it so you put things you will want to bind in the published block and it would use the getters and setters that get generated from that Apr 23 21:58:49 I wonder if backbone has it's own getters and setters Apr 23 21:59:08 is the MVC code usable? Apr 23 21:59:22 supposedly it has been for a while Apr 23 21:59:26 I just haven't tried it Apr 23 21:59:38 I should see about switching over Apr 23 21:59:50 well, it's still in preview tho' Apr 23 21:59:51 that would be a way to fix my context issue, maybe Apr 23 21:59:54 right Apr 23 22:00:01 which is why I haven't done it yet Apr 23 22:00:06 yea, same for me Apr 23 22:00:33 I would be using it for the app I'm doing right now if they had some documentation explaining how to use it up. The tiny tidbit they have on the github is not enough Apr 23 22:01:57 where's that tidbit? I was looking for some info Apr 23 22:02:29 oh just a second, I'll link you Apr 23 22:04:19 https://github.com/enyojs/enyo/wiki/Enyo-MVC-Intro Apr 23 23:17:34 wb Trex005 Apr 24 01:07:36 GodGinrai: as far as I know, the new get/set functionality is geared towards better interoperability with different model backends (like backbone) and matching the APIs of those things. I think it also made sense due to changes that Cole had to make to the core to support a controller-view architecture. In my opinion, impact to existing code is nominal and easily converted, since the propertyChanged functionality remains the same Apr 24 01:48:24 GodGinrai, you rang? Apr 24 02:25:33 lol Lerry Apr 24 02:25:40 that was a whole day ago XD Apr 24 02:25:44 *Larry Apr 24 02:27:27 sugardave: Is there any point to using enyo.Selection to select elements? I was going to use it for my combobox, but I'm not sure if it is needed Apr 24 02:35:20 I think you use enyo.Selection to just keep track of state…I've never actually used it Apr 24 02:36:51 well, when I look at it, it looks pretty useful. But at the same time, since I have to visualize my selection w/ dynamically generated elements, I can probably also use that to know what I've selected :\ Apr 24 02:56:45 wb summatusmentis Apr 24 02:56:52 did you get that link I sent you? Apr 24 02:58:45 the one about MVC? Apr 24 02:59:13 yea Apr 24 02:59:24 yeah, I did, thanks **** ENDING LOGGING AT Wed Apr 24 02:59:58 2013