**** BEGIN LOGGING AT Fri Feb 05 02:59:56 2010
Feb 05 20:06:17 <denkenz> padovan: Do not use g_sources
Feb 05 20:06:27 <denkenz> padovan: just forget about this g_timeout_add part
Feb 05 20:06:58 <denkenz> padovan: modify send_method_call to accept a timeout argument and send "Connect" with a proper timeout and callback
Feb 05 22:19:44 <vcgomes> denkenz, padovan: there's a leak when listing the bluetooth devices in hfp, there's a patch for it in my tree: git://git.infradead.org/users/vcgomes/ofono.git devel branch, or sending it to the mailing list is a better idea?
Feb 05 22:27:07 <padovan> vcgomes: still need to add a g_free(device[i]) inside the for loop on list_devices_cb()
Feb 05 22:29:40 <vcgomes> padovan: yeah, thanks
Feb 05 22:33:00 <vcgomes> just pushed the new patch
Feb 05 22:42:35 <padovan> denkenz: do you really think it's a good idea change send_method_call to add the timeout arg? We'll have to add an extra parameter in all calls to it.
Feb 05 22:50:31 <denkenz> vcgomes: Please send to the ML, I haven't valgrind'd this stuff yet
Feb 05 22:50:50 <denkenz> padovan: Personally I'd like to see send_method_call simplified much more and broken into two functions
Feb 05 22:51:05 <denkenz> padovan: One that handles the no-reply case and one that is full blown
Feb 05 22:51:27 <denkenz> And honestly there should be a timeout on all of them, and proper error handling :)
Feb 05 22:52:36 <vcgomes> denkenz: sure
Feb 05 22:52:38 <padovan> denkenz: Sounds good. We might want add theses funcions to gdbus. I think that they can be useful there.
Feb 05 22:53:02 <padovan> s/theses/these/
Feb 05 22:53:24 <denkenz> padovan: Certainly, I see a lot of duplicated code in connman bluetooth/ofono/supplicant plugins, bluez and ofono
**** ENDING LOGGING AT Sat Feb 06 02:59:56 2010