**** BEGIN LOGGING AT Tue Mar 16 02:59:56 2010
Mar 16 03:19:28 <denkenz> holtmann: sure
Mar 16 03:19:54 <denkenz> ygu5_ubuntu: I have no idea, resubmit the Huawei so holtmann can review again, he's the udev master
Mar 16 03:21:00 <denkenz> ygu5_ubuntu: When you're working on the ber_tlvs make sure you also submit the unit tests
Mar 16 03:21:33 <ygu5_ubuntu> denkenz: I will send out the patch for Huawei modem again.
Mar 16 03:22:00 <ygu5_ubuntu> denkenz: No problem for ber-tlvs :)
Mar 16 06:40:10 <ygu5_ubuntu> holtmann: denkenz: I have sent the patch to support Huawei EM770 modem to ML. Would you please have a review, especially on udev part? Thank you very much!
Mar 17 01:44:52 <zhenhua> denkenz: ping
Mar 17 01:50:25 <denkenz> zhenhua: pong
Mar 17 01:51:54 <zhenhua> one issue i have is to handle backspace in gatserver
Mar 17 01:52:39 <zhenhua> actually it should be done before server-feed
Mar 17 01:52:46 <zhenhua> i want to modify that
Mar 17 01:53:21 <denkenz> That should be done at the parser level
Mar 17 01:54:20 <zhenhua> but how about AA<backspace>/
Mar 17 01:54:48 <zhenhua> the ParserResult won't be REPEAT_LAST
Mar 17 01:55:22 <zhenhua> it should be interpreted as A/ 
Mar 17 01:56:19 <denkenz> If you want to go that complicated then you can always scan the line until \r and remove any characters followed by backspace
Mar 17 01:56:26 <denkenz> Only then feed it to the parser
Mar 17 01:58:59 <zhenhua> i don't want to be a trouble maker.;-)
Mar 17 01:59:16 <zhenhua> just want to make sure we handle the right thing
Mar 17 01:59:23 <denkenz> No you're right
Mar 17 01:59:40 <denkenz> Just that nobody would actually use this in the real world
Mar 17 01:59:58 <zhenhua> yes. no body actually use that
Mar 17 02:00:08 <holtmann> denkenz: Do we have to handle backspace at all?
Mar 17 02:00:24 <denkenz> Only if you're on a minicom or something
Mar 17 02:00:46 <zhenhua> i think we should handle that. it's defined in V.250
Mar 17 02:01:20 <holtmann> Most modems have serious issues with it. They don't handle it at all.
Mar 17 02:01:49 <denkenz> Ideally we should handle it, and it isn't that hard
Mar 17 02:02:23 <denkenz> We simply tweak our logic to pre-scan for \r, once we have it process the backspaces and then feed it to the parser
Mar 17 02:02:48 <holtmann> Fair enough. I am all for making it better then the modems.
Mar 17 02:03:12 <denkenz> But again, this part can be done safely later too
Mar 17 02:03:42 <denkenz> So it is completely up to you when / how you want to do this
Mar 17 02:04:11 <zhenhua> that's why i am asking you. I am thinking about the trade off
Mar 17 02:04:35 <denkenz> IMO the other features are more important now
Mar 17 02:04:36 <zhenhua> it makes the logic more complex if we handle it before the parser.
Mar 17 02:04:50 <zhenhua> ok. so i skip it now
Mar 17 02:05:08 <zhenhua> the most framework is there now. but the patch is too big.
Mar 17 02:05:39 <denkenz> we actually want modem emulator pretty soon here, so we can start figuring out how to integrate it into the core
Mar 17 02:06:22 <holtmann> We need to start thinking about the next release.
Mar 17 02:06:23 <zhenhua> can i send a patch to u first?
Mar 17 02:06:43 <holtmann> zhenhua: Please split up the patches.
Mar 17 02:07:02 <denkenz> git reset and git commit --interactive are your friends
Mar 17 02:07:06 <zhenhua> holtmann: sure. i will. the patches maybe have 8 or more...
Mar 17 02:07:53 <holtmann> That is fine. However send them to the mailing list. Then I can help reviewing them.
Mar 17 02:08:16 <zhenhua> holtmann: will do. thanks for your review time.
Mar 17 02:08:51 <holtmann> Any time. We have to offload Denis a little bit.
Mar 17 02:08:55 <denkenz> zhenhua: Don't worry about having me review privately, most of your patches are well prepared
Mar 17 02:09:22 <denkenz> zhenhua: And the more people see some things the faster they get reviewed
Mar 17 02:09:46 <zhenhua> denkenz:  thanks.
Mar 17 02:10:44 <zhenhua> denkenz: i plan to rename test-server.c to something else
Mar 17 02:11:10 <zhenhua> because i need a test case to chat with server
Mar 17 02:11:20 <denkenz> zhenhua: Besides, your colleague has sent me like 60+ patches privately anyway, not to mention the 15 on the mailing list ;)
Mar 17 02:11:21 <zhenhua> gsmserver.c?
Mar 17 02:11:39 <zhenhua> heh
Mar 17 02:11:45 <denkenz> zhenhua: what does test-server do, remind me?
Mar 17 02:12:07 <zhenhua> wrap the gatserver and create pty, tcp, socket type of interface
Mar 17 02:12:43 <denkenz> Ok, so the pty, tcp code can go into a util class
Mar 17 02:13:16 <zhenhua> gatutil.c is the place
Mar 17 02:13:24 <denkenz> The rest maybe rename into test_atserver?
Mar 17 02:13:33 <denkenz> and test_atclient?
Mar 17 02:14:06 <zhenhua> dunno know. i am fine with whatever the name like.
Mar 17 02:14:28 <zhenhua> test_atserver.c or test-atserver.c
Mar 17 02:14:59 <denkenz> test-atserver is fine
Mar 17 02:15:08 <holtmann> zhenhua: test-server.c is just fine. Leave it like that for now.
Mar 17 02:16:53 <zhenhua> holtmann: the problem is we need to add a test case to chat with this test-server.c
Mar 17 02:17:17 <zhenhua> test-server is to create interface of gatserver.
Mar 17 02:17:30 <zhenhua> i added server-chat.c to chat with this 'server'.
Mar 17 02:17:39 <zhenhua> is server-chat.c ok? 
Mar 17 02:18:24 <denkenz> lets just do test-server and test-client
Mar 17 02:18:49 <zhenhua> ok. i am fine.
Mar 17 02:18:49 <denkenz> And at some point we need to start splitting out gatchat lib from test tools
Mar 17 02:20:02 <zhenhua> when to do that?
Mar 17 02:20:18 <zhenhua> test-server and test-client are still in gatchat
Mar 17 02:21:48 <denkenz> Don't worry, I or marcel will take care of it
Mar 17 02:21:59 <zhenhua> sure
**** ENDING LOGGING AT Wed Mar 17 02:59:57 2010