**** BEGIN LOGGING AT Thu Jul 29 02:59:57 2010 Jul 29 03:21:34 holtmann: will do it soon **** BEGIN LOGGING AT Thu Jul 29 05:10:14 2010 **** BEGIN LOGGING AT Thu Jul 29 05:24:17 2010 **** ENDING LOGGING AT Thu Jul 29 05:37:22 2010 **** BEGIN LOGGING AT Thu Jul 29 05:54:14 2010 Jul 29 10:05:34 denkenz: in gprs-context.h, why there is a field named 'direction'? Jul 29 17:19:16 zhenhua: Because in theory GPRS can be network activated Jul 29 17:19:26 zhenhua: We just don't implement that case yet Jul 29 17:43:14 denkenz: set the modem powered start rfcomm connection, but which action should start the DUN handshake? CreateContext()? Jul 29 17:43:52 Create context just sets up the parameters Jul 29 17:44:06 You only initiate the link when you activate the context Jul 29 17:45:21 padovan: Refer to at_gprs_activate_primary in drivers/atmodem/gprs-context.c Jul 29 17:47:16 ok, I'll take a look on that. Jul 29 18:12:23 denkenz: by initiate the link you mean the handshake stuff, not the rfcomm link. From what I understand the DataConnectionManager API will only be available if the modem is powered up. Jul 29 18:13:10 correct Jul 29 20:26:55 denkenz: ping Jul 29 20:27:01 pong Jul 29 20:28:21 denkenz: fixing one of the warnings jprivta reported involved adding a missing declaration to smsutil.h that pull in a dependency to include ofono.h -- if I #include ofono.h in smsutil.h (solution #1) hell breaks loose. Solution #2 was including ofono.h before smsutil.h in every file that needed it smsutil.h. Jul 29 20:28:43 which means a bunch of single liners in a bunch of files Jul 29 20:28:52 you would still want that in separate commits split by directory? Jul 29 20:29:18 Why does smsutil.h need ofono.h? Jul 29 20:29:32 [this is with the changes I added] Jul 29 20:29:50 Something is definitely wrong if that is needed Jul 29 20:29:50 because ofono.h defines one of the types needed by the declaration of sms_msg_send() in smsutil.h Jul 29 20:30:16 or where is a better place to declare the sms API Jul 29 20:30:40 Umm, in sms.c? Jul 29 20:30:49 I need external declarations for the test code Jul 29 20:31:02 unless I can start a sms.h Jul 29 20:31:14 Test code for what? Jul 29 20:31:20 for the SMS API Jul 29 20:31:32 How will you test it without D-Bus? Jul 29 20:34:04 sec, being pulled over Jul 29 20:53:43 denkenz: back, sorry -- the initial plan you wanted was to have the same SMS message send call available over D-Bus to be available over C for plugins Jul 29 20:53:59 so the test would need a decl to pull it up and exercise it Jul 29 20:54:13 if you don't feel that's necessary now, I'll just make it static and forget about it Jul 29 20:54:39 that makes the warning fix a one liner Jul 29 20:54:53 I don't recall that, and txq_submit is pretty much taking care of that Jul 29 20:54:59 So just forget about it Jul 29 20:56:28 k **** ENDING LOGGING AT Fri Jul 30 02:59:57 2010