**** BEGIN LOGGING AT Tue Aug 03 02:59:57 2010
Aug 03 05:25:21 <kvalo> luke-jr: we have long vacations in finland :)
Aug 03 05:26:23 <luke-jr> kvalo: they're seriously not back yet? :/
Aug 03 05:26:48 <luke-jr> no wonder N900 is so expensive
Aug 03 05:26:49 * luke-jr ducks
Aug 03 05:31:09 <kvalo> luke-jr: I don't know. most people come back from vacation either this week or next.
Aug 03 05:31:23 <luke-jr> sigh
Aug 03 08:19:32 <ljp> i think standard holiday is about 5 weeks or so. they tend to take it all at once during the summer when its above subfreezing. :)
Aug 03 14:02:43 <luke-jr> ljp: that's 10% of a year!
Aug 03 19:21:55 <jprvita> denkenz: I guess supporting voice-only is now done, could you have a look please? http://git.profusion.mobi/cgit.cgi/jprvita/ofono/commit/?h=huawei_voiceonly_sim
Aug 03 19:23:01 <jprvita> about the problem with lazy modems on cold boot, I wrote some code but I'm not sure if I got it properly
Aug 03 19:25:23 <jprvita> what would be the sim state value from SYSINFO in this case?
Aug 03 19:25:39 <denkenz> Good question
Aug 03 19:25:48 <jprvita> hehe
Aug 03 19:26:18 <denkenz> +	if ((data->sim_state == 1 || data->sim_state == 3) &&
Aug 03 19:26:18 <denkenz> +		ofono_modem_get_boolean(modem, "HasVoice") == TRUE) {
Aug 03 19:26:25 <denkenz> Please follow proper if indentation rules
Aug 03 19:26:42 <denkenz> +		if (data->gprs && data->gc)
Aug 03 19:26:43 <denkenz> +			ofono_gprs_add_context(data->gprs, data->gc);
Aug 03 19:26:51 <denkenz> newline before the if
Aug 03 19:27:34 <denkenz> +	if (data->sim_state == 1 || data->sim_state == 2) {
Aug 03 19:27:42 <denkenz> Have you tested this part with PIN locked SIMs?
Aug 03 19:27:52 <denkenz> actually nevermind
Aug 03 19:27:58 <jprvita> I don't have any :(
Aug 03 19:28:18 <denkenz> any SIM can be pin locked
Aug 03 19:28:44 <denkenz> just look at how oFono does PinLock
Aug 03 19:28:49 <denkenz> or is it LockPin()
Aug 03 19:29:22 <denkenz> +	if ((data->sim_state == 1 || data->sim_state == 3) &&
Aug 03 19:29:22 <denkenz> +		ofono_modem_get_boolean(modem, "HasVoice") == TRUE)
Aug 03 19:29:27 <denkenz> Same thing here, proper if indentation
Aug 03 19:29:48 <denkenz> see doc/coding-style.txt
Aug 03 19:30:00 <jprvita> ok
Aug 03 19:31:10 <denkenz> +	if (data->sim_state == 4 || data->sim_state == 255)
Aug 03 19:31:10 <denkenz> +		return;
Aug 03 19:31:11 <denkenz> +
Aug 03 19:31:23 <denkenz> For this one, in case of sim_state == 4, you might want to add phonebook atom
Aug 03 19:31:27 <denkenz> But that is a nitpick
Aug 03 19:31:44 <jprvita> right, I'll fix it
Aug 03 19:31:52 <denkenz> Otherwise it looks fine to me
Aug 03 19:32:07 <denkenz> Just make sure to test it with a PIN locked SIM and a cold-booted modem
Aug 03 19:32:51 <jprvita> so, for a cold-boot do I just start ofono, plug the modem and then enable-modem real quickly?
Aug 03 19:33:39 <denkenz> It sort of depends on the modem, I think Huaweis auto-register by default, so its hard to test
Aug 03 19:33:45 <denkenz> but yeah, that seems to be the best strategy
Aug 03 19:34:28 <denkenz> PIN lock is a good test here, because it prevents the modem from fully initializing before oFono is ready
Aug 03 19:34:51 <jprvita> ok, although it doesn't seem very deterministic :)
Aug 03 19:34:59 <jprvita> I'll have a look at pin lock too
Aug 03 19:35:19 <denkenz> Yeah there's a race, but nothing we can do about it
Aug 03 19:35:35 <denkenz> Just see if the current code works reasonably well
Aug 03 19:35:42 <denkenz> We can fix it later on if someone has issues
Aug 03 19:35:59 <jprvita> all right
Aug 03 20:05:53 <jprvita> denkenz: is it necessary that the modem supports voice (HasVoice property) for phonebook?
Aug 03 20:20:07 <denkenz> nope
Aug 03 20:20:15 <denkenz> jprvita: That one's separate
Aug 03 20:20:57 <jprvita> I've tested with my modem here and I just get [ org.ofono.Phonebook ], without no properties under it
Aug 03 20:21:09 <denkenz> That's correct
Aug 03 20:21:15 <denkenz> that interface is only methods
Aug 03 20:21:24 <jprvita> ahn, ok then
Aug 03 20:21:44 <jprvita> since on the current HEAD it's only enabled if modem HasVoice, I thought was the case
Aug 03 20:24:06 <denkenz> that might have been a bug or something
Aug 03 20:27:46 <jprvita> ok, so I'll take it out from the if
Aug 03 20:39:47 <jprvita> does this means I can't lock my modem: PinRequired = none ?
Aug 03 20:54:25 <jprvita> denkenz: ^
Aug 03 20:54:46 <jprvita> and also, cold boot tests have passed
Aug 03 21:27:30 <orioni> how can i simulate an incoming call or sms ?
Aug 03 21:33:49 <denkenz> jprvita: No, you have to know your PIN first
Aug 03 21:34:05 <denkenz> jprvita: Then you can call SimManager.LockPin("pin", "your pin")
Aug 03 21:34:19 <denkenz> jprvita: Next cold boot it will ask for a PIN
Aug 03 21:34:41 <denkenz> orioni: If you use phonesim, enter a number and hit "Call" on the GUI
Aug 03 21:35:18 <orioni> i want to simulate one from the comandline 
Aug 03 21:35:30 <orioni> so i can see the GUI , and change it a bit 
Aug 03 21:35:45 <denkenz> orioni: You can export phonesim GUI elsewhere
Aug 03 21:35:55 <denkenz> orioni: e.g. using xhost
Aug 03 21:36:15 <denkenz> Another way is to use phonesim in no-gui mode and dial a magic callback number
Aug 03 21:37:47 <denkenz> dialing 199 will result in an incoming call in 5 seconds
Aug 03 21:38:25 <orioni> thanx 
Aug 03 22:29:57 <denkenz> jprvita: It might be a good idea to use an enum for those sim_state checks
Aug 03 22:30:11 <denkenz> jprvita: That way its immediately clear what state is being referred to
Aug 03 22:30:40 <denkenz> jprvita: Otherwise it looks good to me, but test with a PIN-locked SIM first
Aug 03 22:31:00 <denkenz> If you need a quick walkthrough, let me know
**** ENDING LOGGING AT Wed Aug 04 02:59:57 2010