**** BEGIN LOGGING AT Sat Feb 05 02:59:57 2011 Feb 05 10:33:18 holtmann: ping Feb 05 11:14:40 what is NTF standing for in the context of gisi? Feb 05 11:15:59 hmm, notification? Feb 05 11:17:46 mickeyl: atleast from the code usage, it seems to be notification. your guess may be right Feb 05 11:18:09 ok, thanks Feb 05 12:24:35 Jeevaka: pong Feb 05 12:55:48 holtmann: about the 0x1 << x comment Feb 05 12:56:55 What about it? Feb 05 12:57:07 holtmann: we also have 0x1 << oc->id, 0x1 << req->id Feb 05 12:57:21 I know. They should be all converted to 1 << x Feb 05 12:57:24 do you want me to fix those as well part of this patch Feb 05 12:57:38 git grep -F 'x1 <<' Feb 05 12:57:48 Send a separate patch up-front or after. Feb 05 12:57:54 ok Feb 05 12:58:16 It is mostly only the voicecall drivers, but there 5 other places as well. Feb 05 12:58:21 src/modem.c: if (modem->call_ids & (0x1 << i)) Feb 05 12:58:21 src/modem.c: modem->call_ids |= (0x1 << id); Feb 05 12:58:21 src/modem.c: modem->call_ids &= ~(0x1 << id); Feb 05 12:58:21 src/smsutil.h: int mask = 0x1 << bit; Feb 05 12:58:22 src/smsutil.h: unsigned char mask = (0x1 << num) - 1; Feb 05 12:59:52 yes, i'll send the call status patch first and send a separate patch for the other ones Feb 05 13:04:45 Sounds good. Feb 05 13:05:17 If you wanna get extra credit then an entry in doc/coding-style.txt would be nice ;) Feb 05 13:08:30 that would be taken care as well Feb 05 13:11:16 regarding the fast dormancy support for ifxmodem Feb 05 13:11:37 You have the specs for it. Should be pretty damn easy to add. Feb 05 13:12:03 You do need to check if the proper modes 2 and 3 (or whatever they are) are supported first. Feb 05 13:12:38 yep Feb 05 13:14:03 I hope they added a test command to get the current mode. Feb 05 13:14:28 its planned for next fw release Feb 05 13:15:19 Then this should be a pretty trivial patch. Feb 05 13:36:28 holtmann: is this style rule ok? Feb 05 13:36:29 http://pastebin.com/XFyy2Vca Feb 05 14:50:56 Jeevaka: Fine with me, Feb 05 16:40:10 t Feb 05 16:41:35 holtmann/denkenx, I submitted a patch for IFX modem self test: PATCH v9] ifx: Adding modem selftest for Infineon modem.. Please review the patch. Thx Anand Feb 05 16:48:03 anandx: holtmann has already reviewed v9 patch Feb 05 16:48:45 anandx: review comments are already in the mailing list Feb 05 17:18:58 Thanks Jeevaka, thanks for the update. i did not get the email yet and look for it. Feb 05 17:35:48 anandx: http://lists.ofono.org/pipermail/ofono/2011-February/008623.html Feb 05 17:36:21 anandx: i hope you have subscribed to the ofono mailing list **** ENDING LOGGING AT Sun Feb 06 02:59:57 2011