**** BEGIN LOGGING AT Mon Jul 18 02:59:57 2011 Jul 18 16:37:30 denkenz: ping Jul 18 16:38:22 Jeevaka: pong Jul 18 16:38:44 Its about one of the review comment on setup call Jul 18 16:39:17 "Also you probably can formalize proactive_command_handled_end and not call stk_unset_alpha_id unnecessarily in the case of modem-handled Set Up Call." Jul 18 16:40:36 stk_alpha_id_unset is not called from proactive_command_handled_end Jul 18 16:41:18 What I meant there is that you should call that function only, instead of calling both stk_alpha_id_unset and proactive_command_handled_end Jul 18 16:41:36 Then inside proactive_command_handled_end you can switch/case and call stk_alpha_id_unset as appropriate Jul 18 16:41:50 This probably would make your earlier crash fix unneeded Jul 18 16:42:41 hmm Jul 18 16:45:20 Earlier crash fix was basically introduced for the case when there is no default agent Jul 18 16:46:00 ofcourse its seen when testing the modem handled setup call patch Jul 18 16:47:01 I'm guessing its when there is no agent period ;) Jul 18 16:48:24 Which needs to be checked on alpha_id_set in that case as well Jul 18 16:49:22 However, there are modem-handled commands which have no alpha_id Jul 18 16:49:30 so calling unset_alpha_id seems pointless Jul 18 16:49:37 ok Jul 18 16:49:37 Unless we really need it Jul 18 16:51:03 So no need to call stk_alpha_id_unset for modem handled commands at all? Jul 18 16:51:43 or no need to call stk_alpha_id_unset only for modem handled setup call? Jul 18 16:52:00 No, I just mean that we already decoded the command, we have a a switch/case you're introducing in handled_command_end or whatever Jul 18 16:52:17 So instead of always calling alpha_id_unset, add that to the relevant commands handled in switch/case Jul 18 16:53:07 ok Jul 18 16:53:17 And we also need to handle the case where we received a handled command and we have no agents Jul 18 16:53:21 But that is a separate issue **** ENDING LOGGING AT Tue Jul 19 02:59:56 2011