**** BEGIN LOGGING AT Wed Aug 03 02:59:57 2011
Aug 03 13:46:23 <fdanis> denkenz: ping
Aug 03 13:46:39 <denkenz> fdanis: pong
Aug 03 13:47:38 <fdanis> denkenz: are my patch to fix indicator notification ok ?
Aug 03 13:48:21 <denkenz> I haven't had time to look yet
Aug 03 13:49:23 <fdanis> ok, this is the latest one before I set HFP emulator as done
Aug 03 13:50:10 <denkenz> I just quickly looked at it and it seems fine
Aug 03 13:50:17 <denkenz> Go ahead and send a patch to mark the task done
Aug 03 13:50:34 <fdanis> ok, I will send it
Aug 03 13:57:53 <denkenz> fdanis: So there's one potential issue
Aug 03 13:57:53 <denkenz> For compound commands the g_timeout_add logic won't work
Aug 03 14:00:29 <denkenz> Also, built-in commands do not go through ofono_emulator* magic
Aug 03 14:00:48 <denkenz> so the best way might be to add a special callback to GAtServer
Aug 03 14:01:01 <fdanis> I may discard the timer if it exists at beginning of handler_proxy ,
Aug 03 14:02:09 <fdanis> s/,/?/
Aug 03 14:02:50 <denkenz> This might work, but it might be easier to ask GAtServer whether it is in a compound command
**** BEGIN LOGGING AT Wed Aug 03 14:05:28 2011
Aug 03 14:14:33 <fdanis> denkenz: currently this information does not exist in GAtServer, right ?
Aug 03 14:16:08 <denkenz> sort of, it is tied to server->suspended
Aug 03 14:17:29 <denkenz> It might be easier to add something like g_at_server_command_pending and then g_at_server_set_finish_callback
Aug 03 14:19:12 <denkenz> or command_is_pending and command_finished_notify
Aug 03 14:19:23 <denkenz> That way you don't have to mess with timeouts
Aug 03 14:33:09 <fdanis> so, g_at_server_command_pending will return server->suspended state, allowing to know if we can send the +CIEV
Aug 03 14:33:10 <fdanis> and a callback set by g_at_server_set_finish_callback will be called during server_resume, allowing to send deferred notification
Aug 03 14:33:10 <fdanis> right ?
Aug 03 14:33:38 <denkenz> That's my best guess so far yep
Aug 03 14:34:07 <fdanis> ok, I will try to do it
Aug 03 14:35:04 <fdanis> my main problem with this is that I do not know how to test it, do you have any idea, please ?
Aug 03 14:40:03 <denkenz> You can always make a command inside test-server that takes a long time to complete
**** ENDING LOGGING AT Thu Aug 04 02:59:57 2011