**** BEGIN LOGGING AT Thu Oct 18 03:00:02 2012 Oct 18 10:54:36 ew.. via mailing list i see "option phy phyX" doesnt work anymore...? :( Oct 18 11:01:54 ? Oct 18 11:05:23 well, it look broken - @nbd: "[ -d /sys/class/ieee80211/phy ] && return" - I think you wanted .../${phy} here (in lookup_phy()) Oct 18 11:06:04 or maybe not Oct 18 11:06:31 KanjiMonster: oh, right Oct 18 11:06:45 typo Oct 18 11:06:51 ah, yes Oct 18 11:07:32 I was confused shortly because of the devpath usage below, so I wasn't sure anymore Oct 18 11:28:59 jow_laptop: found a bug in luci/collectd/ping it seems :) Oct 18 11:42:59 dape8708: fixed Oct 18 11:43:18 nbd, thank you so much ! Oct 18 11:44:59 btw. option phy phyX is deprecated, using the new 'option path ...' is preferred Oct 18 11:45:08 (using the device path) Oct 18 11:54:04 :( Oct 18 12:01:06 dape8708: don't worry, we'll keep it around Oct 18 12:01:27 thank you, because you guys simply rock Oct 18 13:36:04 nbd: hello, when you applied my yesterdays fix for my snortsam, I havent realized that mail would destroy dos EOL for snortsam source codes. I made a patch that repairs it, should I provide an url to it or resend it to mailing list with an URL instead of sending patch in mail? Oct 18 13:37:26 bright_laptop: send a patch in the mail to the -devel mailing list Oct 18 13:39:24 I suppose I should send an URL to it to prevent destroying my patch in mail Oct 18 14:20:09 I have just prepared a set of patches to be sent to openwrt-devel, but this is my first time doing this and I'm not sure if it's correct Oct 18 14:20:19 could I send it to one of you guys to have a look at it? Oct 18 14:20:56 it's mostly regarding the formatting of the message and if the patch is not mangled up in my client Oct 18 14:23:04 would anyone be so kind and help me with sending a patch to mailing list unmangled ? Having some problems with mangling - and I think it should be better to send it as an URL to it - but should I send with MIME, or not? should I send it as an URL? if so, should be URL after signed-off-by: line ? Oct 18 14:26:34 bright_laptop: have you already sent something to the mailing list that got mangled? Oct 18 14:26:54 send it as an inline attachment Oct 18 14:29:03 vanDrunen: I have. It's the first time I screwed my patch. Oct 18 14:29:23 what client are you using? Oct 18 14:29:37 Thunderbird Oct 18 14:30:23 http://www.mjmwired.net/kernel/Documentation/email-clients.txt Oct 18 14:31:00 that's list of clients and things to do to get patches sent properly Oct 18 14:31:10 I know, but there are dos EOL in this patch which can't be sent inline Oct 18 14:31:32 then fix the patch Oct 18 14:31:36 then you might have to MOME encode Oct 18 14:31:37 MIME Oct 18 14:32:36 DonkeyHotel: I have a small patch ready to send, could I send it to you to see if it;s formatted correclty? Oct 18 14:32:53 DonkeyHotei: I fixed it, just did not send it yet because of Thunderbird. Oct 18 14:32:54 before dumping it on the list Oct 18 14:33:00 if it has CR-LF, it's not correct Oct 18 14:34:40 DonkeyHotei: but I can't speak for devs of this program - it's a patch for it's source Oct 18 14:35:02 DonkeyHotei: if the source files being patches have CR-LF/non native line endings, your patch will have them, too Oct 18 14:35:14 ugh Oct 18 14:35:30 in that case, i have no idea Oct 18 14:35:37 abd as far as I understood, that is the problem Oct 18 14:36:04 yes, it is Oct 18 14:36:41 bright_laptop: send the patch as an attachment (uncompressed); patchwork can cope with that Oct 18 14:37:12 KanjiMonster: and how about line Signed-off-by? Oct 18 14:37:34 Jo Phillip told me that this line should be in patch. Thats why I am confused about. Oct 18 14:38:01 I always sent a patch as an inline attachment Oct 18 14:38:11 bright_laptop: are you using svn or git for creating the patch? Oct 18 14:38:13 add it to the patch file before attaching Oct 18 14:38:17 svn Oct 18 14:38:38 then ugh, no idea. Oct 18 14:38:54 but I think patchwork merges the SOB into the patch Oct 18 14:39:31 I think patchwork merges any *-by: lines into the patch Oct 18 14:39:50 but I have no private patchwork isntance to test ;) Oct 18 14:40:28 funny thing is that my mangled patch is in feeds repo Oct 18 14:41:02 KanjiMonster: Could you instruct me with creating the same patch using git? Oct 18 14:41:56 bright_laptop: have you ever worked with git? Oct 18 14:42:03 A little. Oct 18 14:42:16 okay Oct 18 14:43:13 then clone nbd's git, do your thing, commit, and then use git format-patch -1 to create a .patch file that you can even send out with git send-email Oct 18 14:43:33 okay, wait a second :) Oct 18 14:43:53 (git send-email is probably a separate package on your distro, at least it is in debian) Oct 18 14:45:50 also, it requires a working command line mail setup. but it does work nicely for making sure things are as mangle free as possible. Oct 18 14:46:00 my patch just got picked up by patchwork :) Oct 18 14:46:01 http://patchwork.openwrt.org/patch/2784/ Oct 18 14:46:57 Kaloz: I asked yesterday about being package maintainer for mosquitto, as per florian's suggestion on the mailing list, but didn't see a response. Is there a better time or a better place to ask? or someone else I should ask instead? Oct 18 14:47:23 karlp: have more patience ;) Oct 18 14:50:31 no sweat, I've asked on and off, just hadn't seen any response, wasn't sure he'd even seen it Oct 18 14:51:34 KanjiMonster: if my patch is for feeds packages, I suppose I should clone nbd's package repo Oct 18 14:51:42 bright_laptop: right Oct 18 14:54:37 KanjiMonster: sorry for so many questions.. Before commiting I should set via git config all global variables, right? Oct 18 14:54:44 as user.name and user.email Oct 18 14:55:49 that's preferreble Oct 18 14:56:16 especially since it allows you to use git commit -s, which will automatically add your signed of by to the commit Oct 18 14:57:06 when committing, which params should I use? only git commit -s? Oct 18 14:57:21 in case you want to try git send-email, you can also provide a default to address in the config (then probably git local, not global) Oct 18 14:57:45 I can't use git send-email due to security restrictions here Oct 18 14:58:13 bright_laptop: the normal flow is git add ; git commit [-s] Oct 18 14:58:22 you can check if the commit looks right with git show -1 Oct 18 15:01:03 it looks like almost the same as with svn, nicee :) Oct 18 15:05:50 KanjiMonster: When it's done (git format-patch -1) then I can send this patch to mailing list without adding Signed-off-by line, because it's in the patch, right? :) Oct 18 15:07:32 bright_laptop: yes Oct 18 15:08:08 KanjiMonster: Thank you so much! :) Oct 18 15:09:37 bright_laptop: you're welcome :) Oct 18 15:16:22 KanjiMonster: I am struggling with the instructions on dev.openwrt.org that we are not allowed to send a patch as an attachment. But I think it should be ok when I send it as an attachment. Oct 18 15:16:57 bright_laptop: "Exception: If your mailer is mangling patches then someone may ask you to re-send them using MIME." Oct 18 15:17:10 ;) Oct 18 15:17:32 I do not know if Thunderbird does it. Oct 18 15:18:43 How about sending it as an attachment, also an URL to git diff and svn diff? ultimate solution :-/ Oct 18 15:21:34 bright_laptop: you could use "git send-email" Oct 18 15:22:49 bright_laptop: it definitely shouldn't mangle the attachement Oct 18 15:28:35 the config option DISPLAY_SUPPORT in menuconfig is for showing/hiding packages that require display support, but should packages that provide display support (framebuffer drivers) depend on this option as well? Oct 18 15:50:56 KanjiMonster: the last question - I was not succesfull with sending email via git send-email due to some restrictions. So - only sending an empty mail with the right subject and this http://suzelly.opf.slu.cz/~sla463/01-snortsam-mangled-patch-fix.patch patch as an attachment is ok? Oct 18 16:11:46 * bright_laptop just need confirmation if that's ok, if so, I am sending it right away Oct 18 16:30:54 ping Delboy Oct 18 17:36:52 KanjiMonster: Is that patch ok? http://patchwork.openwrt.org/patch/2785/ Oct 18 17:38:33 hehe, patching patches is always fun. Oct 18 17:39:08 I would say that it is better to delete them and add them again. Oct 18 17:42:08 hi folks. I'm enabling kmod-sched package (in kernel modules/network support) and it's building/installing them fine. however nothing is created at /etc/modules.d so the modules are never loaded. is it a bug or a feature? Oct 18 17:48:07 bright_laptop: looks good (sorry, I was away) Oct 18 17:48:32 KanjiMonster: I tried to apply this patch to my buildroot, but it hunks again :( Oct 18 17:48:45 patching patch is ok, but it hunks during compilation Oct 18 17:49:14 jwendell: do you have the appropriate autoload directives_ Oct 18 17:49:18 ? Oct 18 17:49:18 I just can't send it unmangled :( Oct 18 17:49:36 KanjiMonster, sorry? Oct 18 17:49:46 I don't know... Oct 18 17:50:00 ah, wait I thought you added your own kmod package Oct 18 17:50:09 nope Oct 18 17:51:17 jwendell: there are several kmod packages that does not work - but I can take a look on it when I will resolve my mangling issue :( Oct 18 17:52:05 that's what I wanted to know. if it's a bug I could try to cook a patch Oct 18 17:52:42 I just didn't want to waste some time to find that it's a 'wanted' behavior :) Oct 18 17:53:01 jwendell: check that the autoload line matches the module names Oct 18 17:53:11 (or even that it does have one) Oct 18 17:54:09 ok Oct 18 17:54:22 okay, it doesn't Oct 18 17:57:42 bright_laptop: git am --keep-cr 01-snortsam-mangled-patch-fix.patch does the trick for me; after that it applies fine Oct 18 17:58:21 even before compilation after sources of snortsam are downloaded? Oct 18 17:59:49 bright_laptop: http://pastebin.com/SGNGyu8R Oct 18 18:00:42 Oh, thank you. I patched it via patch -p0< and thought that I screwed it up again Oct 18 18:01:34 https://dev.openwrt.org/browser/trunk/package/admswconfig/files/admswconfig Oct 18 18:01:39 does this file do anything? Oct 18 18:02:25 bright_laptop: looks like patch does not support keeping crlf's as such, but git am does the right thing if you tell it to Oct 18 18:02:31 if all targets have a /etc/config/network file, it always exits on the first line Oct 18 18:02:59 bright_laptop: I'll do a test compile and if it works, I'll commit it Oct 18 18:03:40 Thank you ^_^ Oct 18 23:50:13 karlp: considering I tried over a year ago to get some of the faux maintainers commit access (with no responses to me or them afaik) the admin issue is mostly a joke at this point Oct 18 23:55:28 jow_laptop: didn't you intend to move sysfsutils to package/utils rather than packages/utils in r33806? Oct 19 00:36:18 swalker: all I can do is ask :) Oct 19 00:36:54 the -devel list suggests at a new plan for the packages repo, which seems like a generally good idea, and it's easy to ask/offer **** ENDING LOGGING AT Fri Oct 19 03:00:01 2012