**** BEGIN LOGGING AT Fri May 08 02:59:59 2015
May 08 08:08:55 <Tofe> morning!
May 08 08:14:24 <Tofe> Herrie: my popover work is working, I've done a separate PR against your herrie/work branch :)
May 08 08:59:50 <Tofe> Herrie, morphis: looks like I did a mistake with my test-desktop PR: a qmldir file is missing in the resulting package because I forgot to correctly include it in the .pro file. I'll update the PR.
May 08 09:00:23 <Tofe> Herrie: We'll need to rebase on top of tofe/test-desktop, but it should be easy.
May 08 09:04:00 <Tofe> PR updated.
May 08 09:07:05 <morphis> Tofe: ok
May 08 09:07:57 <Tofe> With the new PR, it works well. It's just that I didn't realize I had copied the file earlier on my N4 when I tested, so I didn't see the qmldir file was missing in the package.
May 08 09:08:29 <Tofe> But anyway I guess we will wait until the release is out
May 08 10:46:27 <morphis> Herrie: time to give http://build.webos-ports.org/luneos-stable-staging/034/ a go before I merge it to the public?
May 08 11:04:09 <Tofe> morphis: I can test mako, if Herrie isn't very available these days
May 08 11:11:54 <morphis> ok
May 08 11:11:57 <morphis> just a rough test
May 08 11:13:22 <Tofe> already flashing
May 08 11:20:53 <Tofe> morphis: all good to me
May 08 11:22:36 <morphis> Tofe: great
May 08 11:24:03 <morphis> JaMa: can you copy the images then to releases/?
May 08 11:31:27 <morphis> Tofe: from what I read, are you going to implement a phone keyboard layout?
May 08 11:34:40 <Tofe> well, we need one; but do you think the one from the Veer is good? I never tried it
May 08 11:35:11 <Tofe> Otherwise we can simply adapt the webos 3.0 keyboard
May 08 11:35:22 <morphis> I would go with the one which is in 3.0
May 08 11:35:40 <Tofe> there is a phone layout?
May 08 11:36:04 <Tofe> I never really looked for it
May 08 11:36:40 <morphis> yeah
May 08 11:36:55 <Tofe> oh ok, so in that case, yes, let's start with that
May 08 11:36:56 <morphis> https://github.com/openwebos/keyboard-efigs
May 08 11:37:24 <morphis> that is the one you see on http://www.webosnation.com/checking-out-galaxy-nexus-open-webos-port-virtual-keyboard-video
May 08 11:41:51 <Tofe> morphis: ok great, yeah I can work with that base
May 08 11:46:05 <Tofe> But we need to prepare the field first: we need the LunaNext Units import available for the maliit qml plugin, as well as a way to expose some settings like isTabletUi
May 08 11:46:30 <morphis> Tofe: can't you just use it in the maliit qml plugin?
May 08 11:46:36 <morphis> as the component should be installed, right?
May 08 11:47:21 <morphis> and afaik Settings.tabletUi is already there when you import LunaNext.Common
May 08 11:47:40 <morphis> which behaves according to what is configured in /etc/palm/luna-platform.conf
May 08 11:47:46 <Tofe> morphis: I didn't say it was difficult, we just need to extend the list of directories that are searched in for imports
May 08 11:48:38 <morphis> ok
May 08 11:52:56 <Tofe> oh, wait, they are in /usr/lib/qt5/qml ... isn't that the standard qt path?
May 08 11:53:50 <Tofe> yes it is! ok, it'll work as-is :)
May 08 12:03:14 <Tofe> Yes, it works out of the box :)
May 08 12:08:20 <Herrie|Veer> Back from lunch
May 08 12:11:45 <Tofe> morphis: so we're good to merge the test-desktop PR, I guess ? that would help going forward with vkb improvements
May 08 12:14:09 <Herrie|Veer> morphis: Already tested the WIP one from yesterday
May 08 12:16:20 <Herrie|Veer> On N4 and Tofe's fix sorted the rotation issue with space between vkb and card
May 08 12:17:12 <Tofe> Herrie|Veer: what pending changes do you have on top of tofe/test-desktop? can I go on with a quite large refactoring?
May 08 12:17:59 <Herrie|Veer> Tofe: The changes I have pending are mainly in the various qml files
May 08 12:18:13 <Herrie|Veer> So you can go ahead and I'll rebase on top of yours
May 08 12:18:32 <Herrie|Veer> Maybe you'll clean out some Ubuntu stuff like debian folder etc as well?
May 08 12:18:55 <Tofe> ok. The first one I'll do will be to have two layout variants, one phone and one tablet
May 08 12:19:21 <Tofe> the second one will be to use our Units from LunaNext.Common
May 08 12:19:38 <Herrie|Veer> OK that makes sense. I guess well have a keyboard_en_*form-factor*.qml or so?
May 08 12:19:50 <Herrie|Veer> Tofe: Yeah that would be good :)
May 08 12:19:51 <Tofe> yes, something like that
May 08 12:19:57 <Herrie|Veer> OK :)
May 08 12:20:17 <Herrie|Veer> I'll keep on working on other improvements to make it more 3.x like
May 08 12:20:22 <Herrie|Veer> We need a bit of carret work
May 08 12:20:29 <Herrie|Veer> I don't like it's alignment :P
May 08 12:20:37 <Herrie|Veer> But that's cosmetics for later
May 08 12:38:43 <Tofe> Herrie|Veer: the alignment is incorrect on device, also.
May 08 12:39:17 <Tofe> and having an usual height for number creates the empty space at the bottom of the keyboard
May 08 12:42:13 <Herrie|Veer> Tofe: I sent you a screenshot + legacy code by email
May 08 12:42:31 <Herrie|Veer> It's C but shouldn't be too hard to replicate I guess?
May 08 12:46:23 <Tofe> Herrie|Veer: basically, it says that it nb or chars is more than 5, it breaks into two lines.
May 08 12:46:31 <Tofe> if*
May 08 12:46:38 <Tofe> if number of chars*
May 08 12:49:28 <Herrie|Veer> Tofe: That could be. You saw what I meant with the carret?
May 08 12:49:47 <Herrie|Veer> On legacy it's in the middle on yours it's to the side a bit
May 08 12:50:12 <Herrie|Veer> Other than that I'm very happy with how it works :)
May 08 12:52:36 <Tofe> Herrie|Veer: I see what you meant, but with the BorderImage it might prove a bit difficult to achive it
May 08 13:01:00 <Herrie|Veer> We're not "married" to BorderImage right :)
May 08 13:06:01 <Tofe> right :)
May 08 13:10:05 <Herrie|Veer> If you need me to cut up images happy to do so :P
May 08 13:20:40 <Tofe> Herrie|Veer: yes, we'd need to cut the carret bg in 5 parts: left, between-left-and-pointer, pointer, between-pointer-and-right, right
May 08 13:21:00 <Tofe> the 'between" parts should be reduced to width=1
May 08 13:23:42 <Herrie|Veer> The left and right between ones should be the same theoretically right?
May 08 13:23:56 <DougReeder> On the phone keyboard, it would really help me if the letters labels were larger.
May 08 13:24:07 <DougReeder> My middle-aged eyes find them hard to read.
May 08 13:24:48 <Tofe> right
May 08 13:26:01 <Herrie|Veer> DougReeder: We'll eventually differentiate between a phone and tablet vkb layout
May 08 13:26:21 * DougReeder nods. “I can read the tablet keyboard ok”
May 08 13:26:21 <Tofe> its ongoing ;)
May 08 13:26:40 <Herrie|Veer> Currently I'm working with Tofe to make tablet one look more like the 3.x/LunaCE one
May 08 13:27:21 <Herrie|Veer> There's phone vkb assets in LunaSysMgr that can be seen in the early Open webOS videos (almost black bg with bold white letters)
May 08 13:28:26 <Tofe> oh, it's not in the unstable branch of keyboard-efigs?
May 08 13:28:53 <Tofe> ah, seem to be the same.
May 08 13:28:55 <Herrie|Veer> Tofe: Well probably it's the same
May 08 13:29:15 <Herrie|Veer> I mean the woce/lunasysmgr was opensourced as part of the TP lunasysmgr open sourcing
May 08 13:29:27 <Herrie|Veer> EFIGS was released a month or 2 later
May 08 13:29:57 <Tofe> ok, yes I guess they didn't change any image in between
May 08 13:35:21 <Tofe> Herrie|Veer: https://github.com/webOS-ports/webos-keyboard/commits/tofe/work-herrie <-- the Units change had quite an impact on the appearance
May 08 13:36:31 <Herrie|Veer> Tofe I already did quite some change at my end and made it 10 instead of 12 already
May 08 13:36:38 <Herrie|Veer> So I think I'll be OK :P
May 08 13:38:14 <Herrie|Veer> Nexus used 12 and TP had 10 so did those changes locally before already :P
May 08 13:41:01 <Herrie|Veer> My current work is all based on 10 and that looks good
May 08 13:41:35 <Herrie|Veer> You saw that in the caret screenshot I sent across that's all 10 based and not 12
May 08 13:42:24 <Tofe> yes
May 08 13:42:57 <Herrie|Veer> Anyway I can make adjustments where needed ;)
May 08 13:44:12 <Herrie|Veer> DougReeder: You still have the vkb with arrows on your TP?
May 08 13:44:41 <DougReeder> No, I updated to the latest, with the virtual trackball
May 08 13:45:06 * DougReeder smiles. “But I’m planning to revert ot the one with the arrow keys. I like it better."
May 08 13:46:09 <Herrie|Veer> OK once you do, can you send me a few screenshots?
May 08 13:46:13 <Tofe> DougReeder: the arrows seem more suited for a phone layout
May 08 13:46:18 <Herrie|Veer> So we can implement both?
May 08 13:46:32 <Herrie|Veer> And have a Tweaks option for it :)
May 08 13:46:39 <Tofe> hehe
May 08 13:46:56 <Herrie|Veer> Since Tofe is now anyway implementing our common Luna Next imports that would be quite easy :)
May 08 13:47:12 <DougReeder> You want a screenshot including the VKB with the arrow keys, Herrie?
May 08 13:47:46 <Herrie|Veer> Yeah ;)
May 08 13:48:01 <Herrie|Veer> Forgot it's placement and how it looked tbh been a while
May 08 13:48:27 <Tofe> same placement
May 08 13:48:41 <Tofe> looks like two arrows left/right :)
May 08 13:49:06 <Herrie|Veer> Ah that's easy to do then :)
May 08 13:49:17 <Tofe> oh yes, very easy
May 08 13:51:27 <Herrie|Veer> Tofe: You got mail with images cut up. Did both popups
May 08 13:52:26 <Herrie|Veer> popup 2 seems used for multi line
May 08 13:52:44 <Herrie|Veer> Seems it m
May 08 13:52:46 <Tofe> Herrie|Veer: yes thanks
May 08 13:52:53 <Tofe> yes exactly
May 08 13:52:54 <Herrie|Veer> Well 2 lines not multi :P
May 08 13:53:08 <Tofe> 3 lines was not managed by legacy :)
May 08 13:53:43 <Herrie|Veer> Not sure we need that many :P
May 08 13:56:12 <Herrie|Veer> I noticed the , is different for our and legacy keyboard though we both seem to use Prelude :s
May 08 13:56:40 <Herrie|Veer> All legacy Prelude fonts had a proper comma, our doesn't seem to be proper :s
May 08 14:06:44 <Herrie|Veer> Tofe: you know where this drop shadow comes from on the text for Tab, Enter and +=[] keys? I cannot seem to find it...
May 08 14:15:31 <DougReeder> Screenshot of LunaCE keyboard w/ arrow keys is at http://hominidsoftware.com/non-public/LunaCE_keyboard_arrows.png
May 08 14:21:09 <Herrie|Veer> DougReeder: Thnx :)
May 08 14:50:49 <Herrie|Veer> JaMa: ping
May 08 14:51:54 <Herrie|Veer> Tofe I think we can drop the import UbuntuKeyboard 1.0 as well?
May 08 15:26:35 <Tofe> Herrie|Veer: I think the drop shadow are simply a text font tweak
May 08 15:27:20 <Tofe> and as for the UbuntuKeyboard import, I was going to do a big cleanup of these "ubuntu" strings which are either luneos-wannabe or should be dropped
May 08 15:27:59 <Tofe> But first I wanted to finish this tablet/phone switch in the source code, to have something nice to work with
May 08 15:28:37 <Tofe> some constants will differ, and some images are different, but the same infrastructure should be used
May 08 15:41:49 <Herrie|Veer> Tofe: Yup agree shouldn't be rocket science indeed ;)
May 08 15:42:11 <Herrie|Veer> Tofe: I cannot locate them anywhere hence I was confused :P
May 08 16:01:15 <Tofe> Herrie|Veer: https://github.com/Herrie82/webos-keyboard/pull/3 <-- that's a big one, with Units and form factor
May 08 16:02:00 <Tofe> also after you merge that one, can you rebase it on top of test-desktop ? I fell we will soon merge that PR
May 08 16:02:03 <Tofe> feel
May 08 16:03:46 <Tofe> Also, for trying one form factor or the other in Qt Desktop, simply change the tabletUi value in LunaNext/Common/SettingsStub.js
May 08 16:04:26 <Tofe> now, let's fix that caret...
May 08 16:05:01 <Herrie|Veer> Tofe: OK great stuff! I'm working on the symbol kb now can be simplified with the number row :)
May 08 16:07:18 <Herrie|Veer> Once caret is fixed can adopt it for languages and kb sizes too :)
May 08 16:32:24 <Tofe> Herrie|Veer: I think I got the caret right
May 08 16:34:03 <Herrie|Veer> :D
May 08 16:38:02 <Herrie|Veer> Tofe: How do I rebase it on top of test-desktop?
May 08 16:41:00 <Tofe> Herrie|Veer: first, merge my very latest PR
May 08 16:42:54 <Tofe> then, do "git remote add upstream https://github.com/webOS-ports/webos-keyboard.git" and then "git rebase upstream/tofe/test-desktop"
May 08 16:44:15 <Tofe> certainly, git will ask that you commit your remaining changes first
May 08 16:57:41 <Tofe> Herrie|Veer: what we can actually do is to invert the way we work: I do the rebase, and then you PR into tofe/work-herrie (which I'll rename to something else)
May 08 16:59:27 <Herrie|Veer> OK!
May 08 16:59:42 <Herrie|Veer> That might be easier :)
May 08 17:02:35 <Tofe> I cancel the current PR?
May 08 17:04:34 <Herrie|Veer> Sure
May 08 17:05:33 <Tofe> ok let's go
May 08 17:10:57 <Tofe> Herrie|Veer: there is now  a tofe/test-desktop-work in webos-keyboard
May 08 17:11:07 <Tofe> it's rebased and up-to-date
May 08 17:54:52 <Tofe> Herrie|Veer: did you try the phone layout yet?
May 08 17:58:10 <Herrie|Veer> Tofe: Looks good, will go for dinner and have a look just came home ;)
May 08 18:01:04 <Tofe> oh it's 8 o'clock already!
May 08 18:02:43 <morphis> :)
May 08 18:03:49 <morphis> Tofe: https://github.com/webOS-ports/luna-next-cardshell/pull/221
May 08 18:07:06 <Tofe> morphis: looks good; ready for merging?
**** ENDING LOGGING AT Sat May 09 02:59:59 2015