**** BEGIN LOGGING AT Sun May 17 02:59:58 2015
May 17 06:12:22 <Herrie> Tofe: Since NotificationManager is our code, it could be that the bug is there and the icon itself gets stripped? Could you have a look? It's C++ stuff so I try to keep away from that
May 17 06:12:46 <Herrie> I could do the dirty +"icon.png" but that's really nasty ;)
May 17 07:29:13 <Tofe> Herrie: could you point me to some Enyo1 app source code?
May 17 07:29:22 <Tofe> at least the appinfo
May 17 07:30:15 <Tofe> Herrie: adding +"icon.png" would just break all the other apps, it's not the right fix :)
May 17 07:37:30 <Herrie> Tofe: Well most apps will have an icon.png in their root ;)
May 17 07:38:16 <Herrie> Let me find one for you ;)
May 17 07:43:24 <Herrie> Tofe: You got mail
May 17 07:43:39 <Herrie> It's from the app catalog, not 100% sure about it's legal status so not posting it here
May 17 07:43:49 <Herrie> I included a legacy screenshot of the notification as well.
May 17 07:46:40 <Tofe> ok thanks, will try that
May 17 07:48:09 <Herrie> appinfo.json doesn't have anything special
May 17 07:51:45 <Herrie> Legacy has: addBannerMessage: function(inMessage, inJson, inIcon, inSoundClass, inSoundPath, inSoundDuration), so it seems you can specify the icon, sound and duration to use, but it's not used always and icon is still displayed. Let me see if I can find more about this in the source code to see what it uses as "default" icon.
May 17 07:53:04 <Tofe> ah ok, I don't know what's provided in that case
May 17 07:54:27 <Herrie> Let me dig a bit
May 17 07:56:49 <Herrie> Well https://github.com/woce/LunaSysMgr/blob/a8f94c9171da2af9cdf25a820af6f2a2d68123fc/Src/js/JsSysObject.cpp#L2127
May 17 07:57:22 <Herrie> That suggests there's no default icon, however in the example I sent you, there's an icon, even though none is specified explicitly in Enyo code...
May 17 07:57:45 <Herrie> And the same is the case for Tweaks....
May 17 07:58:01 <Tofe> but Tweaks works, right?
May 17 07:59:23 <Herrie> No, it's black and hidden, remember?
May 17 08:00:21 <Tofe> ah, yes
May 17 08:00:32 <Tofe> well, just black, let's say (no icon)
May 17 08:00:36 <Herrie> Yeah
May 17 08:00:43 <Herrie> Well the text is hidden because of missing icon
May 17 08:00:56 <Tofe> ah, that's pretty dumb
May 17 08:02:21 <Herrie> I got all TP apps here, let me search through source code for more banner msgs
May 17 08:02:45 <Tofe> Herrie: I need to debug the touch focus issue first, I think
May 17 08:03:00 <Herrie> Tofe: Sure
May 17 08:03:06 <Herrie> Just thought this might be a quick fix :P
May 17 08:03:09 <Herrie> But appears it's not
May 17 08:03:22 <Herrie> Let me see what other apps I have with dashboards and see how their behavior is on legacy
May 17 08:03:33 <Tofe> maybe the fix for that bug will simply to check if we are dealing with a directory ( ==> then add icon.png) or a file (then do nothing) in Luna-SysMgr
May 17 08:03:37 <Herrie> Then you have time for the touch focus issue ;)
May 17 08:04:09 <Herrie> Simple check as in ends with "\" ?
May 17 08:04:23 <Herrie> Ehm or "/" I mean ;)
May 17 08:04:39 <Herrie> Depends on which OS you are LOL ;)
May 17 08:04:43 <Herrie> Should be / in our case :P
May 17 08:28:02 <Herrie> Tofe: You OK with this solution? https://bpaste.net/show/0aa209c62254
May 17 08:51:58 <Tofe> Herrie: it's one way to put it, but franckly I was more thinking of doing it in C++ with a proper fstat() call
May 17 08:57:05 <Herrie|Laptop> I know it's not the nicest, but well should work. I suggest to do it this way for now and you can do a nice proper C++ solution when you got time?
May 17 08:57:57 <Tofe> ok
May 17 09:10:50 <Herrie> Tofe: https://github.com/webOS-ports/luna-next-cardshell/pull/222/files
May 17 09:53:56 <Tofe> Herrie: the PR is already tested on device?
May 17 10:28:17 <Herrie> Tofe: Yeah tested it on N4 and worked there
May 17 10:28:32 <Herrie> At least tested 1 of the 3 files but solution is the same for all 3
May 17 10:28:37 <Herrie> So if I works all 3 should work
May 17 10:28:55 <Herrie> I can test now if you want just ot be sure
May 17 10:30:57 <Herrie> It works :)
May 17 10:41:51 <Herrie> Tofe: http://tinypic.com/r/xn5eok/8
May 17 10:42:04 <Herrie> Don't mind the icon quality, it's bad in general even in original app ;)
May 17 12:43:41 <Tofe> Herrie: thanks, merged
May 17 14:39:30 <Herrie> Tofe: Thnx, working on phone VKB now doing some tweaks to make it look like the one in OWO
May 17 18:18:55 <Tofe> morphis: I think I'll have to do a local rebuild on my machine to debug the touch issue
May 17 18:21:26 <Tofe> I'm suspecting https://qt.gitorious.org/qt/qtwayland/commit/498946d6e9c20d4e8af28ee942de5bf4cf5eaf78 , but maybe it's correct code
May 17 18:31:45 <Tofe> morphis: mmh, is everything pushed ? I'm trying to build my new dizzy, and meta-qt5 doesn't seem to be updated to 5.4.1
May 17 20:48:06 <Garfonso> DougReeder_: to simulate incomming message add a smsmessage-object Tod db8 with folder = inbox and from field needs to be object with addr field.
May 17 20:49:39 <Garfonso> Chatthreader could use notification service. But then a notification would pop up, even if messaging app has focus. Not sure we want that? And it's not trivial to prevent.
May 17 20:51:22 <Garfonso> Maybe chatthreader should use appmanager to call messaging app with some parameters, like the messaging object or updated chatthread ids and messaging app can decide what to do.
May 17 20:51:42 <Garfonso> For notifications it would then require nowindow.
May 17 21:43:31 <Herrie> Tofe: Did PR for initial work on phone vkb. Still needs a bit of TLC but it's in quite good shape already. Need to check legacy a bit more. Made distinct symbol variants for phone and tablet. Also did soem work on German tablet layout, needs a bit of TLC as well still
**** ENDING LOGGING AT Mon May 18 02:59:59 2015