**** BEGIN LOGGING AT Sat May 30 02:59:59 2015
May 30 07:07:43 <morphis> Tofe: included the fix now and triggered new testing builds for it
May 30 07:17:36 <Herrie|Veer> morning
May 30 07:17:46 <Herrie|Veer> Tofe: vp
May 30 07:17:56 <Herrie|Veer> Tofe: ping
May 30 07:28:58 <Herrie|Veer> Tofe: Did a PR for the further beautification of VKB :)
May 30 07:30:05 <Herrie|Veer> You need to have a look at the tests once more. The tablet/portrait text doesn't work/change properly. Also switching to other devices while in context 1, 2, 3 and 4 gives odd behavior.
May 30 07:32:11 <Herrie|Veer> morphis: The 5.5 WIP also fixes the issue we had with Android 4.4.4? fpermissive stuff?
May 30 07:32:22 <Tofe> Herrie|Veer: ok great :)
May 30 07:33:14 <Herrie|Veer> It looks a lot more proper to me now :)
May 30 07:34:13 <morphis> Herrie|Veer: fpermissive is just a compiler option nothing really exciting
May 30 07:34:24 <morphis> we're using it by default but newer qtwebengine wasn't ready for it
May 30 07:34:31 <morphis> Herrie|Veer: and it's only 5.5 of qtwebengine
May 30 07:34:42 <morphis> and no, it doesn't fix the 4.4 issue
May 30 07:34:55 <morphis> for that we need fixes in https://github.com/mer-hybris/qt5-qpa-hwcomposer-plugin
May 30 07:35:00 <morphis> which isn't part of qt
May 30 07:35:28 <Herrie|Veer> AH OK
May 30 07:35:49 <Herrie|Veer> You had a look at VKB already on N4?
May 30 07:41:46 <Herrie|Veer> Didn't have a chance yet myself probably on Monday when back from Portugal :) But with latest PR should look fairly good :)
May 30 07:45:54 <morphis> Herrie|Veer: hope holiday there was nice :)
May 30 07:46:01 <morphis> Herrie|Veer: and vkb looks nice on N4
May 30 07:53:37 <Tofe> Herrie|Veer: I've inserted my breakfast's comments
May 30 07:57:55 <Tofe> but I didn't try it yet, I may have some others during the day
May 30 08:07:17 <nizovn> btw on tablet layout shifted numkeys enter just number(e.g. 2, when should be @). maybe because of this: https://github.com/webOS-ports/webos-keyboard/blob/master/qml/keys/AnnotatedKey.qml#L105
May 30 08:47:23 <Herrie|Veer> morphis: Sun, see, good food, nothing to complain :P
May 30 09:33:34 <Herrie|Veer> nizovn: I probably have a fix for that
May 30 09:38:24 <nizovn> Herrie|Veer: thanks, this is minor, but may confuse when entering password
May 30 12:01:04 <Herrie|Veer> Tofe: ping
May 30 12:04:01 <Tofe> Herrie|Veer: pong
May 30 12:06:54 <Herrie|Veer> On your comments: For tablet: will update the other 2 toprow heights as well. For phone key width this is a dirty hack to align the keys properly because the have different width on different rows.
May 30 12:08:38 <Herrie|Veer> For the annotated value that nizovn mentioned seems that valueToSubmit cannot be set based on a condition due to it's type. Is it a problem if I change it to string? Or cleaner to set valueToSubmit in onPressed before actually doing the submit?
May 30 12:09:19 <Herrie|Veer> For phone vkb key width is a bit odd hence the hack so the keys align like OWO. This was the easiest way I could accomplish it.
May 30 12:11:34 <Herrie|Veer> Other comments I'll fix, it makes sense to use a consistent approach for the margins/offsets
May 30 12:18:09 <Herrie|Veer> The previous one with Units.gu gave me headaches so came up with something based on the keyWidth :P
May 30 12:26:04 <Herrie|Veer> valueToSubmit is a property alias which needs assigning directly and cannot be conditional it seems. I can make it string but not sure that's desired :P
May 30 13:44:45 <Tofe> Herrie|Veer: I'll have a look at all this :)
**** ENDING LOGGING AT Sun May 31 02:59:59 2015