**** BEGIN LOGGING AT Wed Aug 19 02:59:58 2015
Aug 19 06:09:16 <Herrie> morning
Aug 19 06:09:19 <Herrie> nizovn: ping
Aug 19 06:09:28 <nizovn> Herrie: pong
Aug 19 06:09:32 <nizovn> morning
Aug 19 06:10:24 <Herrie> I found a problem with the userscript you added and want to discuss what would be the best way to deal with this
Aug 19 06:10:33 <Herrie> Page https://www.abnamro.nl/portalserver/nl/prive/index.html?l doesn't load anymore when it's enabled
Aug 19 06:11:02 <Herrie> https://github.com/webOS-ports/org.webosports.app.browser/blob/master/qml/WebView.qml#L115
Aug 19 06:12:58 <Herrie> I now have as a temporary workaround locally that I only load the js/userscript.js when it's not a https site and moved this bit to the onNavigationRequested but that's nasty imho
Aug 19 06:13:36 <nizovn> can confirm this issue
Aug 19 06:15:09 <Herrie> I tried to add console.log to each of the functions in userscript.js but no luck
Aug 19 06:19:54 <nizovn> we can comment out content of userscript.js, leaving only needed touch related functions
Aug 19 06:22:35 <Herrie> Yeah but I would expect that when I put console.log everywhere it would at least show somewhere in the logs in QTCreator and it doesn't
Aug 19 06:22:46 <Herrie> So it seems the whole userscript.js might be a problem?
Aug 19 06:27:34 <nizovn> i tried on stable-staging emulator image, ang that site works
Aug 19 06:28:30 <nizovn> i mean without any modification to userscript.js
Aug 19 06:32:36 <Herrie> nizovn: Top and bottom are OK but middle with login parts are missing here
Aug 19 06:32:41 <nizovn> so it's maybe not caused by userscript, probably i mistyped url in first attempt
Aug 19 06:32:45 <Herrie> Also on same emu
Aug 19 06:35:57 <nizovn> ok, can reproduce now
Aug 19 06:37:08 <Herrie> It's my bank's website which I use daily so for me personally quite critical to work LOL ;)
Aug 19 06:37:43 <Herrie> It stopped working properly on legacy a while back but that was for doing transfers, the login worked fine there ;)
Aug 19 06:38:50 <nizovn> :)
Aug 19 06:39:00 <nizovn> it works if comment out window.onload
Aug 19 06:40:36 <Herrie> Which we don't use right?
Aug 19 06:40:42 <nizovn> yes
Aug 19 06:42:11 <Herrie> Not sure what it's used for anyway. Some input hints or something?
Aug 19 06:45:47 <nizovn> not sure too
Aug 19 06:49:05 <Herrie> Will you do a PR or should I do it?
Aug 19 06:49:24 <nizovn> please, do it
Aug 19 06:49:42 <nizovn> possibly site uses window.onload, and we overwrite it
Aug 19 06:50:13 <Herrie> This code comes from Ubuntu right?
Aug 19 06:50:20 <Herrie> We need to add copyrights as well ;)
Aug 19 06:52:01 <nizovn> i added this: https://github.com/webOS-ports/org.webosports.app.browser/blob/master/COPYING#L27
Aug 19 06:54:40 <Herrie> Who might have borrowe from https://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/Ubuntu/Web/selection02.js
Aug 19 06:54:47 <Herrie> Not sure who invented what ;)
Aug 19 06:55:05 <nizovn> :)
Aug 19 07:36:49 <Tofe> Morning!
Aug 19 07:46:09 <Herrie> Tofe: morning
Aug 19 08:56:51 <Garfonso> morning
Aug 19 13:47:30 <Herrie> Tofe: Did a small PR for browser, nothing shocking ;)
Aug 19 13:47:50 <Herrie> Just fixing my banking site + fixing http://issues.webos-ports.org/issues/961
Aug 19 13:48:07 <Herrie> Not sure this will be the final solution, but seems to do it for now
Aug 19 13:49:30 <Tofe> Herrie: yep, just had a small comment
Aug 19 13:50:37 <Herrie> Yeah will fix that in another PR
Aug 19 13:50:47 <Herrie> This file needs some reformatting & Cleanup in general
Aug 19 13:50:55 <Herrie> I removed most from this PR but seems I missed this one ;)
Aug 19 13:51:09 <Herrie> I'll do another PR to do the formatting/cleanup later
Aug 19 14:01:57 <Herrie> Tofe: I was looking into: http://issues.webos-ports.org/issues/901
Aug 19 14:02:13 <Herrie> Shouldn't we have a \ at the end of https://github.com/webOS-ports/webos-keyboard/blob/master/plugins/en/src/src.pro#l12 ?
Aug 19 14:02:32 <Herrie> Not sure that would fix the missing dict error but wouldn't hurt to fix incorrect syntax?
Aug 19 14:31:10 <Tofe> Herrie: that's a good idea! I didn't see this
Aug 19 14:42:57 <Herrie> Tofe: You agree that it's missing the \ ?
Aug 19 14:45:54 <Tofe> I agree
Aug 19 14:46:27 <Tofe> Herrie: oh, it removed all the ";"... Well, as you wish :)
Aug 19 14:47:15 <Herrie> I need to do a webos-keyboard PR anyway to fix http://issues.webos-ports.org/issues/959
Aug 19 14:47:26 <Herrie> Tofe: QtCreator doesn't seem to need/want them :P
Aug 19 14:47:32 <Herrie> At least not by default
Aug 19 14:47:35 <Herrie> I prefer them too actually
Aug 19 14:48:04 <Tofe> So I merge the PR?
Aug 19 14:48:38 <Herrie> You can ;)
Aug 19 14:48:49 <Herrie> Unless we can tell QtCreator code reformatter to use ;
Aug 19 14:48:52 <Herrie> I didn't find it yet
Aug 19 14:49:01 <Tofe> Usually I use Ctrl+i
Aug 19 14:49:21 <Tofe> It's a light reformatting, does mainly fix the alignements
Aug 19 14:49:39 <Herrie> Ah ok
Aug 19 14:56:49 <Herrie> Did a PR for the missing \ in 16 langs
Aug 19 14:56:53 <Herrie> Will work on 959 now
Aug 19 14:57:00 <Herrie> Should be easy to fix
Aug 19 16:15:36 <Herrie> Tofe: Updated PR with fix for 959
Aug 19 16:15:43 <Herrie> It bit more tricky then I thought but well
Aug 19 16:15:56 <Herrie> Fixed a few other small things too
Aug 19 16:49:15 <Herrie|2> Tofe: ping
Aug 19 17:39:39 <Tofe> Herrie|2: pong
Aug 19 17:40:37 <Tofe> (valid until 19:45)
Aug 19 17:40:48 <Herrie|2> Tofe: I tried debugging luna-systemui Enyo 1 app to see if I can fix the battery dashboards
Aug 19 17:41:01 <Tofe> ok
Aug 19 17:41:02 <Herrie|2> However it seems that the console.logs I add don't appear in journalctl
Aug 19 17:41:04 <Herrie|2> Any ideas?
Aug 19 17:41:05 <Tofe> but?
Aug 19 17:41:20 <Tofe> ah, hmm
Aug 19 17:41:27 <Herrie|2> It seems to work when connected to PC but not to charger, so wanted to add some logging to debug
Aug 19 17:43:53 <Tofe> could be webview or webapp-launcher
Aug 19 17:44:20 <Tofe> I'd have to look at it myself, hard to say
Aug 19 17:44:23 <Herrie|2> I remember we could launch it so it would output some more debugging
Aug 19 17:44:51 <Herrie|2> I already tweaked framework_config.json and put the required values in there as well but to no avail
Aug 19 17:52:46 <Tofe> I'll have a look tonight,  but I have to leave now :) cu
Aug 19 17:53:38 <Herrie|2> Sure no pb ;)
Aug 19 17:53:41 <Herrie|2> No hurry
Aug 19 17:53:59 <Herrie|2> I'll do a new nightly build with the VKB + Browser to see if that fixes the maliit/hunspell stuff ;)
**** ENDING LOGGING AT Thu Aug 20 02:59:59 2015