**** BEGIN LOGGING AT Fri Aug 21 02:59:58 2015
Aug 21 03:26:06 <DougReeder> Herrie, it would be good to pull icons from the location listed in appinfo.json
Aug 21 04:48:08 <Herrie|2> DougReeder: That's what it should do, however it seems only the icon folder is passed instead of the full icon path
Aug 21 04:48:17 <Herrie|2> Trying to figure out where things go wrong
Aug 21 04:48:21 * DougReeder nods
Aug 21 04:50:09 <DougReeder> I’m updating Serene to give better error messages.
Aug 21 04:53:04 <Herrie|2> Serene itself is fine would just like to see the code that makes the notifications/dashboards
Aug 21 04:53:36 <Herrie|2> Hard to read in minified files
Aug 21 05:06:06 <DougReeder> I wrote a function to convert the code in FileErrors into text, then realized the user doesn’t care.
Aug 21 05:06:30 <DougReeder> Whatever the reason the file cant be read, the workaround is the same.
Aug 21 05:06:37 <DougReeder> :-S
Aug 21 05:06:48 * DougReeder waves goodnight
Aug 21 07:14:47 <Herrie|Veer> morning
Aug 21 07:24:57 <Tofe> morning
Aug 21 07:25:01 <Tofe> Herrie|2: I'm around now
Aug 21 07:28:30 <Herrie|Veer> morning
Aug 21 07:28:54 <Herrie|Veer> Tofe: I was looking into missing icons for notifications y'day
Aug 21 07:29:20 <Herrie|Veer> Just I wasn't around when you and morphis put together luna-next and luna-next-cardshell :P
Aug 21 07:29:50 <Herrie|Veer> So I'm not really familiar with how things work there. I was able to debug a few bits but it seems not the full icon URL is passed
Aug 21 07:29:54 <Herrie|Veer> But only the folder
Aug 21 07:30:52 <Herrie|Veer> For Serene it expects icon-64x64.png however LNC puts icon.png because it receives a folder the icon instead of full path incl. name.
Aug 21 07:31:17 <Herrie|Veer> I figured this comes from luna-next somehow but that's C++ and got lost :P
Aug 21 07:32:26 <Tofe> Herrie|Veer: the icon for the launcher ?
Aug 21 07:32:46 <Herrie|Veer> Tofe: No for notifications
Aug 21 07:33:28 <Herrie|Veer> The icon that's used there. LNC checks if it's a folder by checking last char / and append icon.png then
Aug 21 07:33:33 <Tofe> ok, let me look at that again; it's based on the AppDescription, but I don't remember the details
Aug 21 07:33:46 <Herrie|Veer> However it should receive a full path with filename but doesn't
Aug 21 07:35:46 <Herrie|Veer> NotificationArea.qml's object.iconUrl has the incorrect value
Aug 21 07:35:57 <Herrie|Veer> Not sure where that comes from but I guess luna-next
Aug 21 07:36:33 <Tofe> Comes from here: https://github.com/webOS-ports/luna-next/blob/master/plugins/shell/notifications/notification.h
Aug 21 07:36:52 <Tofe> I'm still looking for where we create these objects
Aug 21 07:38:06 <Tofe> Looking at getIconUrlOrDefault, it looks like it's going to take the full path if there is one
Aug 21 07:38:40 <Herrie|Veer> Yeah but normally the app would provide the full icon path incl filename
Aug 21 07:38:52 <Herrie|Veer> I got as far as that luna-next bit as well :P
Aug 21 07:38:55 <Herrie|Veer> Then I got stuck
Aug 21 07:39:24 <Herrie|Veer> I checked com.palm.applicationMananger and there the icon location is fine
Aug 21 07:39:41 <Tofe> ok, I'll have to see where we extract the appinfo informations
Aug 21 07:40:45 <Herrie|Veer> Yeah it's either from appinfo.json or from com.palm.applicationManaget
Aug 21 07:40:55 <Herrie|Veer> s/t/r
Aug 21 07:41:11 <Tofe> because luna-next only forwards what it gets
Aug 21 07:41:17 <Herrie|Veer> It probably strips the filename or just takes app path while it should take the icon
Aug 21 07:41:44 <Herrie|Veer> applicationManager has the correct info. Not sure where luna-next gets it from? Lunasysmgr?
Aug 21 08:23:28 <Tofe> I think so
Aug 21 08:26:13 <Tofe> Looks like https://github.com/webOS-ports/luna-webappmanager/blob/master/src/applicationdescription.cpp is alright, it always tries to take the tull path
Aug 21 08:30:30 <Herrie|Veer> Line 109 there shouldn't cause issues but might be good to double check
Aug 21 08:32:43 <Herrie|Veer> Tofe you might want to check src/extensions/palmsystemextensions.cpp line 250
Aug 21 08:34:17 <Herrie|Veer> I think that might be the culprit
Aug 21 08:34:49 <Tofe> Well, it doesn't check that it is a file, but it doesn't strip the filename either
Aug 21 08:35:27 <Tofe> The starting point being the icon parameter value given to the banner call
Aug 21 08:37:59 <Tofe> Do you get the debug informations from webappmanager ?
Aug 21 08:38:18 <Herrie|Veer> Tofe: Need to check
Aug 21 08:38:34 <Herrie|Veer> It shows the full icon in the journalctl
Aug 21 08:38:41 <Herrie|Veer> With one of the logs I have
Aug 21 08:39:05 <Tofe> do you get a "PalmSystemExtension::addBannerMessage" string in the journal ?
Aug 21 08:39:52 <Tofe> I begin to believe the application itself sent a banner call with a stripped path
Aug 21 08:42:19 <Herrie|Veer> DougReeder uses: PalmSystem.addBannerMessage(t.description,"{}","assets/icon64x64.png",Oalerts")
Aug 21 08:42:26 <Herrie|Veer> Which looks OK to me
Aug 21 08:44:05 <Herrie|Veer> s/Oalerts/"alerts
Aug 21 08:44:58 <Herrie|Veer> I've seen it on other occasions as well that worked ok on legacy (Tweaks for example)
Aug 21 08:48:54 <Tofe> ok, yes, seems alright
Aug 21 08:51:38 <Tofe> Could you paste an extract of your journalctl when a banner message is sent and notification is shown?
Aug 21 08:52:46 <Herrie|Veer> Tofe let me try something
Aug 21 09:07:55 <Herrie|Veer> adb doesn't work here and the wifi is extemely slow the N4 connected to :P
Aug 21 09:08:02 <Herrie|Veer> But it's trying to send something
Aug 21 11:34:14 <DougReeder> I’m not sure what you have, or which version exactly is in my feed, but older versions of Serene didn’t pass an explicit icon to addBannerMessage.
Aug 21 11:37:05 <DougReeder> THe current version does explicitly pass an icon, and the banner and dashboard do display it.
Aug 21 11:53:27 <Herrie|Veer> DougReeder: Ah that might explain. I just checked your app.js on your site. The appinfo.json on device shows the correct icon. So the fix might just be getting the icon from appinfo.json instead of assuming it's named icon.png
Aug 21 12:17:28 * DougReeder nods, and heads out to work
Aug 21 12:18:45 <Herrie|Veer> I'll double check tonight to see what your version in the feed does
Aug 21 12:19:06 <Herrie|Veer> Could be we just need to fix the logics and use the appicon instead of app basepath + icon.png
Aug 21 14:10:22 <JaMa> Hi
Aug 21 14:11:06 <JaMa> Tofe: there are some changes from you in qtwayland/webOS-ports/master-next, are they ready for webOS-ports/master branch?
Aug 21 14:11:14 <JaMa> I would like to rebase qtwayland/webOS-ports/master-next for qt 5.5
Aug 21 14:22:44 <JaMa> rebased and added tags before and after just in case
Aug 21 14:33:55 <Tofe> JaMa: yes it's safe
Aug 21 18:23:35 <Herrie|2> Tofe: Ping
Aug 21 18:30:53 <morphis> Herrie|2: you really should keep the pivotce feed disabled by default
Aug 21 18:30:55 <morphis> we can't control what ends up in there and don't want to run into any legal issues
Aug 21 18:33:07 <Herrie|2> morphis: We discussed this with ka6sox before and I think he was happy with enabling it because it's being reviewed multiple times
Aug 21 18:33:10 <Herrie|2> Let me dig in logs
Aug 21 18:33:59 <morphis> what is reviewed?
Aug 21 18:34:57 <Herrie|2> Submissions to their feed, similar to precentral one
Aug 21 18:35:38 <Herrie|2> Let me find the logs
Aug 21 18:35:41 <Herrie|2> I could be wrong of course
Aug 21 18:35:46 <Herrie|2> Anyway we can disable it quickly too
Aug 21 18:37:54 <morphis> I would prefer that
Aug 21 18:38:17 <morphis> every user can quickly enable that and their is a warning on first preware start
Aug 21 18:39:36 <Herrie|2> morphis: True
Aug 21 18:41:21 <Herrie|2> OK changed that
Aug 21 18:41:26 <Herrie|2> Will be in next build :)
Aug 21 18:41:41 <Herrie|2> If I were to cancel current build, I just cancel main one?
Aug 21 18:41:49 <Herrie|2> So luneos-testing_build ?
Aug 21 18:42:08 <morphis> right
Aug 21 18:42:35 <Herrie|2> And then just restart or need to do some cleanup?
Aug 21 18:53:00 <morphis> Herrie: just restart
Aug 21 19:03:55 <Herrie> morphis: OK
Aug 21 19:06:34 <Herrie> You have any idea how we end up with just an appicon path and not the full path + filename?
Aug 21 19:07:00 <Herrie> It's probably somewhere in luna-next or the luna-webappmanager but I couldn't find anything obvious
Aug 21 19:07:06 <Herrie> Nor could Tofe it seems
Aug 21 19:52:37 <Tofe> Herrie: pong
Aug 21 19:55:59 <Herrie> Tofe: Any chance that you could send me ipk for the luna-webappmanager with some more logging around the icon?
Aug 21 20:15:00 <Tofe> Herrie: well, what more logging ? there are already quite some qDebug here and there
Aug 21 20:15:12 <Tofe> (I just don't know if they output something...)
Aug 21 20:15:52 <Tofe> Herrie: what is your scenario?
Aug 21 20:21:24 <Herrie|Laptop> Tofe: I think we can use a bit more
Aug 21 20:22:41 <Herrie|Laptop> Maybe after https://github.com/webOS-ports/luna-webappmanager/blob/master/src/applicationdescription.cpp#L109
Aug 21 20:22:58 <Herrie|Laptop> To see what each of mIcon.isEmpty() || !mIcon.isLocalFile() || !QFile::exists(mIcon.toLocalFile() returns
Aug 21 20:23:37 <Tofe> Herrie|Laptop: but if I knew what triggers the faulty banner, I could debug it myself with gdb
Aug 21 20:25:20 <Herrie|Laptop> Tofe: I'm happy to do some legwork looking into it, just don't have a build env available ;)
Aug 21 20:25:39 <Tofe> ok
Aug 21 20:26:02 <Herrie|Laptop> Also some around https://github.com/webOS-ports/luna-webappmanager/blob/master/src/extensions/palmsystemextension.cpp#L250 might be good
Aug 21 20:32:42 <Tofe> Herrie: https://dl.dropboxusercontent.com/u/4679068/luna-next/luna-webappmanager_0.2.0-8%2Bgit0%2B2c5a4cace5-r0.1_armv7a-vfp-neon.ipk
Aug 21 20:33:17 <Herrie|Laptop> Thnx I can debug a bit more now :)
Aug 21 21:03:30 <Herrie> Tofe: OK found the culprit it seems :)
Aug 21 21:03:33 <Herrie> Aug 21 16:51:24 mako LunaWebAppManager[1511]: DEBUG: 16:51:24.404: QString luna::PalmSystemExtension::addBannerMessage(const QJsonArray&) QJsonArray(["[object FileError]","{ }",null,"alerts",null,null,null])
Aug 21 21:03:33 <Herrie> Aug 21 16:51:24 mako LunaWebAppManager[1511]: DEBUG: 16:51:24.407: QString luna::PalmSystemExtension::addBannerMessage(const QJsonArray&) iconUrl =  ""
Aug 21 21:03:33 <Herrie> Aug 21 16:51:24 mako LunaWebAppManager[1511]: DEBUG: 16:51:24.407: QString luna::PalmSystemExtension::addBannerMessage(const QJsonArray&) QFileInfo(iconUrl).isAbsolute() =  false
Aug 21 21:05:19 <Herrie> I think we probably need to add a check for an empty string there ;)
Aug 21 21:05:43 <Herrie> When it's empty it seems it will now prefix it with the app path
Aug 21 21:05:52 <Herrie> While it should actually get the appIcon itself in that case
Aug 21 21:09:04 <Herrie> So we need to define 2 cases I guess... 1 where it's an empty string where it will pull the prefix like it does currently
Aug 21 21:14:05 <Herrie> Tofe: Something like this I guess: https://bpaste.net/show/3995ff1be799
Aug 21 21:14:10 <Herrie> But my C++ is no good ;)
Aug 21 21:16:35 <Herrie> From line 253 to 263 basically
Aug 21 21:16:39 <Herrie> That might need some tweaking
Aug 21 21:17:34 <Herrie> iconUrl = QFileInfo(QUrl(response.value("icon").toString())); might need to be         iconUrl = QFileInfo(QUrl(response.value("icon").toString()).absoluteFilePath()); or something
**** ENDING LOGGING AT Sat Aug 22 02:59:58 2015