**** BEGIN LOGGING AT Sun Sep 20 02:59:58 2015 Sep 20 05:31:15 morning Sep 20 06:06:39 Tofe: Seems I still have N4 display locking up with 5.5 Sep 20 06:13:18 Tofe: At 17:45 this time: https://bpaste.net/show/75fcb0f36578 Sep 20 07:00:57 OK got WebEngine running scoring 510/555 where webkit did 392 ;) Sep 20 07:01:20 Need to enable various thing still though, disabled all experimentals for now Sep 20 08:28:08 Herrie: can you commit all that in a specific branch for the browser ? Sep 20 08:33:59 Tofe it's really rough it launches and that's about it :P Sep 20 08:34:03 Still have error messages etc Sep 20 08:34:40 I did it just in browser, not in LuneOS Components for now Sep 20 08:36:59 thus the separate branch Sep 20 08:37:18 ah, not in Components Sep 20 08:37:20 Yeah Sep 20 08:37:24 mmh then keep it local :) Sep 20 08:37:35 Well I have it working in components too, but still really rough and needs cleaning up :P Sep 20 08:37:45 Still figuring out how to get http://doc.qt.io/qt-5/qml-qtwebengine-webenginesettings.html working :S Sep 20 08:37:59 Seems you need webengine 1.1 for sure, won't work with 1.0 Sep 20 08:38:06 I think it may break all the enyo apps if we just change the qml code of Components, it needs C++ tweaking Sep 20 08:38:54 Well, import 1.1 ? Which version does Qt 5.5 bring us? Sep 20 08:39:36 Tofe: It needs quite some tweaking tbh it seems Sep 20 08:40:00 I'd suggest to create a new QML called LunaWebEngineView.qml and work in there Sep 20 08:40:02 I'm not surprised Sep 20 08:40:05 So we can have them side-by-side Sep 20 08:40:09 Me neither ;) Sep 20 08:40:16 Yes, that looks like a good idea Sep 20 08:40:45 "LunaWebEngine" would be long enough Sep 20 08:41:29 Herrie: did you see this ? http://doc.qt.io/qt-5/qtwebengine-quicknanobrowser-applicationroot-qml.html Sep 20 08:41:57 http://doc.qt.io/qt-5/qtwebengine-quicknanobrowser-example.html Sep 20 08:42:23 Yeah got that one running Sep 20 08:42:38 Needed to install whole MS Visual Studio C++ on my windows machine first :S Sep 20 08:43:26 Oh it's WebEngineView, not WebEngine... Then your name suggestion was best. Sep 20 08:43:38 hehe Sep 20 08:44:29 Let me try to put little one to sleep and I'll push the changes for this Sep 20 08:45:25 okay Sep 20 08:46:38 I'll try to have something running for the apps Sep 20 08:46:47 Could take some time... Sep 20 08:50:30 Seems he doesn't want to sleep yet :P Sep 20 08:50:30 https://github.com/webOS-ports/luneos-components/commit/8b6efb6f9d773a380d0c25864e3eace70cd79e31 Sep 20 08:52:28 Thanks Sep 20 08:56:12 In BrowserWebView.qml I replaced LunaWebView with LunaWebEngineView and commented out all the experimental stuff. That launches it at least it seems. Sep 20 08:56:41 ok good Sep 20 08:56:59 Still needs quite some work though Sep 20 08:57:02 But it launches ;) Sep 20 09:06:03 But only on Desktop it seems, on device it gets stuck at 50% loading page :P Sep 20 09:13:27 oh, great, there is a devicePixelRatio property! Sep 20 09:14:29 Yeah LOL ;) Sep 20 09:19:54 But experimental.* is very poor Sep 20 09:21:51 Well lots of stuff are standard now so we don't need experimental anymore ;) Sep 20 09:22:07 Lots ? I don't see that much Sep 20 09:22:23 For exemple, I don't see how to setup the user agent Sep 20 09:26:32 Ah, I missed userScripts, they are standard now. Good! Sep 20 09:27:28 Tofe seems that we need something like this probably: https://github.com/OtterBrowser/otter-browser/blob/master/src/modules/backends/web/qtwebengine/QtWebEngineWebWidget.cpp#L248 Sep 20 09:28:33 Could be Sep 20 09:29:16 Anyway we will have to hook the url navigation, to be able to open Browser from an app if needed Sep 20 09:32:23 http://code.qt.io/cgit/qt/qtwebengine.git/tree/src/webengine/api/qquickwebengineprofile_p.h?h=v5.5.0 tadaaa Sep 20 09:32:38 profile.httpUserAgent Sep 20 09:39:39 :D Sep 20 09:39:57 Most things are there they have just been moved around quite a bit Sep 20 09:40:56 And slightly renamed in some cases as well Sep 20 09:43:47 Do you know why we are using setZoomFactor instead of setDevicePixelRatio ? Does it render differently ? Sep 20 09:44:53 Where are we using it? Sep 20 09:45:27 when we configure the webview in webappmanager, so that the enyo apps render like on legacy Sep 20 09:45:40 Not sure really Sep 20 09:45:42 (they are designed for a DPI of 132) Sep 20 09:45:50 (if I didn't miss anything) Sep 20 09:45:53 morphis did that Sep 20 09:46:02 Ah, interesting: https://trac.webkit.org/wiki/ScalesAndZooms Sep 20 09:47:33 Might be because of an old bug: https://github.com/isis-project/BrowserServer/blob/e2506f5828457d662853e5aeec9f4f269c9a1952/Src/BrowserPage.cpp#L3045 Sep 20 09:48:26 I'll give devicePixelRatio a try, it seems more adapted to our situation Sep 20 09:49:56 One doubt is if this is a global property for all WebEngineViews... Sep 20 10:00:08 Ah, found it: can be both Sep 20 10:04:42 :) Sep 20 10:11:25 Let me load up latest nightly on TP haven't done that for a while Sep 20 10:15:29 JaMa: For the emu not working the temporary workaround for 5.4.1 might no longer be needed? https://github.com/webOS-ports/meta-webos-ports/commit/03f91a1e0af402415dc952329488a795643f74aa Sep 20 10:43:59 Arggg: https://github.com/webOS-ports/qtwebkit/commits/webOS-ports/master-next Sep 20 10:45:41 ??? Sep 20 10:45:59 There are quite a bunch of commits to port Sep 20 10:47:43 Not all of them, but still Sep 20 10:48:03 Yeah Sep 20 10:48:10 We'll probably need around 20 or so Sep 20 10:48:54 We need the PalmBridge for sure Sep 20 10:50:09 Yeah Sep 20 10:50:41 Some are redundant with luna-webappmanager Sep 20 10:53:05 mmmh quite redundant, actually. I'll have to investigate why. Sep 20 10:57:56 I think it had to do with the app-launcher we used for a while maybe? Sep 20 10:58:05 Well it's good when it gets cleaned up :P Sep 20 10:58:15 Not sure Sep 20 11:00:01 morphis: do you know why what this "WITH_UNMODIFIED_QTWEBKIT" is for ? Do we even need the WebKit patches anymore ? Sep 20 11:00:19 s/why what/what is/ Sep 20 11:31:54 Tofe: might be an idea to focus on the browser first because that seems to need some work as well? Sep 20 11:32:04 And then after morphis' feedback on the apps? Sep 20 11:34:43 maybe Sep 20 11:42:10 Seems browser needs some logics rework for which I know you know better then me how to do it ;) Sep 20 12:02:57 Herrie: did you go further with the browser than what you committed in luneos-components Sep 20 12:02:58 ? Sep 20 13:14:02 Tofe: No just changed BrowserWebView.qml to use LunaWebEngineView and commented out experimentals Sep 20 13:15:27 Not sure how to implement WebEngineSettings and it doesn't load pages on device Sep 20 14:17:46 ok Sep 20 15:00:48 Herrie: mako kernel[682]: [ 73.966030] type=1701 audit(1442761208.375:20): auid=4294967295 uid=0 gid=0 ses=4294967295 pid=1908 comm="QtWebEngineProc" reason="memory violation" sig=1 Sep 20 15:00:56 :( Sep 20 15:01:43 Just when it gets visible, it crashes Sep 20 15:10:44 Herrie: when we have an improvement for the browser regarding webengine, I propose we PR against master-webengine Sep 20 17:22:29 Tofe: Thnx will give it a go Sep 20 17:56:03 Tofe: Added 2 minor fixes :P Sep 20 18:00:43 Tofe: Seems we need to tweak the useragent a bit Sep 20 18:00:57 We get 499 on html5test when we enable custom, when we don't we have 510 Sep 20 18:19:51 I'll propose a few things Sep 20 20:07:19 ok yes Sep 20 20:08:18 I'm working on a few things will push either tonight or tomororw Sep 20 20:08:26 Fullscreen, useragent, permission requests Sep 20 20:09:57 We'll need to know why it crashes on N4... Maybe test it on tenderloin to see if it crashes there too Sep 20 20:14:43 Tofe: Will test it in a bit Sep 20 20:25:56 I'll have much less in the following days (some crazy days at work), but from thursday it should be more calm Sep 20 20:28:32 Tofe, what are your thoughts on ZoomController? Do we need it? (it's in the quicktestbrowser) Sep 20 20:35:18 I don't think it's very useful Sep 20 20:36:53 OK **** ENDING LOGGING AT Mon Sep 21 02:59:59 2015