**** BEGIN LOGGING AT Mon Jun 27 02:59:58 2016 Jun 27 05:59:41 Morning! Jun 27 06:30:09 Tofe: morning Jun 27 06:36:48 morphis: ping Jun 27 07:21:09 morning Jun 27 07:40:29 morning Jun 27 07:40:48 * Tofe confirms that it is the morning Jun 27 07:49:00 Tofe: Yeah Jun 27 11:25:23 JaMa: morning Jun 27 11:40:34 morning Jun 27 11:44:06 JaMa: I updated my PR i.e. squashed commits Jun 27 11:44:21 For FreeImage I tried your suggestions but to no avail it seems. Jun 27 11:45:44 I did do some cleanup and bumped to latest release. Did run into some issues with patching because the source files for libwebp have Windows line endings. Got that sorted eventually though. Is there any easy way in Yocto to force it to ignore different li Jun 27 11:45:45 ne endings? Jun 27 11:47:01 I don't think there is Jun 27 11:48:35 JaMa: OK, already couldn't find anything :P Jun 27 11:49:11 Thought you might know a shortcut but I guess not then. It's not very common anyway just in this particular case it was an issue :P Jun 27 11:49:17 Herrie|Pre3|2: looks better, you might want to add 4-space indentation to EXTRA_OECONF and RRECOMMENDS variables Jun 27 11:49:53 Herrie|Pre3|2: you should just create the .patch with correct endings and then be careful with git apply to not convert them Jun 27 11:51:15 Seems libwebp didn't want to work with GCC 5.1 so needed to patch. Found almost fit for purpose one at Google, needed to adjust a little. Tried both line endings but didn't work. It picks it from SourceForge so there shouldn't be git apply? Jun 27 11:51:58 I mean git apply when working with meta-webos-ports patch Jun 27 11:52:16 JaMa: Ah ok Jun 27 11:52:21 for git am you can use --keep-cr Jun 27 11:53:47 Let me fix the 4 spaces Jun 27 12:00:48 OK updated Jun 27 15:24:42 Tofe: ping Jun 27 16:02:01 morning Jun 27 16:02:30 nizovn: morning Jun 27 16:36:11 Herrie: pong Jun 27 16:40:05 Tofe: I PR-ed it already Jun 27 16:40:41 Will test it on device in a bit Jun 27 16:40:41 Just arriving home Jun 27 16:40:50 ok, let's discuss the main detail on the PR :) Jun 27 16:44:49 Tofe: OK :) Jun 27 16:53:42 Tofe: OK I need to test the proposed change. Problem with current code is that it doesn't give a length, so it never plays. Jun 27 16:54:03 I found this generic check online somewhere. I'll test your alternative. Jun 27 16:54:44 The power of the ! operator :) Jun 27 16:56:06 Tofe: lol Jun 27 16:57:09 I kind of like it; it avoid comparing with null, which is always a bit risky if the variable is undefined for example Jun 27 17:51:14 Tofe: TypeError: Property 'trim' of object file:///usr/palm/sounds/alert.wav is not a function Jun 27 17:51:33 It doesn't see it as a string somehow I guess, that's why length also doesn't work Jun 27 17:52:24 JaMa: You happy with the PR now? Jun 27 17:55:29 Herrie: oh, too bad Jun 27 18:04:40 Herrie: i re-added the butterfly...can you verify that the PR looks correct with that file? Jun 27 18:04:43 https://github.com/webOS-ports/luneos-default-wallpapers/pull/1 Jun 27 18:05:15 Tofe: So you're OK with the original PR? Jun 27 18:05:20 If I add the comment? Jun 27 18:05:30 or Tofe (see above) Jun 27 18:06:11 Herrie: I'd still like to simply the first 3 tests Jun 27 18:06:20 it looks overly complicated Jun 27 18:07:37 HaDAk: I'm good with your two PRs Jun 27 18:08:21 who has to merge them? Jun 27 18:08:44 I can do that Jun 27 18:08:52 HaDAk: You tested it in a build? Jun 27 18:08:54 Or... ? Jun 27 18:08:58 Herrie: negative Jun 27 18:09:04 i do not know how to build Jun 27 18:09:13 teach me, and i will learn Jun 27 18:09:49 HaDAk: OK ;) Well let me test that then Jun 27 18:09:55 fair enough Jun 27 18:10:08 also, teach me Jun 27 18:10:10 Basically you follow: http://webos-ports.org/wiki/Build_for_qemux86 Jun 27 18:10:19 First time takes forever Jun 27 18:10:19 * HaDAk looks Jun 27 18:10:53 Then you can adjust files locally and just build a single component with MACHINE=qemux86 bb -f luna-init for example Jun 27 18:11:00 Which will generate an IPK that you can install Jun 27 18:11:17 i can do this on windows though Jun 27 18:11:18 right? Jun 27 18:11:27 nah Jun 27 18:11:32 looks like the instructions are for *nix Jun 27 18:11:44 are there supposed to be images on this page? Jun 27 18:12:37 oh, i should have read. you just build in a VM on windows. that makes sense. Jun 27 18:12:41 i swear, i'm not an idiot. Jun 27 18:13:07 HaDAk: This is building in a VM or native box Jun 27 18:13:14 yeah Jun 27 18:13:15 i'm good. Jun 27 18:13:15 I did it a lot in VirtualBox before Jun 27 18:13:16 ignore me Jun 27 18:13:31 i have a vm that i've already built this in before Jun 27 18:13:35 Now I have native Ubuntu 16.04 just because it's quicker Jun 27 18:13:38 i'm just going to fire that up Jun 27 18:14:06 it specifically needs bash? Jun 27 18:14:12 are there conflicts if i run zsh? Jun 27 18:16:17 are you trying to test in a vm? Jun 27 18:16:21 or just build in one? Jun 27 18:17:13 build Jun 27 18:17:20 i'm going to build the qemu imae Jun 27 18:17:21 image* Jun 27 18:17:25 then just use docker Jun 27 18:17:44 morphis made a docker image for Luneos, IIRC Jun 27 18:17:51 *dockerfile Jun 27 18:18:13 i've stumbled through the docker thing once. once. Jun 27 18:18:23 HaDAk: you should use bash for sure Jun 27 18:18:37 but no need to change the shell of your user account, just start bash Jun 27 18:18:40 and then build in there Jun 27 18:18:44 GodGinrai: nice Jun 27 18:18:47 gotcha Jun 27 18:20:05 morphis: still got that pastebin for the Dockerfile? (or did you ever add it to the repo?) Jun 27 18:21:08 GodGinrai: you can take https://github.com/phablet/docker_platform-devel instead Jun 27 18:48:50 ok, the build is running now. i think. Jun 27 18:53:36 HaDak: if you want a quick test you can build only packages you changed, not the whole image Jun 27 18:53:53 and install them in emulator Jun 27 18:54:35 it's good to practice Jun 27 19:43:08 Tofe: With typeof str == 'undefined' || !str || str.length === 0 it seems to work as well Jun 27 20:40:35 Tofe: I'll probably update the PR tomorrow to deal with https://github.com/openwebos/luna-sysmgr/blob/1393f0af5dd8d9f0e9cc79627f4acb226f8c8d45/Src/lunaui/notifications/BannerMessageHandler.cpp#l696 and https://github.com/openwebos/luna-sysmgr/blob/1393f0af5dd8d9f0e9cc79627f4acb226f8c8d45/Src/base/settings/Preferences.cpp#L520 so we're legacy compatible. Currently when you provide a class Jun 27 20:40:35 it doesn't play any sound while it should ;) Jun 27 20:45:24 Herrie: ok :) Jun 27 22:13:39 Herrie, in JavaScript, that expression is equivalent to !str **** ENDING LOGGING AT Tue Jun 28 02:59:58 2016