**** BEGIN LOGGING AT Sun Jul 17 02:59:58 2016
Jul 17 09:18:36 <Herrie|Laptop> Tofe: morning
Jul 17 09:18:51 <Herrie|Laptop> And ping
Jul 17 09:35:48 <Tofe> Morning
Jul 17 09:35:50 <Tofe> and pong
Jul 17 09:35:52 <Tofe> and merged
Jul 17 09:38:47 <Herrie|Laptop> Tofe: The code might not be very pretty but it's pretty much 1:1 converted from legacy c++ code
Jul 17 09:38:55 <Herrie|Laptop> Decided not to play with it too much
Jul 17 09:39:02 <Herrie|Laptop> To avoid regressions
Jul 17 09:43:05 <Herrie|Laptop> Tofe: Can you see if you're happy with https://github.com/webOS-ports/org.webosports.app.testr/pulls
Jul 17 09:43:12 <Herrie|Laptop> Shouldn't be rocket science :P
Jul 17 10:27:48 <nizovn> Tofe: i have 3 small bugs in LNC if you want/have time
Jul 17 10:27:58 <nizovn> and 1 not very small
Jul 17 10:37:30 <Herrie|Laptop> nizovn: Shoot I'll say, so at least we have them documented ;)
Jul 17 10:37:59 <nizovn> ok
Jul 17 10:39:17 <nizovn> 1. when card is minimized, tap on gesture area maximizes it and then immediately minimizes
Jul 17 10:40:21 <nizovn> (works ok with swipe up, but not tap)
Jul 17 10:41:01 <Herrie|Laptop> nizovn: This is on phone or TP?
Jul 17 10:41:29 <nizovn> i think everywhere
Jul 17 10:43:35 <nizovn> 2. swipe up gesture should close "exhibition mode"(when usb is connected), like on tap now. (this is annoying when gesturearea is disabled)
Jul 17 10:47:47 <nizovn> 3. swipeable card should react only on gestures that starts with touch coordinate higher than launchbar (this prevents card from close on gesture up when gesturearea is disabled)
Jul 17 10:50:55 <Tofe> Herrie|Laptop: these last days I was installing/configuring the new little pc I have bought, for my luneos work during vacations; but next week I'm on vacation, and the pc is now ready :)
Jul 17 10:51:09 <Herrie|Laptop> Tofe: Good :D
Jul 17 10:52:14 <Tofe> Herrie|Laptop: Testr PR looks good. I merge it now?
Jul 17 10:52:22 <Herrie|Laptop> Yeah
Jul 17 10:52:32 <Tofe> done
Jul 17 10:52:35 <Herrie|Laptop> And I'll kick off a new build so DougReeder can test if he's happy
Jul 17 10:53:10 <Tofe> nizovn: for 1., it's probably a double event somewhere
Jul 17 10:53:13 <Tofe> 2. agreed
Jul 17 10:54:45 <Tofe> 3. mmh we'll see what can be done here, as it should already be the case (the ListView that catches the swipe does under the launcher bar)
Jul 17 10:55:29 <Tofe> nizovn: I forgot, do we have a setting to disable gesture area?
Jul 17 10:55:52 <nizovn> yup
Jul 17 10:56:00 <nizovn> in tweaks
Jul 17 10:56:07 <Tofe> I completely forgot that :)
Jul 17 10:56:18 <Tofe> Thus, mostly untested by me
Jul 17 10:56:29 <Herrie|Laptop> Tofe: Yeah I added it a while ago on user request. On TP it's a bit silly to have gesture area in some cases ;)
Jul 17 10:56:38 <Herrie|Laptop> Since we have a hardware button too
Jul 17 10:56:52 <Herrie|Laptop> Takes screen real estate
Jul 17 10:57:12 <Tofe> Yes I remember now, and it makes sense
Jul 17 10:57:45 <Herrie|Laptop> But I guess there are some minor bugs here and there :P
Jul 17 10:58:11 <Tofe> yup
Jul 17 10:59:37 <nizovn> (not small bug): there is strange difference with screen side gestures: if you try in browser, gestures from right side(outside screen) works ok, from left side doesn't work
Jul 17 10:59:44 <nizovn> and they even cause bad things: if you focused on the right card (of two opened), and make left side gesture, the left card goes into drag state just over the right card
Jul 17 11:43:47 <Tofe> eww, we're not supposed to be able to swipe left/right when a card is maximized
Jul 17 11:57:56 <Herrie|Pre3|2> Tofe: Well LunaCE actually had side swipe when maximized enabled via Tweaks developed by EricBlade if I recall correctly
Jul 17 12:11:16 <Herrie|Pre3|2> Tofe: I think this commit documents it? https://github.com/woce/LunaSysMgr/commit/f5f2d63f21d06f839e531155c1b0d4bf16ccab11
Jul 17 12:11:36 <Herrie|Pre3|2> There are many commits there so hard to pick one that's the correct one :s
Jul 17 12:57:45 <Tofe> oh ok... however, not sure if that is currently intended in LNC
Jul 17 13:02:08 <Tofe> https://github.com/webOS-ports/luna-next-cardshell/blob/master/qml/CardView/CardView.qml#L157 <-- this should prevent any edge left/right swipe when maximized...
Jul 17 13:09:12 <Herrie|Pre3|2> Tofe: nizovn wrote something that can be generic but only should work for up/down currently.
Jul 17 13:10:10 <Tofe> Herrie|Pre3|2: what are you referring to?
Jul 17 13:14:45 <Herrie|Pre3|2> Tofe: nizovn wrote a generic gesture handler a while ago but only implemented up + down
Jul 17 13:14:49 <Herrie|Pre3|2> Left and right should be added
Jul 17 13:14:54 <Herrie|Pre3|2> At some pointt
Jul 17 13:15:15 <Tofe> ah yes I remember
Jul 17 13:15:36 <Tofe> for swiping system & app menu
Jul 17 13:19:50 <Herrie|Pre3|2> Tofe: Yeah, just a possible fix for the issue shouldn't interfere with future left/right stuff ;)
Jul 17 15:30:35 <Herrie|Pre3> DougReederPhone: The banner sound issue should be sorted in new nightly dated today. I made it compatible with legacy API so you can put relative or absolute filepath, soundclass etc
Jul 17 15:31:00 <Herrie|Pre3> I basically converted the C++ logics to JS :P
Jul 17 15:31:10 <Herrie|Pre3> Only missing bit is vibratenamedeffect
Jul 17 15:31:50 <Herrie|Pre3> Because we don't have that vibrate bit implemented yet. I guess I could put a normal vibrate for now instead.
Jul 17 15:32:10 <Herrie|Pre3> I added some test cases for the banner sounds to Testr
Jul 17 15:33:00 <Herrie|Pre3> It would also work when the file is in appfolder/resources/lang_country locale folder
Jul 17 15:33:24 <Herrie|Pre3> Will look into the small/miniicon issue for banners next. Like email app icon for dashboards
Jul 17 15:34:24 <Herrie|Pre3> Which currently shows a wrong icon ;)
**** ENDING LOGGING AT Mon Jul 18 02:59:58 2016