**** BEGIN LOGGING AT Fri Jul 22 02:59:58 2016
Jul 22 07:38:45 <Tofe> Morning!
Jul 22 07:38:49 <Tofe> Herrie: pong
Jul 22 07:41:27 <Tofe> I just saw http://blog.qt.io/blog/2016/07/18/qt-webbrowser-1-0/ , maybe we should have a look for some of our technical and/or ergonomic issues (find in page, etc)
Jul 22 07:42:19 <Tofe> Also maybe we could ship a webos app corresponding to that browser, as a reference comparison
Jul 22 07:47:12 <Tofe> ah, mmh, looks like it wouldn't be usable as-is, it does some hard referencing to their QtVirtualKeyboard solution
Jul 22 08:02:22 <Herrie|Laptop> Tofe: morning
Jul 22 08:02:30 <Herrie|Laptop> I'm still fighting with icons :P
Jul 22 08:25:55 <Herrie|Laptop> Tofe: Yeah hard references to their keyboard is not very helpful
Jul 22 08:42:21 <Herrie|Laptop> Tofe: ping
Jul 22 08:46:57 <Herrie|Laptop> Tofe: I seem to have an issue with some dashboards. For example: When you add an alarm in the Clock app, minimize to card, the dashboard that gets created has an issue
Jul 22 08:47:18 <Herrie|Laptop> It seems that the params aren't passed through to luna-next/luna-webappmgr properly
Jul 22 08:48:52 <Herrie|Laptop> The correct icon should be images/notification-alarm.small.png however this doesn't end up in the window properties somehow:
Jul 22 08:49:04 <Herrie|Laptop> Jul 22 04:45:23 qemux86 luna-next[3130]: DEBUG: 04:45:23.857: Herrie window.windowProperties: {"LuneOS_webosdragmode":"manual","LuneOS_window":"dashboard","_LUNE_APP_ICON":{},"_LUNE_APP_ID":"com.palm.app.clock","_LUNE_WINDOW_LOADING_ANIMATION_DISABLED":false,"_LUNE_WINDOW_PARENT_ID":0,"_LUNE_WINDOW_TYPE":"dashboard"}
Jul 22 08:49:39 <Herrie|Laptop> Jul 22 04:45:23 qemux86 LunaWebAppManager[3142]: DEBUG: 04:45:23.671: void luna::WebApplication::createWindow(QQuickWebEngineNewViewRequest*) Creating new window for url QUrl("file:///usr/palm/frameworks/enyo/0.10/framework/build/palm/system/dashboard-window/dashboard.html?enyoWindowParams=%7B%22layers%22%3A%5B%7B%22icon%22%3A%22images%2Fnotification-alarm-small.png%22%2C%22title%22%3A%22Alarm%22%2C%22text%22%3A%228%3A00 AM
Jul 22 08:49:41 <Herrie|Laptop> Ah it should be params I guess
Jul 22 08:53:35 <Tofe> yes, that would be params; but it could be something got forgotten along the way
Jul 22 08:53:36 <Herrie|Laptop> Tofe: Any input is welcome :P
Jul 22 08:53:37 <Herrie|Laptop> Hmmz nope that's not it I guess
Jul 22 08:53:48 <Herrie|Laptop> Tofe: Yeah it seems that way
Jul 22 08:53:57 <Herrie|Laptop> Could be the specific way this dashboard is build
Jul 22 08:54:18 <Herrie|Laptop> It seems that this uses the "standard" Dashboard in Enyo 1 while other apps like Accounts provide their own HTML file for dashboard
Jul 22 08:54:23 <Herrie|Laptop> Which works OK
Jul 22 08:54:47 <Herrie|Laptop> (Except for me struggling to get the right code at the right place for it to display properly :P)
Jul 22 08:55:04 <Tofe> you're dumping all the window properties, right ? Those ones we can access like that: ResetSkipPkgs
Jul 22 08:55:07 <Tofe> oops
Jul 22 08:55:11 <Tofe> https://github.com/webOS-ports/luna-next-cardshell/blob/master/qml/Notifications/NotificationArea.qml#L94
Jul 22 08:56:04 <Herrie|Laptop> Tofe: I simply added: console.log("Herrie window.windowProperties: "+JSON.stringify(window.windowProperties));
Jul 22 08:56:11 <Herrie|Laptop> That should dump all for this case
Jul 22 08:57:40 <Herrie|Laptop> For email app's dashboard I get an additional line where it has a Jul 22 04:35:47 qemux86 luna-next[2524]: DEBUG: 04:35:47.287: void luna::CompositorWindow::onWindowPropertyChanged(const QString&, const QVariant&) "LuneOS_icon" QVariant(QString, "images/notification-small.png")
Jul 22 08:58:45 <Herrie|Laptop> The output of my windowProperties there has an additional field: ,"_LUNE_APP_ICON":{},"_LUNE_APP_ID":"com.palm.app.email","_LUNE_WINDOW_LOADING_ANIMATION_DISABLED":false,"_LUNE_WINDOW_PARENT_ID":0,"_LUNE_WINDOW_TYPE":"dashboard"}
Jul 22 08:58:54 <Herrie|Laptop> Jul 22 04:57:37 qemux86 luna-next[3578]: DEBUG: 04:57:37.884: Herrie window.windowProperties: {"LuneOS_icon":"images/notification-small.png","LuneOS_webosdragmode":"manual","LuneOS_window":"dashboard","_LUNE_APP_ICON":{},"_LUNE_APP_ID":"com.palm.app.email","_LUNE_WINDOW_LOADING_ANIMATION_DISABLED":false,"_LUNE_WINDOW_PARENT_ID":0,"_LUNE_WINDOW_TYPE":"dashboard"}
Jul 22 08:59:01 <Herrie|Laptop> Called LuneOS_icon
Jul 22 08:59:31 <Tofe> let me see, I thing the ones with "LuneOS_*" are added dynamically
Jul 22 08:59:55 <Tofe> yes: https://github.com/webOS-ports/luna-webappmanager/blob/master/src/webapplicationwindow.cpp#L226
Jul 22 09:01:01 <Tofe> so if we get an "icon" property", we should probably override the _LUNE_APP_ICON value
Jul 22 09:01:14 <Herrie|Laptop> Tofe: It could be because these are passed in as querystring they currently don't get picked up
Jul 22 09:01:34 <Tofe> well, noone parses this LuneOS_icon, actually
Jul 22 09:01:46 <Herrie|Laptop> Tofe: Well I do now :P
Jul 22 09:02:03 <Herrie|Laptop> I'll use it in LNC going forward
Jul 22 09:02:23 <Herrie|Laptop> To fix the miniicon/smallicon for dashboards ;)
Jul 22 09:03:35 <Tofe> ok :) but shouldn't we directly use it here: https://github.com/webOS-ports/luna-webappmanager/blob/master/src/webapplicationwindow.cpp#L233
Jul 22 09:03:57 <Tofe> it would avoid introducig one more meta-property
Jul 22 09:04:45 <Herrie|Laptop> Tofe: Ehm no....
Jul 22 09:04:51 <Herrie|Laptop> There are different kinds of icons...
Jul 22 09:04:59 <Herrie|Laptop> For example email dashboard has 2...
Jul 22 09:05:06 <Herrie|Laptop> 1 for minimized and 1 for full dashboard
Jul 22 09:05:27 <Herrie|Laptop> So we need both
Jul 22 09:05:27 <Tofe> ah, yes. I've not been in that code for a long time :p
Jul 22 09:05:35 <Herrie|Laptop> I'll take care of that in LNC
Jul 22 09:05:54 <Herrie|Laptop> Basically it'll check if a custom miniicon/smallicon is passed in. If so uses that, if not uses the default app icon
Jul 22 09:05:57 <Herrie|Laptop> With some logics
Jul 22 09:06:11 <Herrie|Laptop> I.e. pull it from appinfo.json, check it's existance etc
Jul 22 09:06:16 <Herrie|Laptop> That's what I'm working on now
Jul 22 09:07:32 <Tofe> ok. I hope it does do too much duplcate processing ? for appinfo, I mean
Jul 22 09:07:39 <Tofe> doesn't :)
Jul 22 09:07:55 <Herrie|Laptop> Tofe: Well as little as possible
Jul 22 09:07:59 <Herrie|Laptop> But where needed it'll do
Jul 22 09:08:05 <Tofe> ok
Jul 22 09:09:40 <Herrie|Laptop> I do have some duplication in the code now that I still want to clean up
Jul 22 09:18:24 <nizovn> seems webos-ports.org is down
Jul 22 09:23:38 <Herrie|Laptop> Tofe: https://github.com/webOS-ports/enyo-1.0/blob/webOS-ports/master/framework/source/palm/system/windows/manager.js#l154 and https://github.com/webOS-ports/enyo-1.0/blob/webOS-ports/master/framework/source/palm/system/windows/manager.js#l172
Jul 22 09:23:50 <Herrie|Laptop> It seems we'd need to add that logic at l172
Jul 22 09:27:19 <Tofe> ah, they change window params on the fly...
Jul 22 09:30:18 <Herrie|Laptop> Tofe: It seems so :S
Jul 22 09:30:37 <Herrie|Laptop> Which might not only be applicable for the dashboards but also for other things ;)
Jul 22 10:11:11 <Herrie|Laptop> nizovn: Same here, I guess we'd need to ping ka6sox or scoutcamper about that
Jul 22 10:11:31 <nizovn> seems same with internals
Jul 22 14:03:52 <KyleMaas> Looks like the wiki's down.
Jul 22 14:51:16 <Herrie|Pre3> ka6sox: ping
Jul 22 14:51:31 <Herrie|Pre3> scoutcamper|away: ping
**** ENDING LOGGING AT Sat Jul 23 02:59:58 2016