**** BEGIN LOGGING AT Mon Sep 02 02:59:56 2019 Sep 02 07:06:37 Herrie: pong Sep 02 08:22:40 Morning Sep 02 08:22:44 bshah: I'm around now ;) Sep 02 08:25:39 and I'm back too :) Sep 02 08:54:59 Tofe: Welcome back :) Any thoughts on https://github.com/Halium/libhybris/pull/3/files ? Sep 02 08:55:14 This is to try to solve the blocker for merging the other commits in upstream Halium Sep 02 09:01:32 Herrie: I would put away the ANDROID_VERSION_MAJOR==5 test Sep 02 09:02:09 if that test must be there, let's try to put it into configure Sep 02 09:04:00 but as we already have a good granularity with --enable-ubuntu-camera-headers I think people can find a solution when needed Sep 02 09:04:11 apart from that, it looks fine Sep 02 09:06:13 Tofe: We need the ANDROID_VERSION_MAJOR==5 since it will only work with the Ubuntu specific frameworks_av Sep 02 09:12:44 but wouldn't it be just fine to not pass --enable-ubuntu-camera-headers when we don't have that specific framework_av ? Sep 02 09:17:36 Tofe: The include of some of the headers are conditional based on the specific frameworks_av Sep 02 09:17:49 And only for Android 5 and Ubuntu's version Sep 02 09:18:03 If using regular frameworks_av for whatever reason, this header is not there Sep 02 09:18:14 Also with newer Android not due to libcompat etc Sep 02 09:22:11 ok then Sep 02 09:33:57 Hence I put it like this. There are more ways to do it of course Sep 02 09:34:11 Happy for another suggestions if you feel like there's a better one Sep 02 10:55:08 not really Sep 02 11:04:33 Tofe: OK :) THen it's for bshah to merge or have comments Sep 02 11:04:44 And then the upstream ones can have comments or merge the whole PR ;) Sep 02 11:05:15 Just to solve the discussion in https://github.com/libhybris/libhybris/pull/419 Sep 02 11:05:42 Also sent this one from Mer: https://github.com/libhybris/libhybris/pull/423 Sep 02 13:43:04 ah, good :)