**** BEGIN LOGGING AT Tue Jul 07 02:59:58 2020 **** BEGIN LOGGING AT Tue Jul 07 04:30:36 2020 **** BEGIN LOGGING AT Tue Jul 07 05:23:26 2020 **** BEGIN LOGGING AT Tue Jul 07 05:57:21 2020 Jul 07 06:33:09 Morning Jul 07 06:33:15 Herrie: ok, I'll merge the lxc one Jul 07 06:33:30 ah, no, there's a dependency Jul 07 07:34:14 Tofe: morning! Jul 07 07:34:28 Seems JaMa merged meta-smartphone ones Jul 07 07:39:30 yes and meta-webos-ports as well Jul 07 07:41:22 thanks Jul 07 07:51:57 JaMa: Thnx... Will probably need to push something else for Tenderloin at some point... Jul 07 08:34:45 Herrie: I'm not familiar with codacy and just got request to confirm installation from you, I guess I'm OK with that :) Jul 07 08:35:22 JaMa: I'm trying various static analysis tools to see if we can improve some of the code quality to our own components Jul 07 08:36:04 and this one looks good or why not test it on something smaller first? Jul 07 08:42:39 JaMa: Ignore them for now, will test on my own GitHub first ;) Jul 07 08:49:20 ok, thanks Jul 07 09:58:34 Tofe: This codacy seems pretty useful for spotting code problems :) Jul 07 10:01:57 https://abload.de/img/codacy5hkl4.png Jul 07 10:02:25 These are just the errors... There's 270+ in total for libhybris when taking into account, info, warnings etc **** BEGIN LOGGING AT Tue Jul 07 10:15:41 2020 Jul 07 11:16:21 Herrie: nice ! Though libhybris is a lot of hacks here and there. But most of the errors might be legit. **** BEGIN LOGGING AT Tue Jul 07 11:21:56 2020 Jul 07 11:29:35 Tofe: yeah... I'll propose some fixes but you know my c(++) so I won't be much good probably but will get the low hanging fruits at least Jul 07 11:31:25 Herrie: how did you run it ? You installed it locally on your machine ? Jul 07 11:31:40 Tofe, no this is on GitHub ;) Jul 07 11:31:44 Just give it access to repo Jul 07 11:32:04 CppCheck which you install locally gives similar results though Jul 07 11:32:27 codacy.com and you give it access to your GH account and you can then add repos to check Jul 07 11:32:38 luna-qml-launcher doesn't have many issues :P Jul 07 11:33:16 Only 1: Member variable 'ApplicationDescription::mUseLuneOSStyle' is not initialized in the constructor.In src/applicationdescription.cpp L32 Jul 07 11:45:09 Herrie: and not mUseWebEngine ?... Jul 07 11:45:40 No... Jul 07 11:45:55 Which also surprised me, because to me they look identical in terms of code :S Jul 07 11:46:28 yes, it's a bit surprising, that's an easy check. Anyway, that constructor is never used I think, but we can fix this nevertheless Jul 07 11:47:32 Even if the checks aren't perfect, it's always good to have some status Jul 07 11:57:22 Tofe: Yeah Jul 07 11:57:42 I'll do some obvious ones in libhybris, should be done shortly... It's mainly printing which is causing issues it seems Jul 07 11:57:53 Stuff like: %zd in format string (no. 2) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'. Jul 07 12:33:04 Tofe: This seems to cover 50 or so warnings now ;) https://github.com/Herrie82/libhybris/commit/50e5bb85bb1dc65b968b242b962882e18d568788 Jul 07 12:33:09 You have any remarks on this? Jul 07 12:36:15 Herrie: no, it looks ok Jul 07 12:36:36 I wouldn't spend too much time on that kind of warning though, it can't lead to any serious problem Jul 07 12:43:54 Tofe: Well they're easy to fix and will leave the more important ones out there (which are probably over my head LOL) Jul 07 12:46:48 :) Jul 07 13:02:54 Well it's 66 crushed, still another 318 to go in the code it seems.. Though most are Info type (245). 10 errors and 63 warning... **** BEGIN LOGGING AT Tue Jul 07 13:53:31 2020 Jul 07 15:41:02 OK sent some more fixes upstream Jul 07 16:11:19 I've rebooted bonaire, it had read-only rootfs again and builds were failing, lets see how long it lasts now **** BEGIN LOGGING AT Tue Jul 07 17:49:54 2020