**** BEGIN LOGGING AT Sat Nov 14 02:59:56 2020
Nov 14 06:24:48 <Herrie> Morning!
Nov 14 06:24:59 <Herrie> Tofe: I'll hold off on the merge for now?
Nov 14 08:59:30 <Tofe> Herrie: yes, please hold, I'd like to keep the powermenu working
Nov 14 11:20:42 <Tofe> Herrie: actually it isn't that broken, maybe I crashed the appmanager or so without noticing
Nov 14 11:20:58 <Tofe> but I'd like to know why the dockmode isn't activated in lunanext
Nov 14 12:40:45 <Tofe> ok, it's deactivated because LunaSysService crashes when parsing a tz file (Europe/Paris, here)
Nov 14 13:17:30 <Tofe> with https://github.com/webOS-ports/luna-sysservice/pull/13 it's now behaving correctly. And as LunaSysMgr is also restarted when LunaSysService is restarted, it explains why we lost the subscription on luna://com.palm.display/control/lockStatus, which caused luna-next to not switch to dockMode.
Nov 14 13:17:40 <Tofe> now it's fixed with the 3 PRs !
Nov 14 13:17:58 <Herrie> Tofe: Ah great
Nov 14 13:17:59 <Tofe> I also PR'ed the last one to webosose
Nov 14 13:18:29 <Herrie> Not sure why TzParser should cause this though
Nov 14 13:18:58 <Herrie> It could be OSE uses different luna-init bits so they don't have this issue
Nov 14 13:19:06 <Tofe> TzParser crashed => LunaSysService restarted => LunaSysMgr restarted => subscription to com.palm.display lost by luna-next
Nov 14 13:19:30 <Herrie> Our luna-init comes from OWO still and not OSE I think
Nov 14 13:19:34 <Tofe> or, TZ has been updated a bit in gatesgarth, revealing the bug for that TZ
Nov 14 13:20:27 <Herrie> Tofe: Well I suspect it's luna-init somehow
Nov 14 13:21:14 <Herrie> I did work in the past to get it updated properly but could be that broke when I migirated to OSE's luna-sysservice but didn't take their tz init bits
Nov 14 13:21:34 <Tofe> on our side, also, we don't have a strong requirement of luna-next on luna-sys-service; there are two ways to fix that: 1) make luna-next restart when luna-sys-service restarts, or 2) have a service subscription in luna-next when the service disappears and reappears
Nov 14 13:22:27 <Tofe> (well, it's more on luna-sysmgr, but it's the same principle)
Nov 14 13:24:12 <Tofe> During my investigation I saw that our LS2 QML object doesn't propose the "LSRegisterServerStatus" API, which could be used to survey if a service (dis)appears and then redo the subscriptions
Nov 14 13:25:17 <Tofe> but maybe we could make it automatic, each time we use "subscribe: true" in QML
Nov 14 13:26:08 <Tofe> anyway, I now have a working dock mode on pinephone, yepee.
Nov 14 13:27:16 <Herrie> Tofe: This is the difference in the Python scripts between OSE and the ones we use for generating the timezones: https://github.com/webOS-ports/luna-init/commit/9a319b81629cb803e95075169015166c90d53d23
Nov 14 13:28:14 <Herrie> This basically generates the timezone stuff queried by LunaSysService
Nov 14 13:31:02 <Tofe> well, the tz file is correct; but I'm not sure why it doesn't crash for them. Maybe pure luck, as it's a out-of-bound memory access
Nov 14 19:37:40 <Herrie> Tofe: All is merged & SRCREV bumped
Nov 14 20:58:52 <Tofe> great, thanks !
**** ENDING LOGGING AT Sun Nov 15 02:59:56 2020