**** BEGIN LOGGING AT Fri Jan 15 02:59:57 2021 Jan 15 07:14:57 Morning ! Jan 15 07:16:49 Herrie: less spamming, but still quite a bunch of error still Jan 15 07:17:15 Morning! Jan 15 07:17:17 qseecom , for isntance: is it really useful for us ? I don't know precisely what it's for, but it's there on all qcom devices Jan 15 07:17:19 Tofe: yeah Jan 15 07:17:53 I'm also not 100% sure about that one Jan 15 07:18:26 some camera missing .so ; it looks like they're reinventing the wheel for each camera on each device Jan 15 07:23:20 Herrie: I'm less and less convinced about this file-by-file copying of vendor. Moreover, it's already an extract of the vendor partition, so generally all that is in there can be useful... Jan 15 07:27:50 we just have to copy to TARGET_COPY_OUT_VENDOR, TARGET_COPY_OUT_PRODUCT and (to be checked) to TARGET_COPY_OUT_SYSTEM Jan 15 07:28:02 and provide a way to exclude things, that could be nice too Jan 15 07:31:04 There's even a macro for it: example: PRODUCT_COPY_FILES += $(call find-copy-subdir-files,*,vendor/xiaomi/rosy/proprietary/vendor,$(TARGET_COPY_OUT_VENDOR)) Jan 15 07:33:55 Tofe: I didn't design the Android build system :P Jan 15 07:34:19 Or we could regenerate proprietary-files.txt based on vendor Jan 15 07:34:41 This was we can reuse the existing Halium setup script Jan 15 07:36:47 Herrie: yes, why not; isn't proprietary-files.txt already generated from the device content ? Jan 15 07:37:08 ah no, it's used to extract from the device Jan 15 07:38:17 Yeah it goes both ways a bit Jan 15 07:39:03 Should be easy enough to grep/awk in ls from vendor and generate a proprietary-files.txt Jan 15 07:39:07 regenerating proprietary-files.txt looks good and easy Jan 15 07:39:47 I'll sketch some little script, we could even propose that in halium/device/setup Jan 15 07:46:43 It would follow the Android way and doesn't tinker with anything unsuspectedly Jan 15 07:46:56 And will help new ports greatly too Jan 15 07:47:08 Because most issues during Android build are due to mismatches Jan 15 17:22:25 Herrie: https://github.com/Tofee/halium-devices/commit/01ffcfd8f3caddcc6d606bc489ca7b1c4987bb04 what do you think ? Jan 15 17:22:44 PS: for tissot there doesn't seem to be anything missing except a .jar Jan 15 17:44:31 We shouldn't care about jar Jan 15 17:56:38 Tofe: For PR I guess it's a matter of trying simply Jan 15 18:01:42 yup Jan 15 18:01:56 With different targets from Halium 7.1 and see what it does Jan 15 18:04:57 It's supposed to write at the end of proprietary-files.txt Jan 15 18:31:06 Ah OK so worst case it would duplicate entries? Jan 15 18:31:48 This won't solve the issues when something already exists in proprietary-files.txt but doesn't exist in vendor then? Jan 15 20:54:39 Herrie: no, but in this case it's weird, because it means lineageos works without that file Jan 15 21:00:04 Tofe: Well I've seen such cases Jan 15 21:00:11 Usually unofficial ports Jan 15 21:01:01 I've tested my original setup script on all 7.1 and 5.1 targets that were there at that time Jan 15 21:01:08 So I know :P Jan 15 21:01:28 About 25 in total if I recall correctly **** BEGIN LOGGING AT Fri Jan 15 23:21:53 2021 **** ENDING LOGGING AT Sat Jan 16 03:00:36 2021