**** BEGIN LOGGING AT Fri Nov 19 02:59:56 2021 Nov 19 07:42:00 Morning! Nov 19 07:42:24 Morning! Nov 19 07:43:08 Which code ? ImageService ? Nov 19 08:24:38 Tofe: Yeah Nov 19 08:24:52 It's silly to have the code but not being able to use it Nov 19 08:25:03 BTW it seems it's not working 100% OK yet in all cases Nov 19 08:27:03 Herrie: I guess they didn't have any use for it, so they left it unused Nov 19 08:27:24 But yes, having a CMake flag or something would be best Nov 19 08:27:48 Tofe: OK found the cause of my issue, seems need to add some LS2 tweaks Nov 19 08:28:51 Though it could be challenging to have different json content depending on a configure option Nov 19 08:30:52 https://bpa.st/MJ2A Nov 19 08:31:24 Should be easy enough to fix, but first some coffee Nov 19 08:31:28 And breakfast LOL Nov 19 08:42:02 morning Nov 19 08:57:14 Herrie: what's this "com.webos.monitor1063"? never saw that one before Nov 19 09:04:36 ls-monitor ;) Nov 19 09:05:13 https://github.com/webosose/luna-service2/blob/1495bfd5913d10e54d68c34add33fd6261107194/files/sysbus/ls-monitor.role.json.in Nov 19 09:05:18 Herrie: mmh then it's weird that we get an error because we're trying to debug things :) Nov 19 09:14:02 Tofe: Yeah, will look into it, probably something small Nov 19 09:14:17 I guess it was me trying to list the methods with ls-monitor -i com.palm.image Nov 19 09:21:42 When I do the same for com.webos.service.image it works Nov 19 10:57:36 Tofe: Well there's a logical explanation: https://github.com/webOS-ports/luna-sysservice/blob/webOS-ports/webOS-OSE/files/sysbus/com.webos.service.systemservice.service.role.json.in#L9-L18 Nov 19 10:58:01 Seems that for com.webos.service.systemservice we provided a bunch of outbound permissions and for com,palm.image not Nov 19 10:58:09 I guess best would be to just replicate them? Nov 19 10:59:20 Might be a bit overkill, but well Nov 19 11:47:30 Herrie: shouldn't it be "com.webos.monitor*" instead of "com.webos.monitor", by the way? Nov 19 12:00:56 luna-sysservice SRCREV bump pushed Nov 19 12:03:13 Tofe: Yeah I guess so Nov 19 12:29:56 The call still isn't working, but error msg is gone from logs :S Nov 19 12:52:09 Well actually they aren't gone... Weird stuff a bit Nov 19 12:53:01 Well or not, because it seems we only register com.webos.service.image https://github.com/webOS-ports/luna-sysservice/blob/webOS-ports/webOS-OSE/Src/ImageServices.cpp#L522 Nov 19 12:53:11 But I thought we somehow could have those legacy calls working as well Nov 19 12:54:01 Herrie: iirc, in ls-hubd, we have some compatibility code that changes com.palm into com.webos or something like that Nov 19 12:54:38 Tofe_: Well it could be this is the compat.api.json file that needs some entries maybe? Nov 19 12:54:56 could be Nov 19 13:26:28 Tofe: Can you try this at your end? Could be just be my installation is borked somehow Nov 19 13:26:30 luna-send -n 1 palm://com.palm.image/ezResize '{"src":"/usr/share/wallpapers/LuneOS.jpg","dest":"/media/internal/LuneOSResized.jpg","destType":"jpg","destSizeW":640,"destSizeH":480}' Nov 19 13:37:28 Herrie: I'll try tonight, I'm not at home today Nov 19 14:00:01 Tofe: OK :) Nov 19 17:37:28 Ok, back at home Nov 19 17:38:17 Herrie: should I patch something before I try your ls2 call ? I already have my PR code on device Nov 19 17:42:47 Tofe_: No it should just work Nov 19 17:42:56 For me here it works with com.webos.service.image but not with com.palm.image Nov 19 17:43:02 But could be just my tinkered image somehow Nov 19 17:44:07 I built a new image here as well, so I can test from scratch Nov 19 18:07:07 Herrie: well, the ls2 call with com.palm just never returns Nov 19 18:07:42 it just works with com.webos, as you said Nov 19 18:08:14 I'm surprised that the one with com.palm doesn't just throw us away with an error Nov 19 18:25:20 Tofe: Well we could also just simply patch the relevant JS bits to call com.webos.service.image instead Nov 19 18:25:23 It aren't many anywya Nov 19 18:25:40 Herrie: I'd say, let's do that yes Nov 19 18:26:09 Let me check legacy webOS doctor for references to make sure we don't break anything important Nov 19 18:26:44 I see only ./frameworks/contacts/version/1.0/javascript/properties/ContactPhoto.js in /usr/palm Nov 19 18:27:15 There's one in Mojo on legacy which we can ignore Nov 19 18:27:36 And then in com.palm.service.contacts Nov 19 18:27:41 That's it Nov 19 18:27:54 ok, good, let's patch that then go on Nov 19 18:28:36 I do it, or you do it ? let's just not do it twice :p Nov 19 18:29:48 I'll do it Nov 19 18:29:54 ok thanks Nov 19 18:34:07 I guess we can cleanup luna-sysservice again too then and remove the com.palm.image ones ;) Nov 19 18:34:13 I'll get to that as well Nov 19 18:36:51 Tofe: This should do it. We should just switch the recipe to new branch for OSE: https://github.com/webOS-ports/loadable-frameworks/commit/cbfe3af596bd3708fa68c6891716a097260faa67 Nov 19 18:41:02 And this one; https://github.com/webOS-ports/luna-sysservice/pull/15 Nov 19 18:57:24 all good for me Nov 19 19:15:46 Tofe_: OK :) **** ENDING LOGGING AT Sat Nov 20 02:59:56 2021