**** BEGIN LOGGING AT Fri Feb 19 02:59:58 2016 Feb 19 03:00:27 it’s 10pm, do you know where your child views are? Feb 19 03:01:14 have any keyword suggestions for searching? Feb 19 03:05:38 I possibly found the problem Feb 19 03:08:16 okay cool, I made a bit of a derp Feb 19 03:08:29 but still I have the issue where some items have more padding on the right than others Feb 19 03:11:58 it has 4 items correct, then the next 2 have extra space to the right Feb 19 03:12:02 and that pattern repeats Feb 19 03:14:00 ah, I have an idea… I think it is because some of the children are not resizing even though their contents shrunk Feb 19 03:18:18 I am quite sure this is what is happening, but I can't figure out how to fix the layout… I tried calling .ForceLayout() and .RequestLayout() on the parent view Feb 19 03:19:45 ah, .RequestLayout() on the particular TextViews worked Feb 19 03:19:57 It's `requestLayout`. This is Java. :s Feb 19 03:20:22 oh right, sorry, I forgot to apply the Java translation Feb 19 03:20:57 Why are you needingn to call View.requestLayout? Feb 19 03:21:03 needing* Feb 19 03:21:30 I don't know why Feb 19 03:22:05 I think something may be wrong. Feb 19 03:23:24 could be, but I'll just accept that it is working now Feb 19 03:28:18 A lightning bolt flies out of the sky. The Android gods are not pleased. Feb 19 03:28:48 haha, well, out of the gods I worship they are not among them Feb 19 03:59:18 DrDuck, any kind of education is worth it for a beginner Feb 19 04:00:46 a couple margaritas and I'm a happy camper Feb 19 04:04:29 hmm, is the Mosby lib a good fit for a basic MVP implementation? Feb 19 04:04:50 guess thats a rather broad question Feb 19 04:15:02 my personal preference; i dont like these 3rd party libraries that try to codify an architectural pattern like MVP ontop of something that didn't have MVP in mind Feb 19 04:15:25 its one thing if google designed something to be clearly opinionated, and MVP or MVVM to begin with ... Feb 19 04:15:35 like MS did with MVVM. its hard to avoid it even Feb 19 04:16:21 i'd rather reuse the pattern than a library in that case Feb 19 04:18:32 g00s: Guess thats a good point. Also, I wasnt a fan of how with Mosby it seemed like it was at the core of your application, everything had to extend or implement those custom Mosby interfaces etc.. Feb 19 04:18:47 though I guess its because it tries to handle things like viewstate easier Feb 19 04:20:15 i get "Plugin with id 'com.android.application' not found." and i tried a few google ideas but none worked Feb 19 04:20:34 aside from learning gradle well is there any other way to get past this issue? Feb 19 04:22:03 jdv79: post your build.gradle Feb 19 04:22:46 Does anyone here have experience on how to tag on an imageview, like what Instagram does? Feb 19 04:23:01 i didn't modify it. i cloned a repo and am just trying to build it. https://android.googlesource.com/platform/packages/apps/DeskClock/+/master/build.gradle Feb 19 04:24:41 jdv79: First SO results suggest to check your gradle version and update built tools, did you do that? Feb 19 04:27:07 br0mahn: What does that mean? Feb 19 04:28:24 TacticalJoke: It's like tagging on a photo itself (the imageview) say for example, "shoes" or "bag" Feb 19 04:28:34 not hashtags Feb 19 04:29:30 when the user touches the image on a certain coordinate, it has the ability to tag it. Feb 19 04:29:49 I haven't found much on stackoverflow. Might need to google more. Feb 19 04:30:04 I did get v2.11 and pointed android studio at it. Feb 19 04:32:51 br0mahn, sounds like an easy problem, handle touches, do work Feb 19 04:33:41 jdv79, android aosp doesn't build using gradle, even though they include a build.gradle, it is insufficient Feb 19 04:36:37 oh. so how does one build this stuff? Feb 19 04:43:49 is there a nicer way of interacting with sql lite than hardcoding awful strings in java? Feb 19 04:44:22 at a minimum i would like to be able to just read from a strings / queries xml file Feb 19 04:44:32 kommunicate not sure if something like jooq exists for android ... Feb 19 04:45:06 every time i see a tutorial with something like String query = "SELECT X "... my brain explodes Feb 19 04:46:16 sql is awful? have you seen other query langs? its not that bad. Feb 19 04:46:36 hello Feb 19 04:46:36 jdv79: i hate the hardcoded strings... total maintenance nightmare Feb 19 04:46:37 most attempts to avoid sql end up being way shittier Feb 19 04:46:39 well, embedding sql in java as strings kinda sucks ... not that sql is bad Feb 19 04:47:02 i would love something a bit more orm-like, but probably not that heavy Feb 19 04:47:09 how can I make a sort of button on the lock screen? i hear lock screen widgets have been retired Feb 19 04:47:14 no. its not a maint nightmare. Feb 19 04:48:54 i've worked on stuff that had sql strings all over, sql strings in a shared lib, and full out ORMS. i think just normal embedded sql is the easiest to work with. Feb 19 04:49:20 but people love making things hard. idk. good luck. Feb 19 04:51:17 jdv79: i respect your opinion, but having worked on systems with each of those approaches, embedded sql is by far and away my least favorite approach Feb 19 04:51:57 sql strings? everyday business milord Feb 19 04:52:05 standard part of any codebase Feb 19 04:56:14 kommunicate i agree with you; anyhow looks like jooq isn't available on android afaict Feb 19 04:56:54 i don't like ORM but find a type safe builder for SQL kinda neat Feb 19 04:57:01 mm.. looks like there's a few alternatives Feb 19 04:57:07 ever tried ormlite? Feb 19 04:57:32 well, now you are into orm territory ... good luck :) Feb 19 04:57:48 I would be all over a JPA-compliant interface Feb 19 04:57:52 that's all i really want Feb 19 04:58:01 oh well, looks like this is going to be a bit more.. involved Feb 19 05:01:29 might anyone know about lock screen custom button? ^ Feb 19 05:01:34 kommunicate Android is ... involved :D Feb 19 05:01:55 regedit 5.0 and above, no lock screen stuff Feb 19 05:02:27 g00s: none at all? come on, what's the workaround :) Feb 19 05:02:44 custom rom maybe :P Feb 19 05:02:49 heh.. Feb 19 05:03:21 on my device I sometimes have what appear to be persistent notifications Feb 19 05:04:04 i googled about that a bit, that seems to be a programmable thing, is it not? a notification that remains persistent until the related app releases it? Feb 19 05:04:45 and in this notification could I not place some custom button that is pressable and have some effect happen as a result? Feb 19 05:06:43 let me ask it this way: I am trying to create some convenient service/facility which ideally should be triggerable even without unlocking the screen. Is such an effect not possible to achieve somehow? Feb 19 05:07:47 at most you'd need to power on the device and tap something. But any more swipes/taps than that would defeat the desired ease of access / convenience factor Feb 19 05:08:22 is that a completely unreasonable requirement? Feb 19 05:13:28 official Volley is on jcenter Feb 19 05:15:36 g00s: was that for me? you're saying such an effect can be triggered via http request? Feb 19 05:15:44 no Feb 19 05:15:53 oh Feb 19 05:29:56 is it possible to have a PreferenceFragment, where a toolbar is ontop of its listview ? Feb 19 05:31:27 need to add it to its view hierarchy Feb 19 05:38:06 ah, easy :) Feb 19 05:41:44 android has support for pressure sensitive touch correct? Which API? Feb 19 05:42:22 whatsTheWord might be thinking of iOS Feb 19 05:43:10 nah, I thought android was supposed to have had support for it, for a long time. I downloaded a test app called markers by a google developer that's supposed to implement it, but using it doesn't show any functionality. Feb 19 05:43:27 I haven't dived in the code yet, but I thought the APIs were supposed to be there. Feb 19 05:44:38 not that i've heard of. requires special touch panels Feb 19 06:16:41 why would one use a Handler over an interface? Feb 19 06:16:53 flexibility? Feb 19 06:19:07 that's completely orthogonal Feb 19 06:19:20 you use a handler for message handling, queuing and processing Feb 19 09:01:59 I have an upload intentservice uploading images, if user selects more images to upload, how to I add more data to that service to upload or start a new service if its not running? Feb 19 09:06:03 Is there something like onNewIntent for intent services? Feb 19 09:26:20 dont activity communicated with interservice via broadcast Feb 19 09:28:13 Ashiren: Isn't it other way around, intentservice communicate with activity using broadcasts? Feb 19 09:28:36 Google docs show some bound service which uses IBinder for communication Feb 19 09:28:58 I wish there was a onNewIntent method in intentservices Feb 19 09:29:27 In IntentService you just override onHandleIntent.. IntentServices takes care of the rest Feb 19 09:33:41 SimonVT: but doesn Feb 19 09:34:05 SimonVT: *but doesn't that queue a new instance of service? Feb 19 09:34:18 No, Services are singletons Feb 19 09:34:33 SimonVT: Oh cool, you are a lifesaver Feb 19 09:34:46 Read the services documentation, it should explain this Feb 19 09:36:47 Or just look at the IntentService implementation, see how it queues tasks Feb 19 09:46:08 Hey, any of you had problems setting control transfers to device connected through Usb? I get constant messages from connected Usb device which basically contain 2 bytes [1, 96] Feb 19 09:51:45 I'm sending HEAD request using HttpURLConnection on background Thread, but it fails on android 4; works ok for android 2.3, 5 or 6, anyone knows what is going on? Feb 19 09:52:51 magic Feb 19 09:53:54 maybe some logs would help :v Feb 19 09:54:26 whats the response when it fails @ Serpent7776 Feb 19 09:56:51 orbyt_, getResponseCode throws IOException, getHeaderFields returns null, haven't check response body, but it should be null or something - it's HEAD, right? Feb 19 09:57:29 Yea, its shouldnt return a body Feb 19 09:59:36 Pretty sure the IO exception should have the response code in it Feb 19 10:01:27 orbyt_, getMessage also returns null inside IOException catch block Feb 19 10:01:41 SimonVT: Didn't work, I just tried startService() twice on an image, it spawned 2 services running parellely Feb 19 10:02:05 oO Feb 19 10:02:21 It didn't Feb 19 10:03:07 orbyt_, maybe I should check getErrorStream, but I don't know how to send data from this stream to Log.d Feb 19 10:05:42 ok think I found how to get String from InputStream Feb 19 10:06:28 So, bind to that service? Feb 19 10:07:41 You don't bind to IntentServices. You send intents with startService, and it will handle them in order.. It does not spawn 2 instances of the same service Feb 19 10:10:51 SimonVT: It didn't. I called startService() twice with 10 images each time, and images from both lists were getting uploaded. Also I am showing progress in notification so I need to update total image count there as well Feb 19 10:12:16 weird, getErrorStream also returns null :/ Feb 19 10:21:53 I can see in server logs that server responds with normal 200 response code Feb 19 10:39:29 Anyone knows how to control number of concurrent upload requests in okhttp? Feb 19 10:54:30 I found a solution: http://stackoverflow.com/questions/17638398/androids-httpurlconnection-throws-eofexception-on-head-requests Feb 19 10:54:55 turns out it was really a EOFException, not a IOException and it's known bug Feb 19 11:05:40 Serpent7776: I think HttpUrlConnection also gives IOException when there's a 404 Feb 19 11:06:27 astroduck, thanks I already fixed this: http://stackoverflow.com/questions/17638398/androids-httpurlconnection-throws-eofexception-on-head-requests Feb 19 11:16:47 Hello everyone, I am trying to create a model that fetch Json data drom a url…. This is just a java class and i am using JsonReader. When i try to run my Test in Android studio.. i get java.lang.RuntimeException: Method beginObject in android.util.JsonReader not mocked… Can anyone suggest a native java class i can use to read json data from url into a Map? Feb 19 11:19:26 spykins, retrofit? :) Feb 19 11:21:55 wtf. suddenly d.android.com shows me japanese localized docs O.o Feb 19 11:22:48 Zharf: what;s retrofit? Feb 19 11:23:11 danijoo, didn't we talk about localization problems a few days ago? Feb 19 11:23:37 spykins, http://square.github.io/retrofit/ Feb 19 11:23:45 yes. And I was the one who said everything is fine with it >.< Feb 19 11:23:46 xD Feb 19 11:23:51 :p Feb 19 11:24:02 karma i guess Feb 19 11:24:28 Thak Feb 19 11:24:49 Thanks Zharf Feb 19 11:38:30 is there a way to change a certain color from an image into something else but keep everything else? Feb 19 11:38:44 I played around with color filters before but they were single color images Feb 19 11:40:21 (drawable) Feb 19 12:33:57 god Feb 19 12:34:04 there isnt one decent react-native app for android Feb 19 12:34:18 you can maybe attribute some faults to the app developers Feb 19 12:34:30 but not 1 is good? Feb 19 12:34:31 hum Feb 19 12:34:59 maybe its react ;) Feb 19 12:35:45 pretty much Feb 19 12:35:45 Well it's the mindset. Feb 19 12:36:02 If you wanna be cheap on dev time and do multiplatform. Feb 19 12:36:12 It probably means you're cheap on UX design and good interaction as well. Feb 19 12:36:25 well, true. Feb 19 12:37:02 but you go look into the featured react-native apps on the react page and every single one of them is a joke Feb 19 12:37:25 we were looking into a react-native hackathon here to get familiar with the tool Feb 19 12:37:56 but after looking into this godawful work im not so sure we can ever accept react projects Feb 19 12:44:46 I'm trying to execute integration tests for a specific build configuration from the command line. unfortunately just doing /gradlew cAT seems to execute them only for one configuration Feb 19 12:46:12 Syzygy, ./gradlew connectedYOURBUILDCONFIGAndroidTEst Feb 19 12:46:20 thanks Feb 19 12:46:27 ie connectedDebugAndroidTest Feb 19 12:46:59 I understand, thanks Feb 19 12:50:30 https://github.com/canelmas/let Feb 19 12:50:36 you boys know this? Feb 19 12:54:28 Nope, seems similar to the solution I wrote for permissions. Except I didn't do annotations. Feb 19 12:55:25 then how is it similar? they're both in java or design for android? Feb 19 12:55:28 :p Feb 19 12:55:50 but seems like a cool thing to use until JakeWharton releases his own version, then we all switch to that one Feb 19 12:55:50 they are both written on keyboards Feb 19 12:56:17 just saying Feb 19 12:58:25 For some reason one of my builds configurations can not run integration tests. it works in api 21+ but not lower, regular builds work as well. the problem is that CallSuper is included twice, once by the support library and once by renderscript. Any idea how I can prevent that issue? Feb 19 13:03:05 Anyone have experience with killing com.example.app : provider dying in process com.example.app? Feb 19 13:06:48 Syzygy: works on other build configurations? Feb 19 13:07:36 barq, I dont have experience with com.example.app :/ Feb 19 13:07:42 jvrodrigues: I can compile everything except the integration tests for lower api levels Feb 19 13:08:09 barq: unclosed cursor if I remember correctly Feb 19 13:08:27 not sure about details, but you can find stuff if you google it Feb 19 13:11:59 whats the best place to (un)subscribe to an observable that emits view events (clicks, edittext etc)? onResume/onStop? Feb 19 13:13:30 on Pause Feb 19 13:13:42 you want to subscribe either onCreate or onPostResume Feb 19 13:13:47 err thats what I meant. onResume/onPause :) Feb 19 13:14:30 subscribing onResume will occasionally lead to state loss Feb 19 13:14:45 (or could) Feb 19 13:15:17 its a fragment so theres no onPostResume Feb 19 13:15:37 ah Feb 19 13:15:41 then its all good Feb 19 13:15:43 onResume Feb 19 13:16:37 i currently have it in onViewCreated but I get some weired bug reports when unsubscribeing. I cant reproduce it :/ Feb 19 13:16:54 But I guess ill just move that code to onResume and see whats happening in production Feb 19 13:19:04 if I bindToLifecycle from onCreateView it unsubscribes in destroy view so that is likely the problem Feb 19 13:20:36 Yeah, onPause makes a lot of sense Feb 19 13:20:46 It's always called and your UI is inactive afterwards. Feb 19 13:20:47 are you subscribing/unsubscribing in onCreateView/onDestroyView? Feb 19 13:21:11 fragment can be in a paused state and its view not been destroyed though Feb 19 13:21:20 so it would still be subscribed Feb 19 13:21:25 and receiving UI updates Feb 19 13:22:10 im subscribing in onViewCreated right now and from the source of RxLifecycle it seems that means it unsubscribes in onDestroyView. Feb 19 13:22:38 what im doing is I swap cursors from a recyclerview depending on the text in a search box Feb 19 13:24:21 and crashlytics shows me some rare crashes I cant track down. I know they happen in this fragment ad the line where they happen is when I replace the cursor with null because of unsubscribing Fatal Exception: java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid view holder adapter positionViewHolder{1cb71439 position=74 id=2031, oldPos=74, pLpos:74 scrap [attachedScrap] tmpDetached no parent} Feb 19 13:24:21 at android.support.v7.widget.RecyclerView$Recycler.validateViewHolderForOffsetPosition(RecyclerView.java:4251) Feb 19 13:24:21 at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:4382) Feb 19 13:24:21 at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:4363) Feb 19 13:24:25 at android.support.v7.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:1961) Feb 19 13:24:28 at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1370) Feb 19 13:24:30 at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1333) Feb 19 13:24:32 at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:562) Feb 19 13:24:34 at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:2864) Feb 19 13:24:36 at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3071) Feb 19 13:24:38 at android.view.View.layout(View.java:16924) Feb 19 13:24:40 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:24:42 at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579) Feb 19 13:24:44 at android.widget.FrameLayout.onLayout(FrameLayout.java:514) Feb 19 13:24:46 at android.view.View.layout(View.java:16924) Feb 19 13:24:48 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:24:50 at android.support.design.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1037) Feb 19 13:24:52 at android.support.design.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:747) Feb 19 13:24:56 at android.support.design.widget.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:42) Feb 19 13:24:58 at android.support.design.widget.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:1156) Feb 19 13:25:01 at android.support.design.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:760) Feb 19 13:25:03 at android.view.View.layout(View.java:16924) Feb 19 13:25:05 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:25:05 wew lad Feb 19 13:25:07 at android.support.v4.widget.DrawerLayout.onLayout(DrawerLayout.java:1043) Feb 19 13:25:09 at android.view.View.layout(View.java:16924) Feb 19 13:25:11 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:25:13 at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579) Feb 19 13:25:15 at android.widget.FrameLayout.onLayout(FrameLayout.java:514) Feb 19 13:25:17 at android.view.View.layout(View.java:16924) Feb 19 13:25:19 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:25:21 if only someone had invented a website to paste shit to. Feb 19 13:25:21 at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1702) Feb 19 13:25:25 at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1556) Feb 19 13:25:27 at android.widget.LinearLayout.onLayout(LinearLayout.java:1465) Feb 19 13:25:29 at android.view.View.layout(View.java:16924) Feb 19 13:25:30 like a bin, where you can paste your shit Feb 19 13:25:31 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:25:33 at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579) Feb 19 13:25:35 at android.widget.FrameLayout.onLayout(FrameLayout.java:514) Feb 19 13:25:36 milion dollar idea boys Feb 19 13:25:37 at android.view.View.layout(View.java:16924) Feb 19 13:25:39 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:25:41 at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1702) Feb 19 13:25:43 at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1556) Feb 19 13:25:45 at android.widget.LinearLayout.onLayout(LinearLayout.java:1465) Feb 19 13:25:47 dafuq Feb 19 13:25:47 at android.view.View.layout(View.java:16924) Feb 19 13:25:49 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:25:51 at android.widget.FrameLayout.layoutChildren(FrameLayout.java:579) Feb 19 13:25:52 funny that his client has spam protection Feb 19 13:25:53 someone kick him? Feb 19 13:25:55 at android.widget.FrameLayout.onLayout(FrameLayout.java:514) Feb 19 13:25:57 at android.view.View.layout(View.java:16924) Feb 19 13:25:59 at android.view.ViewGroup.layout(ViewGroup.java:5409) Feb 19 13:26:01 at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2452) Feb 19 13:26:03 at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2156) Feb 19 13:26:05 at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1298) Feb 19 13:26:05 kick him ffs Feb 19 13:26:07 at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6982) Feb 19 13:26:09 at android.view.Choreographer$CallbackRecord.run(Choreographer.java:821) Feb 19 13:26:11 at android.view.Choreographer.doCallbacks(Choreographer.java:606) Feb 19 13:26:13 at android.view.Choreographer.doFrame(Choreographer.java:576) Feb 19 13:26:15 at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:807) Feb 19 13:26:17 at android.os.Handler.handleCallback(Handler.java:739) Feb 19 13:26:19 at android.os.Handler.dispatchMessage(Handler.java:95) Feb 19 13:26:21 at android.os.Looper.loop(Looper.java:145) Feb 19 13:26:25 at android.app.ActivityThread.main(ActivityThread.java:6872) Feb 19 13:26:26 the first line would have sufficed mate Feb 19 13:26:27 at java.lang.reflect.Method.invoke(Method.java) Feb 19 13:26:29 at java.lang.reflect.Method.invoke(Method.java:372) Feb 19 13:26:31 at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404) Feb 19 13:26:33 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199) Feb 19 13:26:35 oh shit.. Feb 19 13:26:37 sorry Feb 19 13:26:39 wrong clipboard :/ http://pastebin.com/AEbQZvJy Feb 19 13:26:40 you are updating your ui after the fragment was dettached Feb 19 13:26:41 already had it in pastebin and forgot to strg+c again ;) Feb 19 13:26:41 too late Feb 19 13:26:53 jvrodrigues, yep that was my guess too Feb 19 13:27:13 which means you are not unsubscribing where you should be unsubscribing Feb 19 13:27:26 onResume/onPause are good options Feb 19 13:28:16 canvs2321, my client has spam protection? Feb 19 13:29:26 haha Feb 19 13:29:58 antiflood,so don't get spam kicked Feb 19 13:30:09 good to know ;) Feb 19 13:30:53 Get rid of the fragment :P Feb 19 13:30:57 But i think we dont have spam protection in here anyways Feb 19 13:31:11 Guys, please help me write some nicer codes :P Could someone code review a function for me ? I have it in gist :) Feb 19 13:31:14 Hello. What is the best practice these days for managing asynctasks spawned from an activity or fragment? Should I just keep a list of them and cancel them all on detach/destroy? Feb 19 13:31:42 suhas_sm: Don't ask to ask just ask. Feb 19 13:31:50 :| Feb 19 13:32:04 https://gist.github.com/suhas-sm/c870f311a54803b8f3d7 Feb 19 13:32:22 please tell me how can I possibly break this method down in smaller methods Feb 19 13:32:29 cordovafan8: Asynctasks should not perform long running tasks Feb 19 13:32:35 I hate watching such methods because of volley ( Feb 19 13:32:54 use retrofit Feb 19 13:33:03 move the listener to a seperate file Feb 19 13:33:11 that breaks it down to 17 lines Feb 19 13:33:47 hmm Feb 19 13:33:48 and then delete both files and use retrofit :p Feb 19 13:34:18 ahahaha the twist :D Feb 19 13:34:19 and then use broadcast listener to tell about response ? Feb 19 13:34:26 haha thats the future plan Feb 19 13:34:36 I fuckin hate volley Feb 19 13:34:45 too many lines of code Feb 19 13:35:21 You can also post this on codereview.stackexchange. Feb 19 13:35:54 I this community :) Feb 19 13:36:02 like** Feb 19 13:37:11 @danijoo I am correct about the listener ? or use callback or something ? #noRXPleaseForNow Feb 19 13:39:02 suhas_sm: EventBus Feb 19 13:39:06 please use an event bus Feb 19 13:39:10 please Feb 19 13:39:24 I have only 5 network calls. Feb 19 13:39:47 jvrodrigues: these are not long running tasks, but I still want to manage the asynctasks Feb 19 13:39:48 like it is absolutely impossible to have a stable android app if you dont use some form of the observable pattern Feb 19 13:39:54 To start the trip, to end the trip and couple of others apart from this in the gist which uploads locations. Feb 19 13:40:17 cordovafan8: let them finish, and if they have a listener the listener respondes to the result if not then all is good Feb 19 13:40:22 jvrodrigues, thats not right. What do you think did the people do before event bus? Feb 19 13:40:23 dont go down the road of trying to cancel them Feb 19 13:40:44 jvrodrigues: and if the calling activity is destroyed? Feb 19 13:40:49 danijoo the same thing i did, their own observables using singletons, thers not so much science behind event bus Feb 19 13:40:51 then I have memory leaks everywhere Feb 19 13:41:10 cordovafan8: if the activity is destroyed your async task will be destroyed within 5-10 seconds Feb 19 13:41:31 I don't think that is guarranteed anywhere from what I can see Feb 19 13:41:34 jvrodrigues, BroadcastReceiver are a solution too. But I dont like them too. But they arent unuseable Feb 19 13:42:22 cordovafan8: yes, yes it is, also you technically dont even need an instance of your activity inside the async task Feb 19 13:42:26 you can just use an event bus Feb 19 13:42:37 and post an event after its done Feb 19 13:42:47 Yep, I have location listener and gcm listner, both broadcast intents Feb 19 13:42:58 if in between the activity gets recreated the new one will get whatever the old one started Feb 19 13:43:00 or simple check if the passed activity is still valid or finished. Feb 19 13:43:20 or just dont pass an activity? Feb 19 13:43:23 for screen rotation you can also use a headless fragment Feb 19 13:44:05 I'm facing a weird bug [https://dpaste.de/zUix] if value of upload_status = "Uploaded %s of %s photos" notification doesn't show when uploadCount = 0 and totalCount = 1 changing upload_status to "%s of %s photos uploaded" fixes it Feb 19 13:44:18 BroadcastReceivers have their uses. None of them relates to this. Feb 19 13:44:18 jvrodrigues: that's if you use an event bus. If you're just relying on callbacks, the asynctasks will keep a reference to the activity with the callbacks right? That would mean the entire activity sticks around in memory until the asynctask is done. I'm sure there are cases where this will fail or take longer than expected (network problems etc) Feb 19 13:44:36 I am probably doing something dumb, but I have no idea what. Any clue? Feb 19 13:45:53 cordovafan8: yes. but 1- dont try to cancel a network request while its working. Seriously, dont go down that road, its like arguing with a crazy person. 2. Use an event bus instead, so that if the activity gets destroyed the result is still used Feb 19 13:45:58 astroduck, whats showing up instead? Feb 19 13:46:14 danijoo: no notification Feb 19 13:46:44 astroduck, did you attach a debugger to ssee why Feb 19 13:47:04 changing uploadCount / totalCount to any other value shows it again Feb 19 13:47:15 it showed nothing weird happening in my code Feb 19 13:47:19 didn;t look into android Feb 19 13:47:46 feels to me that your cause/effect relation is faulty Feb 19 13:47:54 astroduck, what makes you think its because of conttentText and not your if/else clause Feb 19 13:48:10 i guess one of those if/else branches doesnt lead to a visible notification Feb 19 13:48:30 danijoo: I tried removing all if else and writing notification part outside makes it work Feb 19 13:49:04 also, hardcoding setContentType to say "..." also shows notification as expected Feb 19 13:50:37 content...type? Feb 19 13:50:44 jvrodrigues: can you provide more information on why you recommend against trying to cancel asynctasks? It seems that event busses are not easily implemented without a library. Feb 19 13:50:47 Type, setContentText Feb 19 13:50:55 *typo Feb 19 13:51:01 :D Feb 19 13:51:01 typoception Feb 19 13:51:09 there doesn't seem to be a reason you can't just check isCancelled() at strategic points Feb 19 13:51:11 cordovafan8 there are several ways to go at it without implementing a library Feb 19 13:51:36 why not using a library Feb 19 13:51:45 Is it a bad idea for an Activity to implement a listener and then pass the Activity where the listener is needed? Feb 19 13:51:47 you can keep a collection of callbacks in an application singleton and add/remove within the activity lifecycle Feb 19 13:51:48 those are already tested solutions to your problem\ Feb 19 13:52:11 barq depends Feb 19 13:52:23 jvrodrigues: how is that different than doing the same with a list of asynctasks? Feb 19 13:52:39 cordovafan8: you dont hold activity in the asynctask? Feb 19 13:52:41 barq, thats done a lot - for exapmple as click listener Feb 19 13:53:15 barq: rule of thumbs: if whatever you're passing your listener to has a life expectancy bigger than that of the activity, dont do it Feb 19 13:53:25 and asynctasks are one of these things Feb 19 13:53:58 a view is bound to the activity lifecycle Feb 19 13:54:00 so thats fine Feb 19 13:54:57 unregistering listeners isn't that big of a deal Feb 19 13:55:56 why might findViewById() return null? Feb 19 13:56:08 it's not found Feb 19 13:56:16 RustySha1kleford, because your id is wrong Feb 19 13:56:19 because the view with whatever id is not a child Feb 19 13:56:46 guess that would make sense. I can't think of another reason it would be null Feb 19 13:56:57 ugh, too early to be tracking down null pointer exceptions Feb 19 13:57:06 cordovafan8, good read: http://simonvt.net/2014/04/17/asynctask-is-bad-and-you-should-feel-bad/ Feb 19 13:57:10 its 3 pm here Feb 19 13:57:22 danijoo: link is already purple :) Feb 19 13:57:36 cordovafan8, good re-read :p Feb 19 13:57:40 async tasks arent bad Feb 19 13:57:44 people just dont know how to use them Feb 19 13:58:05 jvrodrigues, dont judge a post by its click-bait title. Feb 19 13:58:11 at least before reading it Feb 19 13:59:41 danijoo: I'm already using the fragment setRetainInstance method to work around configuration changes. Feb 19 14:01:09 cordovafan8: use an event bus. Feb 19 14:01:19 the gods of development will thank you Feb 19 14:01:47 things would be so much easier if the application had an event bus implemented in it by default, you really cannot make a decent app without making use of some sort of observable pattern Feb 19 14:01:55 application class, I mean Feb 19 14:02:13 or the framework had a builtin bus Feb 19 14:02:25 jvrodrigues, ehm. Feb 19 14:02:53 jvrodrigues, you mean this one: https://developer.android.com/reference/android/support/v4/content/LocalBroadcastManager.html ? :) Feb 19 14:03:16 Even though it's more tedious to use than EventBus tho Feb 19 14:03:20 sort of like that one Feb 19 14:03:32 jvrodrigues: can you explain why this somehow gets around the need for AsyncTask to reference the activity? Does the eventbus not just send the activity reference to the asynctask when it calls getInstance()? Aren't we instead just keeping a reference to all active activities in the event bus instead? Feb 19 14:03:34