**** BEGIN LOGGING AT Tue May 22 03:00:05 2018 May 22 05:33:12 muneeb17: Did I mention that the rpmsg channel for PRU appears as a char device (`/dev/rpmsg`) ? And you can use that to read (`cat`) and write (`write`) messages to PRU ? May 22 05:34:29 ah !! write = `echo` May 22 06:51:26 zeekhuge: Yeah. I used that for the rpmsg functions(send_msg, get_msg) in the code. Though, I used normal file IO, wanted to avoid executing shell commands as much as possible. Also, Could you take a look at this(https://github.com/MuneebMohammed/pypruss/blob/586c39671fa370039d69588124ce261104b4dff1/pypruss/pypruss.py#L81) and comment. I have yet to test it. May 22 06:53:38 muneeb17: Please ! better commits messages and titles ! May 22 06:53:55 follow a standard for commit titles and messages May 22 06:54:10 like less than 72 char wide May 22 06:54:37 title lie - "Add memory related functions" instead of "Added memory related functions" May 22 06:54:55 and then a blank line. May 22 06:55:19 then there should be commit-message describing the changes. May 22 06:55:25 also, add comment to your code. May 22 06:56:19 well, v detailed code comments can wait till you start documentation May 22 06:58:04 zeekhuge: Will take care of these things definitely. May 22 07:00:36 zeekhuge, abhishek_ : Also, should the C/C++ bindings go inside the pypruss repo or should i make another one ? May 22 07:08:15 muneeb17: Yeah I think so. Actually know what ? maybe should create a whole new repo, add PyPruss and other bindings int that and then edit the wikis to mark that repo as your project-repo. May 22 07:08:39 Also, can I look into that code link later ? May 22 07:08:56 zeekhuge: yeah, no problem. May 22 07:09:44 btw .. the event number is the PRU number or what ? May 22 07:10:06 why name it "eventno" > May 22 07:10:14 ? May 22 07:11:02 zeekhuge: yeah, actually the previous code had that, but since this is completely different, ill change it. May 22 07:11:31 you see this - https://github.com/ZeekHuge/BeagleScope/blob/port_to_4.4.12-ti-r31%2B/examples/firmware_exmples/pru_pin_state_reader/PRU_PIN_STATE_READER/main.c#L63 May 22 07:11:58 This is what decides the channel that will be created by the driver May 22 07:12:02 hence its PRU-code specific May 22 07:12:19 so allow users to be able to change that via methods in the bindings. May 22 07:13:03 I mean .. if user specifies channel name -"foo" in the PRU code, the py bindings will still search for "rpmsg_pru" thing May 22 07:14:42 zeekhuge: Ohk. Got it. So the bindings should be involved in the firmware code as well. May 22 07:15:16 no ! allow the user to specify what channel name to look for. May 22 07:15:30 in the python bindings only May 22 07:16:14 zeekhuge: ok **** ENDING LOGGING AT Wed May 23 03:00:01 2018