**** BEGIN LOGGING AT Wed Aug 06 02:59:59 2014 Aug 06 09:09:38 bluelightning: asking before rpjday notices it...what's the exaxct rule about slashes btw expanded vars or at the end ? Aug 06 09:10:26 ant_work: sorry what's the context? Aug 06 09:10:41 some janitoring work Aug 06 09:10:56 i.e. Aug 06 09:10:58 - install -m 0755 kexecboot ${D}${bindir}/ Aug 06 09:11:04 + install -m 0755 kexecboot ${D}${bindir} Aug 06 09:11:12 but I've seen also Aug 06 09:11:27 install -d ${D}/${bindir} Aug 06 09:11:30 note the slash Aug 06 09:11:50 afaik most vars are terminated by slash Aug 06 09:12:10 most? any? Aug 06 09:12:32 surely ${D} and ${S} Aug 06 09:13:13 all that because I've casually spotted some '//' in the expanded string Aug 06 09:13:16 ;) Aug 06 09:14:48 I was thinking to write a script for detecting these doubles but it is not immediate Aug 06 09:14:54 there are valid cases like Aug 06 09:14:56 install -d ${D}/proc Aug 06 09:15:11 >>>afaik most vars are terminated by slash Aug 06 09:15:14 ^bs Aug 06 09:15:27 seems are prepended Aug 06 09:17:08 looking at bitbake.conf, slash is indeed prepended Aug 06 09:17:16 in the vars declared there Aug 06 09:17:48 yes, prepended, so you shouldn't need them in between in that instance Aug 06 09:18:14 (because ${bindir}, ${sysconfdir} etc must work as absolute paths on their own, so they must start with /) Aug 06 09:19:03 ok, so we could grep for 'D}/${' Aug 06 09:19:17 well, yes... but are those causing problems? Aug 06 09:19:17 '}/${' Aug 06 09:19:22 no :p Aug 06 09:19:46 I mean, if you want to go and clean those up I won't stop you... :) Aug 06 09:20:18 and about the terminating slash? Aug 06 09:20:55 my patch got unexpected answer Aug 06 09:20:57 "What is the reason for this change. Using XXX/ is quite common Aug 06 09:20:57 in OE recipes." Aug 06 09:23:50 which patch is that, sorry? Aug 06 09:23:57 I'm a bit behind on my email atm :( Aug 06 09:24:48 http://patches.openembedded.org/patch/77049/ Aug 06 09:27:41 I wouldn't worry about it - he's just querying it, he's not saying it shouldn't be changed Aug 06 09:29:33 I'm pretty sure the copy&paste originated lot of such cruft in oe-classic Aug 06 09:31:52 seems we have also bad examples around Aug 06 09:31:57 http://openembedded.org/wiki/Styleguide Aug 06 09:32:26 whil eth eold Poky manual gave the example Aug 06 09:32:32 do_install() { Aug 06 09:32:32 install -d ${D}${bindir} Aug 06 09:32:32 install -m 0755 helloworld ${D}${bindir} Aug 06 09:32:32 } Aug 06 09:32:32 **** ENDING LOGGING AT Thu Aug 07 02:59:58 2014