**** BEGIN LOGGING AT Thu Jul 18 02:59:56 2019
Jul 18 05:34:51 <khem> armpit: deleted my branch and pushed again then it worked
Jul 18 13:21:40 <armpit> khem, no good. still same issue
Jul 18 13:27:14 <ribalda> Hello. I am getting a: "buffer overflow detected" error with tftpd.
Jul 18 13:27:51 <ribalda> When I look into the code, there is no such buffer overflow, just an old codebase that is reusing a buffer and I think libc is getting confused
Jul 18 13:28:16 <ribalda> I made a workaround, that reallows tftp (and netboot) to work again.
Jul 18 13:28:57 <ribalda> the question is that patch is valid for OE. Or shall I ping libc, or what do you suggest ;)?
Jul 18 13:40:38 <vmeson> ribalda: it depends on the change. upstream to glibc/musl would be best but some changes are yocto specific.
Jul 18 13:53:32 <ribalda> @vmeson  the change for tftp is replacing a strcpy with memcpy. That does the trick. But there is no reason do the change, the bug is on the "detector". I am trying to make a minimal example before I report it to glibc
Jul 18 14:07:47 <vmeson> ribalda: cool. OE people on the email list might want to take a look to ensure that it's not an OE configuration error but that seems unlikely.
Jul 18 14:22:43 <ribalda> vmeson: I managed to replicate the bug on my debian :(. that is not good
Jul 18 15:15:32 <vmeson> well, then it's not oe-core specific so that's good in a way! ;-)
Jul 18 19:23:17 <khem> and its a good chance its not libc bug either
Jul 18 19:23:26 <khem> but I am all ears open
Jul 18 19:49:20 <ribalda> khem: vmeson: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91205
Jul 18 19:49:38 <ribalda> I posted the bug there and also sent a patch to the meta-oe mailing list
Jul 18 19:49:51 <ribalda> I mean, oe-core
Jul 18 19:51:25 <ribalda> btw, why nobody likes my patch: https://patchwork.openembedded.org/patch/162763/ :P ?
Jul 18 20:35:34 <khem> ribalda:looking at your example, can you find which of strcpy ends in error 
Jul 18 20:37:00 <ribalda> khem: https://github.com/Distrotech/inetutils/blob/distrotech-inetutils/src/tftpd.c#L757
Jul 18 20:38:40 <khem> that I understand, I wanted to know which iteration in loop is causing it 
Jul 18 20:39:02 <khem> the struct has an entry {"-1", 0 }
Jul 18 20:39:14 <khem> which will be unterminated str
Jul 18 21:00:39 <ribalda> ahh, sorry. It fails on the first one
Jul 18 21:01:05 <ribalda> the smallest example: https://www.irccloud.com/pastebin/Z31ucRWs/ also fails
Jul 18 21:01:45 <ribalda> it even fails on my debian. I guess you can run it on your computer and will fail too (if you havent deleted gcc yet)
Jul 18 23:02:39 <armpit> khem, contrib repo fix something on the server
**** ENDING LOGGING AT Fri Jul 19 02:59:57 2019