**** BEGIN LOGGING AT Tue Apr 07 02:59:57 2020
Apr 07 20:23:53 <ribalda> paulbarker: hello
Apr 07 20:24:31 <paulbarker> ribalda: Hi
Apr 07 20:25:03 <ribalda> I think fixing the bug on the patch is no more than adding an if
Apr 07 20:26:04 <ribalda> it is not worth adding it to the current version? At the end of the day we are solving another issue, not adding a new feature
Apr 07 20:27:40 <paulbarker> ribalda: My worry is that this is happening so late in the release cycle, RP said on the dev call before that the release build is done and currently with QA
Apr 07 20:28:39 <paulbarker> I don't understand why the patch was accepted at this stage
Apr 07 20:29:30 <ribalda> sorry :(, I usually just send patches whenever they are tested on my side and do not care too much about the release cycle
Apr 07 20:30:20 <paulbarker> ribalda: no problem, I think the patch is moving things in the right direction, I just want it to work for all use cases
Apr 07 20:30:46 <RP> paulbarker: something I need to be aware of?
Apr 07 20:31:16 <paulbarker> And I want to make sure we don't have to maintain compatibility with this for the 2 year LTS cycle
Apr 07 20:33:59 <paulbarker> RP: I'm concerned about https://git.openembedded.org/openembedded-core/commit/?id=efdcf94801f6abe8e4099e324d9a3deccd8d4384 and https://git.openembedded.org/openembedded-core/commit/?id=36993eea89d1c011397b7692b9b8d61b499d0171 making it in at this late stage in the release cycle
Apr 07 20:34:56 <paulbarker> Both had feedback from me which was unresolved
Apr 07 20:35:10 <RP> paulbarker: I thought the feedback was resolved
Apr 07 20:35:27 <RP> paulbarker: sorry. Is this serious enough I pull the brakes on QA?
Apr 07 20:35:59 <paulbarker> RP: I don't like it but it's not going to break the world
Apr 07 20:36:19 <ribalda> RP: also https://git.openembedded.org/openembedded-core/commit/scripts/lib/wic/plugins/source/rootfs.py?id=36993eea89d1c011397b7692b9b8d61b499d0171 in combination with a rootfs that is either partial (/home) or a non rootfs can trigger a nasty error
Apr 07 20:36:40 <ribalda> it is not the most likely configuration and can be fixed with a simple fix.
Apr 07 20:36:49 <paulbarker> 1st patch: I'm concerned that arguments `--include-path` and `--embed-rootfs` are easily confused and unclear
Apr 07 20:37:17 <RP> paulbarker: I can pull the plug on rc1, I guess I'd better
Apr 07 20:37:24 <paulbarker> 2nd patch: As ribalda said there, this may break common use cases of moving `/home` to a separate partition
Apr 07 20:38:04 <ribalda> (not that common :P becasue it also needs --include_path --exlude or --embed, but a bug nontheless)
Apr 07 20:38:22 <RP> I do really need to decide now :/
Apr 07 20:38:48 <RP> and spend the rest of the evening doing rc2 ASAP if we do abort rc1
Apr 07 20:45:14 <ribalda> would it help if I post the patch to fix the /home + --include_path ?
Apr 07 22:07:14 <RP> ribalda: I've reverted them, this is going to cause too many potential issues to be in 3.1
Apr 07 22:08:59 <ribalda> RP: no worries I will work with paulbarker to get it on shape for the next release. Thanks and sorry for the mess
Apr 07 22:14:49 <RP> ribalda: thanks, working with paul is the best way forward
**** ENDING LOGGING AT Wed Apr 08 03:00:04 2020