**** BEGIN LOGGING AT Sun Apr 04 02:59:58 2010
Apr 04 17:25:46 <Djdas> jprvita[AFK], I found your website looking for dbus 1.3.0 for Ubuntu, did you packaged it for running oFono? Does it works well? Thank you in advance
Apr 04 17:44:38 <denkenz> I run dbus 1.3 on Gentoo and it works fine
Apr 04 17:45:23 <Djdas> well I have ubuntu 9.10 here and I can't run oFOno 0.20
Apr 04 17:45:37 <Djdas> I think this should be because I have dbus 1.2 here
Apr 04 17:45:55 <denkenz> oFono still works with DBus pre 1.3
Apr 04 17:46:43 <Djdas> uhm... what do you think this problem could be?
Apr 04 17:46:45 <Djdas> $ ofonod -n
Apr 04 17:46:45 <Djdas> ofonod[28437]: oFono version 0.20
Apr 04 17:46:45 <Djdas> ofonod[28437]: Unable to hop onto D-Bus: Connection ":1.94" is not allowed to own the service "org.ofono" due to security policies in the configuration file
Apr 04 17:46:45 <Djdas> ofonod[28437]: Exit
Apr 04 17:47:03 <Djdas> I just compiled from Git
Apr 04 17:47:09 <denkenz> You have not installed the dbus policy file
Apr 04 17:47:17 <denkenz> Or you're not running ofono as root
Apr 04 17:47:33 <Djdas> you mean the one in /etc/dbus-1/system.d?
Apr 04 17:47:42 <Djdas> it's there and I'm running as root
Apr 04 17:47:52 <denkenz> see src/ofono.conf
Apr 04 17:48:05 <denkenz> Then an instance of oFono is already running
Apr 04 17:48:48 <denkenz> But this is not a dbus version problem, either your ofono.conf is not configured or something else owns the service
Apr 04 17:49:10 <Djdas> $ cat /etc/dbus-1/system.d/ofono.conf 
Apr 04 17:49:10 <Djdas> <!-- This configuration file specifies the required security policies
Apr 04 17:49:10 <Djdas>      for oFono core daemon to work. -->
Apr 04 17:49:10 <Djdas> <!DOCTYPE busconfig PUBLIC "-//freedesktop//DTD D-BUS Bus Configuration 1.0//EN"
Apr 04 17:49:10 <Djdas>  "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
Apr 04 17:49:10 <Djdas> <busconfig>
Apr 04 17:49:12 <Djdas>   <!-- ../system.conf have denied everything, so we just punch some holes -->
Apr 04 17:49:14 <Djdas>   <policy user="root">
Apr 04 17:49:16 <Djdas>     <allow own="org.ofono"/>
Apr 04 17:49:18 <Djdas>     <allow send_destination="org.ofono"/>
Apr 04 17:49:20 <Djdas>   </policy>
Apr 04 17:49:22 <Djdas>   <policy at_console="true">
Apr 04 17:49:24 <Djdas>     <allow send_destination="org.ofono"/>
Apr 04 17:49:26 <Djdas>   </policy>
Apr 04 17:49:28 <Djdas>   <policy context="default">
Apr 04 17:49:30 <Djdas>     <deny send_destination="org.ofono"/>
Apr 04 17:49:32 <Djdas>   </policy>
Apr 04 17:49:34 <Djdas> </busconfig>
Apr 04 17:49:54 <Djdas> no, no other instance and modem.conf is phonesim enabled
Apr 04 17:51:22 <Djdas> I don't know what else I can look :(
Apr 04 17:52:09 <denkenz> the conf looks good, are you sure you're running as root?
Apr 04 17:52:25 <Djdas> yes
Apr 04 17:52:59 <denkenz> Then try restarting dbus daemon, otherwise I've no idea
Apr 04 18:07:09 <Djdas> dbus restart crashed my system (I hate Ubuntu :@) but now it works, thank you denkenz 
Apr 04 18:13:59 <denkenz> funny :)
Apr 04 18:15:13 <Djdas> yes too windows-like for me :P
Apr 04 19:48:04 <Djdas> denkenz, the first version of the sqlite history is quite ready, I'm preparing the emails with patches
Apr 04 19:48:11 <Djdas> I have just one question:
Apr 04 19:48:52 <Djdas> I used as example the example_history in which there is this "if" statement:
Apr 04 19:49:08 <Djdas> if (call->clip_validity == 0)
Apr 04 19:49:08 <Djdas> 		from = phone_number_to_string(&call->phone_number);
Apr 04 19:49:52 <Djdas> what's the meaning of the clip_validity field? Must I have to check this too as per the history example?
Apr 04 20:13:50 <denkenz> So certain organizations like the police can see the number even if it is withheld
Apr 04 20:15:20 <denkenz> so we convert the number only if we truly have it
Apr 04 20:16:12 <denkenz> In general that situation is a corner case, so feel free to ignore it
Apr 04 20:16:44 <denkenz> Probably never happens in real life ;)
Apr 04 20:18:16 <Djdas> ok so I can simply remove the if statemente and convert the number, right?
Apr 04 20:27:47 <denkenz> in theory
Apr 04 22:25:30 <holtmann> Djdas: Coding style is not optional. Please follow the coding style used so far. It must be the same.
Apr 04 22:29:42 <Djdas> sorry holtmann I used "indent linux" which other part should I check?
Apr 04 22:30:08 <holtmann> No idea why it did this wrong, but it looks wrong.
Apr 04 22:31:15 <Djdas> ops have you got a set of parameters to indent?
Apr 04 22:33:05 <holtmann> Nope. I just code in the coding style anywya.
Apr 04 22:33:44 <Djdas> uhm ok, I'll try to check and resend the patch
Apr 04 22:34:12 <Djdas> could you please point me at something you see particularly wrong?
Apr 04 22:34:26 <Djdas> just to understand better
Apr 04 22:44:50 <Djdas> holtmann, I tried to reindent the first function, do you think it's ok?
Apr 04 22:44:52 <Djdas> int check_db()
Apr 04 22:44:53 <Djdas> {
Apr 04 22:44:53 <Djdas> 	int ret_val = 0;
Apr 04 22:44:53 <Djdas> 	ofono_debug("Checking if DB is empty");
Apr 04 22:44:53 <Djdas> 	if (sqlite3_table_column_metadata(db, NULL, "ofono_history_calls",
Apr 04 22:44:53 <Djdas> 					  "ohc_modem_path", NULL, NULL, NULL,
Apr 04 22:44:55 <Djdas> 					  NULL, NULL) != SQLITE_OK) {
Apr 04 22:44:57 <Djdas> 		char *systemcmd;
Apr 04 22:44:59 <Djdas> 		systemcmd =
Apr 04 22:45:01 <Djdas> 		    g_strdup_printf("sqlite3 -batch %s < %s",
Apr 04 22:45:03 <Djdas> 				    SQL_HISTORY_DB_PATH, SQL_HISTORY_DB_SQL);
Apr 04 22:45:05 <Djdas> 		ofono_debug("Initializing DB: %s", systemcmd);
Apr 04 22:45:07 <Djdas> 		ret_val = system(systemcmd);
Apr 04 22:45:09 <Djdas> 		g_free(systemcmd);
Apr 04 22:45:11 <Djdas> 	}
Apr 04 22:45:13 <Djdas> 	return ret_val;
Apr 04 22:45:15 <Djdas> }
Apr 04 22:47:03 <holtmann> I does't look okay. You are mixing tabs and whitespaces.
Apr 04 22:47:34 <holtmann> I haven't looked at the patch at all, but the tabs vs space issues was obvious.
Apr 04 22:47:53 <Djdas> uhm, ok I'll recheck indentation maybe there is something wrong with my indent command
Apr 04 22:48:01 <Djdas> thank you very much
Apr 04 22:48:11 <Djdas> bye
**** ENDING LOGGING AT Mon Apr 05 02:59:56 2010