**** BEGIN LOGGING AT Thu May 13 02:59:56 2010 May 13 03:00:02 denkenz: One more question: Must I limit the commit header within 50 chars? I find sometimes it's hard to meet. May 13 03:01:56 yes, but you can make the commit header small and expand the description May 13 03:03:18 Then is it needed to add the prefix of feature name, such as "test-stkutil: " May 13 03:03:48 I find it even has more than 10 chars. May 13 03:04:27 shorten it to stk: May 13 03:04:59 ok, I will have the limitation as a must. May 13 03:05:10 thanks May 13 05:16:12 denkenz: Huawei modem returns '+CME ERROR: invalid index'. but our error entry is 'Invalid index'. So I think we need to use g_string_ascii_up() to convert them as upper case before comparing. May 13 05:20:43 denkenz: ops, i can use g_ascii_strcasecmp() to do that May 13 12:50:59 denkenz, yang_office: my idea was also that there could just be a _peek_next_tag function May 13 12:51:14 but save/restore is more powerful May 13 15:00:00 zhenhua: Point is we shouldn't use verbose error reporting, instead we should use numeric May 13 15:00:09 zhenhua: The descriptions are pointless anyway May 14 00:29:41 denkenz: but i think it's good to perserve the string compare part, in some modem like huawei, we don't specific CMEE=1, so it still reports 'CMS ERROR: invalid index'. May 14 00:29:59 s/CMS/CME May 14 01:08:44 zhenhua: So lets specify CMEE=1 ;) May 14 01:22:35 denkenz: heh, that's fine. May 14 01:23:38 denkenz: any comments for modem emulator? May 14 01:25:27 denkenz: for ATD*99# or AT+CGDATA='ppp', which one should be implemented first? May 14 02:21:32 whichever the DUN spec mandates May 14 02:24:12 DUN spec only defines ATD and spec itself is too vague to follow May 14 02:24:35 then do that one for now May 14 02:24:55 okay. **** ENDING LOGGING AT Fri May 14 02:59:56 2010