**** BEGIN LOGGING AT Thu Jul 22 02:59:56 2010
Jul 22 03:25:07 <denkenz> balrog-k1n: Why do you say Set Up Call is nasty, looks fairly straight forward
Jul 22 03:37:50 <denkenz> And I find this pretty funny:
Jul 22 03:37:53 <denkenz> In addition to the rules given in ETSI TS 102 223 [32] clause 6.4.13 the following applies:
Jul 22 03:37:53 <denkenz> -	If the UICC supplies a number stored in EFECC, this shall not result in an emergency call.
Jul 22 09:29:16 <balrog-k1n> denkenz: hmm i saw it say somewhere that "112" must result in an emergency call (terminal translates it to the area-specific number)
Jul 22 09:30:31 <balrog-k1n> denkenz: it looks nasty because you have two interactions, first you have to ask the user whether they want to set up call, and later somehow pass the voicecall object path (maybe in a signal on simtoolkit interface?)
Jul 22 09:31:45 <balrog-k1n> btw. the api misses a way to send a "EndSession" in a sim-initiated session
Jul 22 09:32:41 <balrog-k1n> maybe it should have org.ofono.Error.EndSession, that would be useful for both agents
Jul 22 09:34:40 <balrog-k1n> Set Up Call is also nasty because it can result in a data call or other type and then there's this subaddress field that needs to be sent to the network but afaik AT doesn't have a way to do that (neither does ofono driver api)
Jul 22 14:23:02 <denkenz> balrog-k1n: Yeah, the '112' part is in 102.223, but 31.111 says not to initiate emergency calls
Jul 22 14:23:38 <denkenz> balrog-k1n: And we can ignore data calls, so if we get a Subaddress or a CCP object, just return the incapable terminal response
Jul 22 14:24:22 <denkenz> The spec also says crap like the Setup Call should succeed even if FDN is enabled, which we obviously can't do
Jul 22 14:26:39 <denkenz> balrog-k1n: The alpha id / icon for call setup phase is a bit crappy, but at least for the confirmation phase we can re-use RequestConfirmation
Jul 22 14:27:16 <denkenz> Let us ignore the call setup alpha / icon for now, just make the other parts work
Jul 22 17:14:02 <luke-jr> trying to get ofono running, but it won't list my modem :/
Jul 22 17:14:47 <luke-jr> if I SIGSTOP sscd before it gives up on upstart, phonet0 logs as 'up', but still nothing
Jul 22 17:27:09 <denkenz> Not too many people here have experience with the n900
Jul 22 17:27:49 <denkenz> Ones that do are probably asleep now ;)
Jul 22 19:22:39 <ljp> i have an n900 but not running ofono on it
Jul 22 19:22:49 <denkenz> balrog-k1n: It seems to me that build_dataobj_text is not quite correct, the sim tells us what alphabet it expects, so we should only give it the one it wants, right?
Jul 22 20:10:30 <balrog-k1n> denkenz: depends which command you're talking about
Jul 22 20:11:43 <balrog-k1n> in GetInput the card indicates what character set is allowed but not the encoding
Jul 22 20:11:47 <denkenz> balrog-k1n: The only ones we encode today are GetInkey and GetInput
Jul 22 20:13:35 <denkenz> For GetInkey that's actually an ambiguity
Jul 22 20:13:41 <denkenz> I assume it expects only uncompressed
Jul 22 21:26:26 <abyrd> new to ofono community, are the new code changes submitted through the email list? 
Jul 22 21:31:06 <denkenz> abyrd: Correct
Jul 22 21:34:05 <abyrd> along with the changes, are there any test criteria that we have to meet? or any test reports we need to provide?
Jul 22 22:03:13 <denkenz> abyrd: It sort of depends, if you're writing utility style code (like in smsutil or stkutil), then unit tests to accompany the code is preferred
Jul 22 22:03:48 <denkenz> If you're writing core code, then testing on real hardware or phonesim changes are encouraged, but not always possible
Jul 22 22:04:29 <denkenz> In the end it is a judgement call for the maintainer
Jul 22 22:35:17 <abyrd> denkenz: Thank you. I still have more questions, are guidelines for submission documented anywhere or should i submit all my questions to the email list?
Jul 22 22:36:12 <denkenz> abyrd: Please read doc/coding-style.txt
Jul 22 22:36:34 <denkenz> It covers most of the coding guidelines.  Patch submission guidelines are similar to e.g. Linux kernel
Jul 22 22:36:46 <denkenz> E.g. git clone ofono
Jul 22 22:36:49 <denkenz> make some changes
Jul 22 22:37:02 <denkenz> git format-patch -<num> patches to submit
Jul 22 22:37:05 <denkenz> git send-email
Jul 22 22:44:04 <denkenz> balrog-k1n: Still around?
Jul 22 22:45:05 <balrog-k1n> denkenz: yes
Jul 22 22:45:16 <denkenz> Have you looked into Refresh at all?
Jul 22 22:45:40 <balrog-k1n> denkenz: no, not yet
Jul 22 22:46:04 <denkenz> nod
Jul 22 22:46:59 <balrog-k1n> have you ever seen it used on any of your phones?
Jul 22 22:47:37 <denkenz> No, which makes me worried
Jul 22 22:47:52 <denkenz> However, the Nokia reqs state Orange SIMs with EL2 support do this
Jul 22 22:48:05 <denkenz> The specs are very fuzzy though
Jul 22 22:48:13 <balrog-k1n> maybe it's just not very useful
Jul 22 22:48:27 <denkenz> No, its useful for EFimsi changes
Jul 22 22:48:37 <denkenz> e.g. 2 UICC apps running on a single SIM
Jul 22 22:48:48 <balrog-k1n> yes, but how many people use this?
Jul 22 22:49:07 <denkenz> My guess is about 5?
Jul 22 22:49:32 <balrog-k1n> :)
Jul 22 22:49:53 <balrog-k1n> so i think the other things are higher priority and nicer to implement
Jul 22 22:50:57 <denkenz> Heh, no argument there, but we're on the hook for that one
Jul 22 22:51:08 <denkenz> So I'm doing the initial legwork
Jul 22 22:51:53 <balrog-k1n> great
Jul 22 22:51:58 <balrog-k1n> it is looking scary
Jul 22 22:52:14 <denkenz> It is actually not that bad from what I can tell
Jul 22 22:52:42 <denkenz> But there's a bazillion options, and I only understand a quarter of them
Jul 22 22:58:30 <balrog-k1n> btw. i have the javascript client working with the new STK api with two agents and the api is not as fragile as i thought
Jul 22 22:59:27 <denkenz> Heh, nice
Jul 22 22:59:34 <denkenz> We'll make a believer out of you yet ;)
Jul 22 23:38:59 <luke-jr> do I need ofono if I just want data? :p
Jul 22 23:49:59 <denkenz> oFono can do data-only as well
**** ENDING LOGGING AT Fri Jul 23 02:59:56 2010