**** BEGIN LOGGING AT Tue Oct 19 02:59:57 2010 Oct 19 13:51:57 pessi, akiniemi: How does the call barring mmi work on ISI Oct 19 13:52:16 are you guys fine with the proposed changes? Oct 19 15:18:55 denkenz: classes being combined? Oct 19 15:19:05 yeah Oct 19 15:19:22 I noticed that you don't even use classes right now Oct 19 15:22:31 we'd be happier with mmi code ;) Oct 19 15:24:20 yeah I was thinking you were going to say that Oct 19 15:24:51 I'm actually fine doing it that way Oct 19 15:25:38 Unless it is easier to make a reverse mapping Oct 19 15:25:54 from class to mmi? Oct 19 15:26:06 yeah Oct 19 16:04:14 pessi, balrog-k1n: At some point we really need to sit down and figure out this send tone stuff Oct 19 16:14:13 denkenz: the problem with handling the pauses in the core is that some modems (e.g. isimodem) can already do this for us Oct 19 16:14:27 we can send it a string like 1p2p3p4 Oct 19 16:14:51 I know Oct 19 16:15:01 But then ISI can do lots of neat stuff the rest don't ;) Oct 19 16:15:28 ok, so let's do it in the core Oct 19 16:15:58 I'm not set on anything btw Oct 19 16:16:09 I'm just against excessive code duplication Oct 19 16:16:16 Since about every modem has its own voicecall driver Oct 19 16:16:43 though here's a problem: if we want to allow other commands (like hang up call) in the middle of sending a long dtmf string, we will have to queue all commands in voicecall.c Oct 19 16:17:14 I think we can cheat a little Oct 19 16:17:22 so we could instead leverage the queue in gatchat / gisi (or let them execute simultaneously if the want, which is even better) Oct 19 16:18:07 we don't have to count send_tones as pending Oct 19 16:18:27 additional send_tone DBus methods can simply append to the tones list Oct 19 16:18:45 yeah, we could do this Oct 19 16:18:58 se we would just have a dtmf queue, like the sms queue Oct 19 16:19:04 yep Oct 19 16:19:17 Then we can implement pessi's idea of sending a signal when a DTMF is started Oct 19 16:19:19 and stopped Oct 19 16:19:26 And have SendTones return immediately Oct 19 16:19:49 DBus signal? Oct 19 16:19:59 yeah, I think so Oct 19 16:20:39 Similar to the 'provide feedback of sent DTMF tones' task Oct 19 16:22:11 We can either do it per that task or have a DTMF queue property + ToneStart / ToneEnd signals Oct 19 16:22:47 Or some other way Oct 19 16:23:41 denkenz: makes sense Oct 19 16:23:56 i had to check what's in the TODO Oct 19 16:24:25 Some modems also allow explicit start and stop Oct 19 16:24:33 denkenz: though the API change is a separate task and can wait after Send DTMF is implemented with the queue, right? Oct 19 16:24:43 yeah Oct 19 16:25:41 we have to be a bit careful with STK Oct 19 16:25:54 I think send dtmf requires no audible feedback on the local side Oct 19 16:26:33 really? i think it allows feedback as it comes back from the network Oct 19 16:26:40 either way ofono doesn't have much choice here Oct 19 16:26:50 nope, dtmf tones are generated locally Oct 19 16:27:10 The network only generates tones coming from the 'other' side Oct 19 16:27:32 yeah, but the network still sends our generated tones back to us in some form Oct 19 16:27:56 some modems simply take care of mixing in the tones into the local audio stream Oct 19 16:27:57 and we just have one method of generating tones on most modems Oct 19 16:28:30 Nope, the network doesn't send our tones back to us Oct 19 16:28:37 I'm pretty sure its the modem doing it Oct 19 16:28:45 +VTS is what the phones use foor entering passwords, internal numbers etc, so it always generates a tone to the network Oct 19 16:28:51 s/foor/for Oct 19 16:29:11 hmm Oct 19 16:29:43 doesn't the network echo back all sounds that we send to it? just a little lower, superimposed with the sound coming from the other party Oct 19 16:30:28 I don't think so, but pessi probably knows for sure Oct 19 16:31:05 From what I understood send DTMF is just a control signal to the network, its generated locally either by the modem or by the audio stack Oct 19 16:31:06 i could check using +VTS on the FreeRunner i guess Oct 19 22:46:31 users Oct 19 22:53:51 sudo make sandwich ;) Oct 19 22:58:56 Man, you truly are an automake god Oct 19 22:59:35 Tell me about it. **** ENDING LOGGING AT Wed Oct 20 02:59:56 2010