**** BEGIN LOGGING AT Thu Dec 09 02:59:57 2010 Dec 09 10:17:15 denkenz: ping Dec 09 10:18:51 Jeevaka: pong Dec 09 10:21:17 is it worth to add the SAT command simulation just like the conformance test cases in phonesim Dec 09 10:22:08 for eg: Display Text as one of the menu item and test cases listed in spec as the sub items Dec 09 10:24:30 I wouldn't mind that, I think it is a good idea Dec 09 10:25:18 See if Guillaume or Fred think this is a good idea Dec 09 10:25:26 Might help them with their efforts Dec 09 10:25:47 ok Dec 09 10:28:21 currently, we are issuing sim read request for MBDN,MWI and few more files without checking whether the service is enabled in the EFust Dec 09 10:29:11 do we need to add this check? Dec 09 10:41:34 yeah, sounds like a good idea Dec 09 10:47:28 any comments for the cfis/cphs-cff latest patches Dec 09 10:55:16 still looking at it Dec 09 10:57:41 Jeevaka: ok, question Dec 09 10:57:42 + if (cfu_voice == cf->status_on_sim) Dec 09 10:57:42 + return; Dec 09 10:57:42 + Dec 09 10:58:16 Does this break when we only change the CFU number? Dec 09 10:58:44 agree Dec 09 10:58:55 e.g. SetProperty(VoiceUnconditional, "+1555"), then to "+1666" Dec 09 10:59:01 i was expecting the comment Dec 09 10:59:51 in this case, we need to store the number as well from sim Dec 09 11:00:53 So in the case of EFcfis you want to also check that the numbers are different Dec 09 11:01:36 yep Dec 09 11:02:58 + sim_encode_bcd_number(cond->phone_number.number, Dec 09 11:02:58 + data + 4); Dec 09 11:02:58 + Dec 09 11:02:58 + } else Dec 09 11:03:11 Seems like there's an unneeded empty line there Dec 09 11:03:17 Otherwise I'm actually fine with the patches Dec 09 11:03:21 ok Dec 09 11:03:36 I'll fix the issues Dec 09 11:04:08 I'm planning to store the number as part of the ofono_sim atom, I think it wont be an issue Dec 09 11:05:08 You could try to be smart and call that when you signal VoiceUnconditional changed Dec 09 11:05:58 e.g. somewhere in set_new_cond_list Dec 09 11:06:06 dunno how easy that would be, but something to check Dec 09 11:17:43 ok Dec 09 12:36:13 denkenz: do you want me to send the full set of cfis patches onceagain or is it ok to send only patch 2 Dec 09 13:33:21 Jeevaka: full ones Dec 09 16:42:19 denkenz: make distcheck is failing here Dec 09 16:42:45 weird, the Makefile is generated with a line: MAKE=@make Dec 09 16:42:49 and it fails with: Dec 09 16:42:54 /bin/sh: line 7: @make: command not found Dec 09 16:43:02 Yeah, holtmann is fixing this Dec 09 16:43:11 ahn... ok Dec 09 16:44:54 denkenz: about this sim ready notify thing... are you happy with extra parameter in ofono_sim_passwd_cb_t, telling core hat it should wait for ready_notify? Dec 09 16:45:20 not really Dec 09 16:46:01 so how to delay intialization if sim is not ready but no pin codes are required? Dec 09 16:46:14 delay sim inserted notify? Dec 09 16:48:57 yep Dec 09 16:49:01 denkenz: hi! Dec 09 16:49:10 or not really sim_inserted_notify Dec 09 16:49:16 simply delay sim_ready Dec 09 16:49:29 emdete: heya Dec 09 16:49:49 denkenz: i would like to change the udev rule for my huawei to allow ppp but the file states its generated and i don't see from where... Dec 09 16:50:25 denkenz: delay callback from driver? Dec 09 16:50:58 also the master branch still doesnt detect sim insert status with my huawei. i have this brute force solution (just pretents its inserted always) Dec 09 16:51:29 denkenz: do u think this should go into the version? Dec 09 16:51:44 emdete: It is not really generated Dec 09 16:52:02 and nobody has had time to work on the huawei still Dec 09 16:52:23 but there are two, which one is in use? Dec 09 16:52:28 pessi: I prefer the current solution or using ofono_sim_ready_notify for this regardless whether the SIM needs a PIN or not Dec 09 16:52:37 yes, exactly, and i have no time too. but the fix works... Dec 09 16:52:42 emdete: two what? Dec 09 16:52:51 two udev rule files Dec 09 16:54:17 plugins/ofono.rules is the only one Dec 09 16:54:22 okay Dec 09 16:54:28 denkenz: so always wait for ready_notiify after sim-ready is returned in ofono_sim_passwd_cb_t? Dec 09 16:54:31 i have a 97... someting one here Dec 09 16:54:50 have to leave... se you Dec 09 16:55:11 pessi: That's my feeling right now, yes Dec 09 16:55:29 ok, I'll go for it Dec 09 20:13:53 hi - has anyone come across the error "fatal: cannot convert from unknown-8bit to UTF-8" when applying patches. Dec 09 20:13:59 For some reason the patch i submitted is returning this for Denis, but the format at my end is UTF-8 Unicode - which matches the original file before touching. Dec 09 23:37:56 denkenz: i have been investigating the format error for the TODO patch that i sent Dec 09 23:38:10 the format of the patch and the file at my end is UTF-8 Unicode - which matches the original file before touching. Dec 09 23:38:44 i suspect it may be similar to the issue at http://www.mail-archive.com/freeipa-devel@redhat.com/msg01162.html so will force my gitconfig format to be UTF-8 Dec 09 23:39:34 and retry - would you prefer a test offline first to avoid email spam? when we try to reproduce the error at this end we can't and everything looks fine even without this format option **** ENDING LOGGING AT Fri Dec 10 02:59:57 2010