**** BEGIN LOGGING AT Thu Apr 28 02:59:58 2011
Apr 28 12:10:20 <BertrandAygon> Hi. Did someone has some knowledge of SMS sending implementation in oFono?
Apr 28 13:00:35 <BertrandAygon> holtmann: ping
Apr 28 14:15:01 <BertrandAygon> denkenz: ping
Apr 28 14:17:15 <denkenz> BertrandAygon: pong
Apr 28 14:17:57 <BertrandAygon> Hi. I am looking at bug 12357,about sending a chinese vcal
Apr 28 14:18:24 <BertrandAygon> I could see that when we send a 'normal' sms, oFono looks at the text and will choose GSM or UCS2 DCS
Apr 28 14:18:46 <BertrandAygon> But when sending vcal or vcard, they are send directly as datagram, and so using 8bit charset
Apr 28 14:19:58 <BertrandAygon> What is the reason for this? I agree that if we send 'raw data' using an SMS, we have to use 8bits. But for vcard and vcal, which is text only, we should try to find best encoding. 
Apr 28 14:21:24 <denkenz> vcal is not normal data, it is utf8 or ucs2
Apr 28 14:21:39 <denkenz> We should not be transcoding it
Apr 28 14:22:31 <BertrandAygon> ok, but currently, from what I could see, it's utf8 only
Apr 28 14:22:46 <denkenz> no, it is whatever the encoding the file is in
Apr 28 14:22:53 <denkenz> We don't look inside the v-object
Apr 28 14:28:35 <BertrandAygon> But there is no encoding info inside the v-object
Apr 28 14:32:03 <BertrandAygon> I am a but lost...
Apr 28 14:33:36 <denkenz> You'd have to go back to the vCard RFC
Apr 28 14:33:40 <BertrandAygon> The PDU is tagged as vCal, and in UTF8
Apr 28 14:34:01 <denkenz> its been a while but basically it is assumed that the vCard is ASCII unless encoding is set appropriately
Apr 28 14:34:19 <denkenz> However, oFono treats the v-object as a bytestream
Apr 28 14:34:30 <denkenz> it will just pack it up as 8-bit data SMS and send it along
Apr 28 14:35:16 <denkenz> There's no reason for us to look inside
Apr 28 14:35:20 <BertrandAygon> Ok, I will go into the RFC, and ask the Chinese tester to send a Chinese VCal using a commercial phone to oFono, and extract the received PDU, to see how it's formatted
Apr 28 14:37:58 <denkenz> Last I checked, PRC testers had weird Python setup
Apr 28 14:38:06 <denkenz> Python was transcoding strings
Apr 28 14:40:56 <BertrandAygon> One other point. When doing test with PhoneSim, I got a crash in oFono. In fact, I have online-modem without doing the enable-modem. This is bad.
Apr 28 14:41:03 <BertrandAygon> But having a crash is rude
Apr 28 14:41:41 <BertrandAygon> Looking into the code, when going online, there is only a check to see if we are already online. But nothing else.
Apr 28 14:41:55 <BertrandAygon> Maybe looking at 'powered' will avoid the crash.
Apr 28 14:42:05 <BertrandAygon> What do you think about this?
Apr 28 14:45:24 <denkenz> sounds like a bug
Apr 28 14:48:06 <BertrandAygon> ok, I will investigate more and propose a patch
Apr 28 14:49:56 <denkenz> Fixed
Apr 28 14:52:30 <BertrandAygon> :)
**** ENDING LOGGING AT Fri Apr 29 02:59:57 2011