**** BEGIN LOGGING AT Tue Jun 25 02:59:58 2013
Jun 25 12:56:53 <paulk-desktop> morphis, ping
Jun 25 19:57:58 <paulk-desktop> morphis, ping
Jun 25 19:58:18 <morphis> paulk-desktop: pong
Jun 25 19:58:23 <paulk-desktop> morphis, hi
Jun 25 19:58:29 <morphis> paulk-desktop: hey :)
Jun 25 19:58:37 <paulk-desktop> I started cleaning up libsamsung-ipc a bit
Jun 25 19:58:46 <paulk-desktop> mainly by removing the unused h1 code
Jun 25 19:58:53 <paulk-desktop> and other things
Jun 25 19:59:00 <paulk-desktop> what do you think?
Jun 25 19:59:08 <morphis> thats nice
Jun 25 19:59:11 <paulk-desktop> ok
Jun 25 19:59:20 <morphis> paulk-desktop: pabs3 also has some worthfull comments on it
Jun 25 19:59:42 <paulk-desktop> well I'd be glad to hear them
Jun 25 19:59:47 <paulk-desktop> while I'm at it :)
Jun 25 20:00:09 <morphis> paulk-desktop: you already pushed?
Jun 25 20:00:38 <paulk-desktop> not yet but I can push what I've done so far if you want to take a look
Jun 25 20:00:48 <morphis> paulk-desktop: as I thought about changing the development model
Jun 25 20:00:57 <morphis> so we ever create PR's on github
Jun 25 20:01:00 <morphis> and never push directly
Jun 25 20:01:14 <morphis> so at least one of us has to review the code
Jun 25 20:01:27 <paulk-desktop> you mean for our own contributions?
Jun 25 20:01:33 <morphis> for everything
Jun 25 20:01:49 <morphis> everything you want to push has to go into a PR
Jun 25 20:03:07 <paulk-desktop> I feat that will unnecessarily request one of us to review changes made by the other
Jun 25 20:03:09 <paulk-desktop> fear*
Jun 25 20:04:26 <morphis> but exactly that will help us
Jun 25 20:04:30 <morphis> to keep things clean
Jun 25 20:04:50 <morphis> reviews are never unnecessarily
Jun 25 20:05:13 <morphis> and it's better to find flaws before the integration and after
Jun 25 20:05:29 <paulk-desktop> ok
Jun 25 20:05:33 <paulk-desktop> why not then
Jun 25 20:05:55 <morphis> ok
Jun 25 20:06:05 <morphis> paulk-desktop: btw do you have a github account?
Jun 25 20:06:09 <paulk-desktop> nope
Jun 25 20:06:12 <morphis> you need one
Jun 25 20:06:22 <morphis> otherwise you can't create PRs
Jun 25 20:06:26 <paulk-desktop> ah ok
Jun 25 20:06:30 <paulk-desktop> I'll do that then
Jun 25 20:06:38 <morphis> and I will drop your ssh key from the repo and add your account instead
Jun 25 20:06:47 <paulk-desktop> ok
Jun 25 20:06:59 <morphis> so until you created one you don't have push access anymore now :)
Jun 25 20:07:30 <paulk-desktop> okay
Jun 25 20:09:03 <morphis> paulk-desktop: just mail me your username
Jun 25 20:09:08 <paulk-desktop> ok
Jun 25 20:09:11 <paulk-desktop> thanks
Jun 25 20:34:10 <paulk-desktop> morphis, btw about wakelocks: I think we should leave that up to the upper layer rather than implement them in libsamsung-ipc
Jun 25 20:34:30 <paulk-desktop> since it's a very android-specific feature
**** ENDING LOGGING AT Wed Jun 26 02:59:58 2013