**** BEGIN LOGGING AT Mon Jan 13 02:59:59 2014 Jan 13 10:01:15 JaMa: I created a patch to add recipes for libotr and pidgin-otr http://paste.debian.net/hidden/b2647010/ Jan 13 10:01:52 Would be happy about any comments Jan 13 10:03:25 especially if this is the right location for the recipes Jan 13 10:05:49 also I'm getting a QA warning about /usr/include beeing included by libotr Jan 13 10:06:25 it still works but maybe you know how to fix that Jan 13 10:15:50 jake42: you can drop PR and SECTION lines Jan 13 10:16:08 jake42: it would be a bit better in meta-openembedded/meta-oe/recipes-support/pidgin Jan 13 10:17:01 jake42: /usr/include beeing included by libotr is probably caused by bad usage of autotools, look in config.log where -I/usr/include was added and make sure it's prefixed with sysroot path Jan 13 10:19:26 JaMa: ok, I'll drop those and move the recipes Jan 13 13:56:19 JaMa: thanks for the help, I was able to fix the QA-warning Jan 13 13:56:50 JaMa: now I just send the patch to openembedded-devel ml?? Jan 13 13:57:03 s/??/?/ Jan 13 13:57:04 jake42 meant: JaMa: now I just send the patch to openembedded-devel ml? Jan 13 14:17:56 jake42: yes, git send-email as in meta-oe/README is the easiest way Jan 13 15:48:08 jake42: sorry I haven't noticed it before, but could you resend them with SOB lines? Not only in OE patch but also in individual .patch files, where you should also add Upstream-Status field Jan 13 15:49:00 jake42: and you can drop ";apply=yes" in pidgin-otr Jan 13 15:49:23 JaMa: what are SOB lines? Jan 13 15:50:00 Signed-off-by Jan 13 15:50:14 ah right Jan 13 15:50:28 they where in the first patch Jan 13 15:50:30 git commit --amend -s will automatically add it for you Jan 13 15:50:32 forgot them now Jan 13 15:50:54 thanks Jan 13 15:50:57 will try Jan 13 15:52:38 thank you, btw: you're using SHR from "dora" branches right? Jan 13 15:56:22 JaMa: yes, right Jan 13 15:57:05 how's that going to be reflected in a patch? Jan 13 15:57:17 ok, I'll promote them after merging them to master Jan 13 15:57:51 they first need to be merged to master, after that you can resend them with [dora] in subject, but I can do that for you if you want Jan 13 15:59:00 I see Jan 13 15:59:13 ok, will first make all the changes and then we'll see Jan 13 16:02:29 yes, it's possible that I'll send you more review comments after building them in master on jenkins Jan 13 16:02:44 jake42: so it's better to wait a bit before duplicating the work for dora Jan 13 16:17:16 JaMa: yes, I've only tested with dora branch so far Jan 13 16:29:40 JaMa: I fail to find something enlightening about Upstream-Status and SOB for patch files Jan 13 16:30:17 JaMa: could you elaborate or maybe give me a link where I can read and learn about it Jan 13 16:31:02 yup, mmt Jan 13 16:31:26 http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Jan 13 16:31:45 thanks Jan 13 17:01:23 JaMa: reading this got me thinking. I have not submitted my 2 patches upstream and they are not appropriate for upstreaming Jan 13 17:02:08 they're just workarounds to make it work Jan 13 17:03:23 would require more time on my side to get to the bottom of the respective autotool issues, which I don't want to spend Jan 13 17:04:32 so is it fine to just write "Upstream-Status: Inappropriate: [embedded specific] - workarounds to make it build with OE Jan 13 17:04:37 " Jan 13 17:06:38 Pending would be a bit better value Jan 13 17:07:28 because those fixes should eventually go to upstream and Inappropriate is like saying that they shouldn't be ever upstreamed Jan 13 17:11:30 ok, I just don't know too much about why those errors occoured and of my "fixes" don't break anything Jan 13 17:12:17 that's OK, you can consider "Pending" as default value Jan 13 17:12:47 bottomline is probably "bad autotools usage" as you guessed. Jan 13 17:12:49 ok Jan 13 17:19:19 So I don't need an SOB for the patches when they Upstream-Status is Pending, right? Jan 13 17:20:25 no, you need it, SOBs are independenty from Upstream-Status Jan 13 17:23:26 ok Jan 13 18:33:28 JaMa: there goes another version.. **** ENDING LOGGING AT Tue Jan 14 03:00:00 2014