**** BEGIN LOGGING AT Fri Oct 09 02:59:59 2015 Oct 09 04:34:03 build #106 of pxa is complete: Failure [failed shell_10] Build details are at http://buildbot.openwrt.org:8010/builders/pxa/builds/106 Oct 09 05:16:39 I am thinking on writing a guide to openwrt developing, something like a guide on how core programs within openwrt have been written, and how may a 3rd party develop it's apps to have the same development strategy Oct 09 05:17:05 I was thinking first on documenting each of the libraries, starting with libubox Oct 09 05:17:23 and from there on, start describing how the various apps work, and how may be used Oct 09 05:17:52 I won't commit to put any time, because I don't know how much actual time I will have Oct 09 05:17:58 but just wanted to notify Oct 09 05:50:50 just in case, if someone could review http://wiki.openwrt.org/doc/techref/libubox and assert that you indeed need to initialize the uloop_timeout structure with not only the cb but also .pending=false... Oct 09 06:38:42 txomon: yes, sounds correct. Usually we use struct initialization with designated name, like uloop_timeout tm = { .cb = my_callback }; Oct 09 06:38:58 txomon: that will implicitely set anything else to NULL/0 Oct 09 07:47:45 mb r47166 trunk/target/linux/omap24xx/ Makefile image/Makefile config-4.1 * omap24xx: Append dtb to the zImage Oct 09 08:11:41 jow_laptop: yeah, I haven't programmed so long as to know that :p I will add that bit Oct 09 08:11:49 in C I mean Oct 09 08:14:55 thanks for the review Oct 09 08:14:59 I have updated it Oct 09 09:06:49 build #107 of ramips.mt7628 is complete: Failure [failed compile_5] Build details are at http://buildbot.openwrt.org:8010/builders/ramips.mt7628/builds/107 Oct 09 09:25:48 build #107 of brcm47xx is complete: Failure [failed compile_5] Build details are at http://buildbot.openwrt.org:8010/builders/brcm47xx/builds/107 Oct 09 10:26:17 txomon: keep up the good work :) Oct 09 10:27:04 something that might be nice is documenting in doxygen/javadoc style in the headers in the library themselves, and seeing if anyone can be convinced to generate the docs online for you. Oct 09 10:33:41 karlp: I don't think they are prone to maintain them... Oct 09 10:33:53 build #100 of mxs is complete: Success [build successful] Build details are at http://buildbot.openwrt.org:8010/builders/mxs/builds/100 Oct 09 10:34:08 I can send patches to the code, but we would need to be sure that docstrings would be maintained Oct 09 10:34:13 else, is as good as having the wiki Oct 09 10:35:37 txomon: well, if the docstrings are there, there's a chance of them being seen Oct 09 10:35:54 the wiki regularly falls out of date, look at the blockmount stuff. Oct 09 10:36:03 karlp: I can setup all the process, but we would need someones commitment in the code part Oct 09 10:36:07 I'm really glad you're adding stuff, dont' get me wrong, Oct 09 10:36:31 well, at the openwrt conference yesterday in dublin, imre at least said theyv'e got ideas on improving the documentation Oct 09 10:36:45 yeah, no worries, is just that if you have outdated docstrings in the code, that will be really worse Oct 09 10:36:50 if you add documentation to the code, it's prettyhard to justify ignoring the docs when you make changes. Oct 09 10:37:28 we've seen pretty clearly that they're not going to document them anywhere else, at least traditionally :) Oct 09 10:37:30 I mean, I can trust or not a wiki, but if the code has a docstring that says f() does A and it does A+B, it's worse Oct 09 10:37:44 yeah, but then you have a place to compalin to. Oct 09 10:37:52 what do you mean? Oct 09 10:37:54 if the wiki's out of date, the common answer is," the source is the documentation" Oct 09 10:38:03 if the source is conflicted, you can easily say, "fix y0 shit!" Oct 09 10:38:34 yeah, but it's more problematic. If I haven't got any idea in my mind, reading code will give me a good idea on what it does Oct 09 10:38:47 if there is a wrong docstring there, I will try to see what the docstring does Oct 09 10:38:52 and that's terrible Oct 09 10:39:07 s/does/says/ Oct 09 10:40:15 yeah, but the shame factor for developers merging code where they don't update the docstrings can behelpful. Oct 09 10:40:26 (all hinges on having documentation changes accepted anywya ;) Oct 09 10:42:27 karlp: I don't believe in shame. If they don't update that will be a really big problem. You should have core devs to sign for not to accept/commit any change that changes functionality and not docstrings Oct 09 10:42:57 If any of jow_laptop or nbd, then I start sending patches Oct 09 10:43:17 self shame, I wasns't talking about other people shaming Oct 09 10:43:45 that's a concept you must attribute to not updating docstrings. If you don't use them, then they are like rubbish to you Oct 09 10:44:01 and you don't feel shame for updating rubbish Oct 09 10:44:11 I mean, if the code base gets docstrings, either uloop.c or uloop.h, then the devs themselves would feel bad if they made changes that didn't update them. Oct 09 10:44:30 well, that's why I said it depends on getting docstrings in :) Oct 09 10:46:31 karlp: I am not sending patches till there is an statement xD Will continue to improve the wiki though, and won't mind if they in some time change their mind to send patches Oct 09 11:21:59 build #107 of lantiq is complete: Failure [failed compile_8] Build details are at http://buildbot.openwrt.org:8010/builders/lantiq/builds/107 Oct 09 11:51:16 build #108 of brcm47xx.legacy is complete: Failure [failed compile_5] Build details are at http://buildbot.openwrt.org:8010/builders/brcm47xx.legacy/builds/108 Oct 09 18:51:45 build #107 of ramips.mt7621 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org:8010/builders/ramips.mt7621/builds/107 Oct 09 18:55:08 build #95 of mpc83xx is complete: Failure [failed shell_10] Build details are at http://buildbot.openwrt.org:8010/builders/mpc83xx/builds/95 Oct 09 21:15:17 build #107 of ramips.rt3883 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org:8010/builders/ramips.rt3883/builds/107 Oct 09 21:18:55 build #98 of ramips.rt305x is complete: Failure [failed compile_5] Build details are at http://buildbot.openwrt.org:8010/builders/ramips.rt305x/builds/98 Oct 09 21:23:47 build #107 of rb532 is complete: Failure [failed compile_8] Build details are at http://buildbot.openwrt.org:8010/builders/rb532/builds/107 Oct 09 22:07:19 build #106 of x86.64 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org:8010/builders/x86.64/builds/106 Oct 09 23:22:05 build #97 of brcm47xx.mips74k is complete: Failure [failed compile_8] Build details are at http://buildbot.openwrt.org:8010/builders/brcm47xx.mips74k/builds/97 Oct 09 23:50:51 build #99 of lantiq.xrx200 is complete: Failure [failed compile_8] Build details are at http://buildbot.openwrt.org:8010/builders/lantiq.xrx200/builds/99 Oct 09 23:53:52 build #106 of ppc40x is complete: Failure [failed shell_10] Build details are at http://buildbot.openwrt.org:8010/builders/ppc40x/builds/106 **** ENDING LOGGING AT Sat Oct 10 02:59:59 2015