**** BEGIN LOGGING AT Wed Jan 24 03:00:01 2018 Jan 24 14:37:13 Hello people. I'm trying to add act_gact to the kmod-sched package. I assumed it would be a simple matter of adding the CONFIG_NET_ACT_GACT line to the existing ones but that is not enough. Apparently build_dir/target-i386_pentium4_musl-1.1.16/linux-x86_generic/linux-4.4.92/include/config/{tristate,auto}.conf do not reflect my changes and I'm not sure if I should edit those too or if they should be re-generated in some buildroo Jan 24 14:37:13 t specific way. Jan 24 14:52:37 FinboySlick: make sure to remove the tmp dir within the openwrt dir, show us your changes, mention which version of OpenWrt you are using and which target you are trying to build Jan 24 14:57:38 mkresin: 1- did that. 2- I added the line 'CONFIG_NET_ACT_GACT \' in package/linux/modules/netsupport.mk just after CONFIG_NET_ACT_SKBEDIT. 3- I'm using the latest lede sdk for x86 (lede-sdk-17.01.4-x86-generic_gcc-5.4.0_musl-1.1.16.Linux-x86_64.tar.xz) Jan 24 14:57:49 mkresin: It builds, but it just ignores my changes. Jan 24 14:58:30 (which makes sense if it uses the previously mentioned files as a kernel config, CONFIG_NET_ACT_GACT is unset in those) Jan 24 14:59:15 FinboySlick: it has to be CONFIG_NET_ACT_GACT=y. Jan 24 15:00:21 mkresin: Not in package/linux/modules/netsupport.mk Jan 24 15:00:44 Or do you mean I can't add it to the existing kmod-sched package as a module? Jan 24 15:03:48 Basically, I want to do exactly what this commit did: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=17c90e94cf1df8c28613cdc85f9fc8939d993014 But for CONFIG_NET_ACT_GACT Jan 24 15:13:30 FinboySlick: CONFIG_NET_ACT_GACT while result in CONFIG_NET_ACT_GACT=m and you will need to package the act_gact.ko Jan 24 15:14:33 mkresin: That's what I expected to happen. But that's not what happens. No file act_gact.ko gets built. Jan 24 15:15:12 I suspect that the issue is that I am using the sdk and not a git tree. Jan 24 15:15:25 FinboySlick: works for me with master. no idea about the SDK. but if you have to patch core code, you should compile from source anyway Jan 24 15:16:14 I just want a package with act_gact.ko that I can install on an existing 17.01.4 deployment. Jan 24 16:22:19 mkresin: Do you know which part of the build system (in master) causes CONFIG_NET_ACT_GACT=m to be added where needed when CONFIG_NET_ACT_GACT is added to netsupport.mk? If it's something broken with the sdk, I'm more than willing to fix it. Jan 24 16:41:13 FinboySlick: you can't package/build vanilla kernel modules with the SDK, just external modules Jan 24 16:41:59 KanjiMonster: btw, your script creates a file named "0" on line 15 Jan 24 16:44:18 KanjiMonster: Well, that settles one thing. Do you have a trick for making a release-matching module using the git tree? eg: Figure out the specific commit of a release, then building that? Jan 24 16:45:21 FinboySlick: you can't. building a module will change the kernel config, will make them incompatible with the release (from an opkg stand-point) Jan 24 16:49:11 KanjiMonster: Thank you, btw. I might have spent another 3 days hammering at this. So basically, any use case that deviates from the release kernel means mantaining your own tree forever? Jan 24 16:49:52 Well, assuming the deviation isn't something that is generic enough to be included in a following release. Jan 24 16:50:07 FinboySlick: alternatively upstreaming your changes ;-). But yes, if you need to change the kernel config, then you are doomed to maintaining your own tree Jan 24 16:51:18 well, you could also go the compat-drivers approach and try to package and build it as an external module Jan 24 16:51:38 not sure how viable that is Jan 24 16:52:38 KanjiMonster: I think part of my issue is that in my mind, OpenWRT/LEDE is an embeded networking swiss-army-knife. I want a device that does some specific network operation and never have to touch it again. Whereas the development focus seems to be geared more towards the home gateway kind of deal. Jan 24 16:53:43 I'd love for a complete set of iproute2/tc/bridge/netfilter tools. What's there is good, but I always end up building 90% of a solution to find out that there's this one kernel option that wasn't checked out. Jan 24 16:53:45 one of the finer points of the name "LEDE" was to get away from the focus on gateway devices, to make it more generally embedded Jan 24 16:54:02 while we are now back to OpenWrt, the generic idea still stands Jan 24 16:54:33 KanjiMonster: So it may be easier to integrate core functionality now? I'm perfectly happy to submit patches. Jan 24 16:55:17 also even OpenWrt (old) had support for devices like raspberry pi, which is quite far from a gateway device Jan 24 16:55:54 Im my case, GACT is to allow tc to 'drop'. Which is pretty damn basic when it comes to general TC use. iproute2 bridge is similarly crippled for lack of vlan filtering. Jan 24 16:57:37 I understand that these aren't commonly used in home gatways so I wouldn't really expect them to be part of the base install, but those modules should exist. (vlan filtering is a bit different because it has to be included in kernel since bridge generally is) Jan 24 17:03:50 feel free to submit patches / do PRs. Just don't put everything into one patchset / PR, try to keep them logically contained. The less patches/commits, the easier to review. Jan 24 18:08:53 KanjiMonster: Yeah. Most of what I need is very simple and standard so that should be easy. **** ENDING LOGGING AT Thu Jan 25 03:00:05 2018