**** BEGIN LOGGING AT Fri Dec 20 03:00:11 2019 Dec 20 06:29:09 stintel: it's Git not git :] Dec 20 06:31:27 anyway, I'm open to suggestions, how to sum 20 different commits into subject < 50 chars Dec 20 07:08:03 blogic: jow: Hauke: I'm planning to update fstools in 19.07, fstools log: https://git.openwrt.org/?p=project/fstools.git;a=shortlog , 19.07 is currently at 6a61b9ac105b ("probe: fallback to libblkid.so.1 when libblkid.so does not exist") Dec 20 07:08:08 I have two options for 19.07: 1) switch to the latest master 2) create openwrt-19.07 branch with important fixes only Dec 20 07:08:10 so the question is: do we have anything unsafe/experimental in the master branch of fstools? Dec 20 07:08:46 this sounds like something we should include in 19.07: 4327ed40d96c ("mkdev: Avoid out of bounds read") Dec 20 07:09:13 blkid_probe_set_utf8label() is a feature but safe to include too Dec 20 07:10:22 i want all my recent commits too Dec 20 07:10:32 so it's only a matter of those Yousong Zhou's commits Dec 20 07:10:39 are they safe to include in 19.07? Dec 20 07:13:42 IIRC those are mostly fixes as well Dec 20 07:14:54 BTW I don't know if you missed my email about https://git.openwrt.org/?p=project/fstools.git;a=commit;h=f43a1aa6655b702e690179130b3c3fe40b73aaa2 Dec 20 07:15:30 it's missing SoB + it would be nice to get rid of those 0x05/0xE5 magic numbers Dec 20 07:17:01 ah, you've already commited it Dec 20 07:19:49 http://lists.infradead.org/pipermail/openwrt-devel/2019-December/020699.html Dec 20 07:32:13 ynezz: what the heck, i didn't get your e-mail? Dec 20 07:33:53 ynezz: uh, gmail... https://i.imgur.com/ZNhBswe.png Dec 20 07:35:30 ynezz: that commit/patch is a port of upstream one, it was upstream linux-utils / libblkid that has commit without SoB Dec 20 07:35:54 i'm not sure if/how I could handle it better Dec 20 07:38:25 I'm not a FS guy :) but some if byte == FAT_FOO then byte == FAT_BAR Dec 20 07:38:47 so one doesnt need to consult commit description in order to understand the code Dec 20 07:39:40 yeah, I spam a lotg Dec 20 07:42:45 ynezz: if you have a moment for that, can you send linux-utils patch adding a proper #define-s ? Dec 20 07:42:58 then we could pick it to our copy of libblkid Dec 20 07:43:03 that would help keeping similar code base Dec 20 07:43:37 uh, one of those Yousong changes depends on libubox commit 301303911dde ("vlist: add more macros for loop iteration"), so I'd need to update libubox in 19.07 first Dec 20 07:44:05 we're going to update libubox anyway Dec 20 07:44:35 we need to backport those ucert,ubus,libubox changes I've sent yesterday up to 18.06 Dec 20 07:45:10 I'm about to leave, will be back on Sunday/Monday Dec 20 07:45:55 * PaulFertser literally remembers 0xE5 constant from the DOS programming days when he was a school kid Dec 20 08:04:56 build #174 of ath79/tiny is complete: Failure [failed images] Build details are at http://buildbot.openwrt.org/master/images/builders/ath79%2Ftiny/builds/174 blamelist: Karl Palsson , Maxim Anisimov , Lech Perczak , Petr ?tetiar , Christian Lamparter Dec 20 08:04:56 , Ansuel Smith , Rafa? Mi?ecki , Adrian Schmutzler , Paul Fertser , Pavel Kubelun , Michal Cieslakiewicz **** BEGIN LOGGING AT Fri Dec 20 17:24:36 2019 Dec 20 18:50:06 How are packages built from git supposed to know their version if .git/ is removed when creating an archive? Dec 20 19:28:40 jow: hrrm I've had no luck attempting to contact the lantiq maintanec, bug task #2667 you previously discussed a bit with me very helpfully.... any hints? Dec 21 00:07:12 so iputils was moved into packages Dec 21 00:07:16 but im not seeing any of it in config Dec 21 00:07:24 seems like something is not quite right there Dec 21 00:14:54 nyt: make menuconfig and then / to search? Dec 21 00:15:13 doesnt show up Dec 21 00:16:52 feeds/packages/net/iputils has the files from 12/10 Dec 21 00:23:29 the only place iptools.sh shows up for me grepping around is in the unbound package Dec 21 00:24:19 what is iptools? Dec 21 00:25:26 nyt: do you mean iputils? Dec 21 00:26:06 I never said iptools Dec 21 00:26:07 i said iputils Dec 21 00:27:11 oh, right Dec 21 00:27:13 sorry Dec 21 00:28:08 did you scripts/feeds update -a ; scripts/feeds install -a ? Dec 21 00:28:14 yep Dec 21 00:29:08 Updating feed 'packages' from 'https://git.openwrt.org/feed/packages.git' ... Dec 21 00:29:08 Already up to date. Dec 21 00:29:14 [nyt@cc:~/archive/openwrt/x86]: ./scripts/feeds install -a Dec 21 00:29:15 WARNING: Makefile 'package/feeds/packages/backuppc/Makefile' has a dependency on 'iputils-ping', which does not exist Dec 21 00:29:15 etc Dec 21 00:29:50 just doesnt show up in menuconfig Dec 21 00:30:06 * russell-- trying to replicate Dec 21 00:30:47 indeed - I've seen for the past few days WARNING: Makefile 'package/feeds/packages/backuppc/Makefile' has a dependency on 'iputils-ping', which does not exist Dec 21 00:31:05 so iputils as a package is broked Dec 21 00:34:56 there is something in the packages feed in net/iputils Dec 21 00:35:47 but i'm not seeing it in menuconfig either, nor is the symlink showing up in package/feeds/packages Dec 21 00:36:03 so, seems like Makefile is busted somehows Dec 21 00:38:47 missing include? Dec 21 00:38:58 for package.mk? Dec 21 00:39:00 * nyt just glancing quick Dec 21 00:43:53 that does seem to help, feeds install -a saw it Dec 21 00:45:13 yeah, adding include $(INCLUDE_DIR)/package.mk in the Makefile, running scripts/feeds install -a and it shows up in menuconfig now Dec 21 00:58:18 there was one in there already Dec 21 00:58:31 so i don't know what happened Dec 21 02:13:57 russell--: install -f worked for me during testing **** ENDING LOGGING AT Sat Dec 21 02:59:58 2019