**** BEGIN LOGGING AT Wed Oct 28 02:59:57 2020 Oct 28 05:27:34 >KGB-0< https://tests.reproducible-builds.org/openwrt/openwrt_tegra.html has been updated. (0% images and 100.0% packages reproducible in our current test framework.) Oct 28 06:42:22 morning Oct 28 06:48:47 * enyc meow nitroshift Oct 28 06:49:04 * nitroshift barks Oct 28 06:49:06 :)) Oct 28 07:36:10 nbd, mail sent, please let me know if it reached you Oct 28 07:53:13 nitroshift: yep, it arrived, thanks Oct 28 08:01:00 nbd, hope it's ok. wouldn't have made it without rsalvaterra's help Oct 28 08:19:10 can someone help me convert this slightly complicated vlan config to current DSA language? https://pastebin.com/4j8UTyFX Oct 28 08:37:02 'morning! Oct 28 08:39:08 Today I woke up thinking… do you guys have some procedure as to how to rebase conflicting patch files, or is it as horrible as I imagine it to be? :P Oct 28 08:39:16 (It hasn't happened to me… yet…) Oct 28 08:42:29 * nitroshift hands rsalvaterra a mug of hot coffee Oct 28 08:42:32 morning Oct 28 08:43:51 nitroshift: I'm actually having coffee as we speak. :P Oct 28 08:44:22 Have you been able to configure git-email? :) Oct 28 08:44:26 yep Oct 28 08:44:36 this morning Oct 28 08:44:55 yahoo changed their security mechanisms Oct 28 08:45:13 but managed to do it eventually Oct 28 08:46:19 * nitroshift lets the cat in stintel's bedroom Oct 28 08:46:20 Great! Now you can send patches by email. Like everything in life, it's easy when you know how. :) Oct 28 08:47:00 and it's even easier when someone with more experience guides you Oct 28 08:47:20 brb, cigarette time Oct 28 08:50:09 git send-email is pretty neat :) Oct 28 08:51:38 Borromini: It's magic. But hard to grasp for a git beginner, for sure. Oct 28 08:55:56 well once you set your git config... Oct 28 08:56:01 sure, you need to read a bit Oct 28 08:56:19 * Borromini is looking at one of those realtek switches with PoE Oct 28 09:02:54 Borromini: https://biot.com/switches/models this? Oct 28 09:04:01 damex: yeah although that is apparently a list of possible targets Oct 28 09:04:56 looking at the zyxel gs1900-8hp Oct 28 09:05:23 Borromini: are you sure it has the same switch inside? there is just GS1900-10HP Oct 28 09:06:30 damex: no, good point, that's not the 10 port i'm looking at... Oct 28 09:06:38 i really want to replace my ubnt edgeswitch 8 150w with one of that switches (as long as it runs openwrt) Oct 28 09:06:53 but es8 is kinda LARGE Oct 28 09:07:27 :) Oct 28 09:07:58 i'm still debating what to do best since i'll need a few PoE ports for APs, but i'm doing the wiring in the new place (there's nothing when it comes to network cabling) Oct 28 09:08:00 I just wanted a 16-port multigig layer-3 smart switch which didn't cost an arm and a leg… Oct 28 09:08:10 rsalvaterra: and you didn't find it? :P Oct 28 09:08:18 actually 2.5L is not that bad but pretty sure it could be smaller if we use more efficient soc and oversubscribe poe ports a bit Oct 28 09:08:55 Borromini: is poe is 24v - edgerouter x sfp might fit ;p Oct 28 09:09:09 just for power for APs Oct 28 09:09:21 =) Oct 28 09:09:38 i'm looking at the er4 as edge router Oct 28 09:09:39 s/is poe/if poe/ Oct 28 09:09:44 oh you Oct 28 09:10:02 it is not merged yet and have no idea when it will be Oct 28 09:10:20 but the er-x has too few ports to do switching really, i'd rather have a beefier edge router and an l2 switch behind for the remainder Oct 28 09:10:45 damex: no but pr is pending i saw, thanks for the work :) Oct 28 09:10:54 Borromini: you're actually waiting for damex to merge er4 support so you can buy one? :P Oct 28 09:11:22 > 61 comments Oct 28 09:11:32 yeah... pending Oct 28 09:11:34 rsalvaterra: the pr looks pretty solid from where i stand (no coding experience beyond scripting though) so that's good enough for me :P Oct 28 09:11:43 comment* Oct 28 09:11:51 damex: depending on whose cup of tea it is it might take a while, really depends. Oct 28 09:12:15 what i am wondering though: how's octeon's path into the future looking? Oct 28 09:12:19 Borromini: if we don't give up half way - there might be er6p and er12 + er12p support too Oct 28 09:12:50 Borromini: well, only changes are accepted that not the ones that improve Oct 28 09:13:01 so dunno for now Oct 28 09:13:02 i thought i saw someone say octeon as an architecture might be dropped by cavium or marvell (who seems to own them now)? Oct 28 09:13:10 damex: ok. Oct 28 09:13:17 they make arm octeons now Oct 28 09:13:38 is this one mips? Oct 28 09:13:42 mips64 Oct 28 09:13:44 ok :) Oct 28 09:14:57 it is actually looks like a dead end. lots of octeon devices have poor vendor support and target is pretty known on how it behaves and what is needed to get it working Oct 28 09:15:30 so providing openwrt for them might be a good choice ;p Oct 28 09:16:18 :P :P Oct 28 09:31:58 marvell obviously bought cavium for the name, all they did is rebranding their armada 4080 (ARMv8) as cavium and letting octeon die Oct 28 09:32:55 was cavium that successful? Oct 28 09:36:12 blocktrron: ping Oct 28 09:36:59 good question, but they seem to embrace it Oct 28 09:40:19 cavium3 is still in production under the marvell name Oct 28 09:40:41 s/cavium3/octeon3/ Oct 28 09:57:20 damex: Does the octeon on er4 have SIMD? Oct 28 09:58:34 Borromini: bear in mind that PoE switches with more than 8 powered ports usually have a built-in PSU and fans. Loud fans. Oct 28 10:01:29 rsalvaterra: it is not reflected in cpuinfo but architecture support that Oct 28 10:02:16 it also has fpu but it is not enabled on octeon target yet Oct 28 10:03:03 This is (informed) speculation, but can't imagine the er4 being faster than, say, an APU2D4. Oct 28 10:03:23 https://biot.com/switches/models GS108Tv3 does not have its own entry... i wonder if v2 and v3 is the same (or similar) Oct 28 10:03:43 rsalvaterra: intel nics help ;p Oct 28 10:04:16 Especially if you use it as a VPN endpoint. Oct 28 10:04:45 damex: The er4 has Intel NICs too? Oct 28 10:05:01 rsalvaterra: no, it is not Oct 28 10:05:05 it helps apu2d4 ;) Oct 28 10:05:15 Ah, you were referring to the APU. :) Oct 28 10:05:54 since they're on pci-e lane and not directly from soc - you might have higher chances balancing irqs Oct 28 10:06:50 but am not so sure about GX-412TC VS 7130 Octeon performance Oct 28 10:08:51 damex: the GS108Tv3 has the same Netgear FW as the GS110TPv3 and GS110TPP Oct 28 10:09:43 damex: but I only have the GS110TPP, so no pages for the other ones. The GS108Tv2/v1 don't have Realtek chips as far as I can tell. Oct 28 10:10:05 any idea about GS110TP-200EUS ? Oct 28 10:11:49 checking what local retail have available ;p Oct 28 10:11:59 If that corresponds to the GPL sources for the GS110TP: "netgear platforms(BCM5331x series) like gs110t and gs510tp" Oct 28 10:12:13 damex: I can't even find infomation about which MIPS64 revision the 7130 implements. Oct 28 10:12:18 *information Oct 28 10:12:56 rsalvaterra: it goes up to mips64r2 in cpuinfo while specs say mips64r3 Oct 28 10:13:19 oh broadcom instead of soc is no go Oct 28 10:13:37 So, not MIPS64r6, sadly. Oct 28 10:14:29 that is if i get it right from specs... looking for that doc again Oct 28 10:14:52 Oh, but if it's really r3, it should support microMIPS. Oct 28 10:15:23 That would at least help a bit, since the 7130 has a measly 512 kiB of l2$. Oct 28 10:16:17 rsalvaterra: yeah, mips64r3 Oct 28 10:16:19 https://www.marvell.com/products/infrastructure-processors/octeon-iii-cn7xxx.html Oct 28 10:17:24 Quad-channel RAM? Am I reading this right? Oct 28 10:18:48 rsalvaterra: depends on model i guess. er4 have two H5TQ4G63CFR-RDC Oct 28 10:19:55 so we're currently trying to add support for er4 to Oct 28 10:20:07 fpu and other stuff is planned as an improvement Oct 28 10:20:28 I guess we can forget about the Neuron accelerator… :P Oct 28 10:20:31 if it brings something to the tablet (routing?) Oct 28 10:20:58 rsalvaterra: it is actually very specific in patches and there a public patches that implement offloading and other features Oct 28 10:21:22 we might add that (or try to upstream it) Oct 28 10:33:02 rsalvaterra: whats up Oct 28 10:36:58 blocktrron: If I correctly read your hostapd commits, now all -full variants are built with support for 802.11u, is that true? :) Oct 28 10:42:54 yes Oct 28 10:44:04 Hmm… Oct 28 10:45:03 In that case, I really want to make a hostapd-basic-openssl (because I'm stuck with openssl for tor and stubby)… Oct 28 10:45:42 Shouldn't 802.11u be part of the -hs20 variants only? Oct 28 10:52:31 HS2.0 uses a subset of 802.11u Oct 28 10:52:37 No, the other way around Oct 28 10:53:28 Anyways, I don't see a benefit in the hs20 variant at all. If we continue doing this we end up with a million build variants Oct 28 10:54:28 blocktrron: i would love to see all this be part of hostapd-full, however, i didn't manage to build wpad-full with hs20 features enabled, and it also only worked with openssl... Oct 28 10:54:48 blocktrron: if building wpad-full with hs20 and 11u works, we can safely drop hostapd-hs20 Oct 28 10:55:21 dangole: *sigh* let me check Oct 28 10:55:40 someone queried me yesterday informing me that wpad fails to build with my first patch Oct 28 10:56:15 however I've pushed a fix which fixed that for me. wpad-full-wolfssl is the troublemaker? Oct 28 10:57:20 blocktrron: internal crypto failed as well and apparently some weird symbol overlap when building wpad multicall Oct 28 11:00:38 dangole: gimme a sec, I'm building wpad-wolfssl rn Oct 28 11:05:33 Ouch. Sorry for opening the tin of worms. :P Oct 28 11:06:44 But the WirelessAPD section is a horrible mess… Oct 28 11:07:48 rsalvaterra: well, not just that WirelessAPD section, but also hostapd itself... Oct 28 11:12:11 blocktrron: I know hs20 is a subset of 802.11u, what I meant is there should be a -80211u variant, not -hs20. Maybe this would make more sense. :) Oct 28 11:13:25 rsalvaterra: 802.11u is much older than hs20, hs20 supersedes 802.11u Oct 28 11:14:23 blocktrron: i'm assuming DPP is also needed in practice for hs20 Oct 28 11:16:31 dangole: i only came for the ESR flag, so i cannot say much about hs2.0 Oct 28 11:17:32 Okay, wpad-wolfssl builds fine. I assume wpad-full w/o/ crypto is where things went south Oct 28 11:25:08 dangole: hmm, wpad-wolfssl as well as wpad w/o ssl build fine on master Oct 28 11:42:28 blocktrron: nice. i saw some linker breakage when i was working on it some months ago Oct 28 11:42:57 blocktrron: feel free to drop hostapd-hs20 then, but please also add CONFIG_DPP to the full variant Oct 28 11:43:38 And speaking of wolfssl, it builds and runs just fine with MIPS16. I don't know why it was disabled, but I guess probably some bugged gcc version. Oct 28 11:45:07 dangole: I'll look into that in the coming days Oct 28 11:45:45 blocktrron: thanks for cleaning this up! Oct 28 11:46:31 rsalvaterra: the state of MIPS toolchain is in a shockingly bad condition. the recent mips64 fallout opened my eyes on how bad it is... Oct 28 11:47:44 802.11w in LuCI seems bust - does not appear when I have wpad-wolfssl installed Oct 28 11:47:47 Yeah, I can imagine… Oct 28 11:47:49 Have to do a: Oct 28 11:47:50 uci set wireless.default_radio0.ieee80211w="1" Oct 28 11:47:50 uci set wireless.default_radio1.ieee80211w="1" Oct 28 11:47:50 uci commit wireless Oct 28 12:16:01 damex: if you're in for a challenge, there's also Cisco Meraki switches that use a Vitesse SoC. We're nowhere near starting with another target after RTL83xx, but it seemed like an interesting next platform (with actual useful datasheets available) Oct 28 12:16:56 and possibly upstream support, there are some vitesse switch chips supported in the kernel Oct 28 12:17:29 stintel: yeah, i have seen that. vitesse phy is used on er4/6p/12/12p Oct 28 12:18:11 it is actually microsemi now which is acquired by microchip Oct 28 12:18:25 so probably it is called microchip in kernel Oct 28 12:18:34 still called vitesse afaik Oct 28 12:18:47 well, kernel driver/module is no longer a vitesse ;( Oct 28 12:19:04 I've search for vsc74xx and vsc75xx (the switch SoCs), but couldn't really find much Oct 28 12:19:26 some vsc85xx phy parts are though, IIRC Oct 28 12:19:32 drivers/net/dsa/vitesse-vsc73xx* Oct 28 12:19:46 and drivers/net/dsa/ocelot/* Oct 28 12:20:20 stintel: thanks, using codenames doesn't make stuff easier to find :-/ Oct 28 12:20:57 well I happen to have been messing around with devices with a vsc9953 chip ;) Oct 28 12:21:08 those WatchGuard/PPC thingies Oct 28 12:21:19 svanheule[m]: i guess it is no go for me for now. no hardware and all i wanted originally is to downsize homelab. i thought about selling er4 but managed to make openwrt to run there. same goes for aircube ac ;p Oct 28 12:21:36 downsize homelab o_O Oct 28 12:21:57 stintel: not everyone wants a 19" rack in their house Oct 28 12:22:08 * stintel hides Oct 28 12:22:18 :P Oct 28 12:22:47 stintel: I found 802.3bt switches with Realtek hardware btw Oct 28 12:22:54 but only gigabit ethernet Oct 28 12:23:28 I'm still looking for 802.3bt PoE-PD 10GbE uplink and preferably a few more 10GbE ports Oct 28 12:23:40 like 4x10GbE and 8x1GbE would be epic Oct 28 12:25:30 so i sold synology ds1819+ and currenly wait for ds620slim to arrive (6x5T drives). 2x low power Nuc with 16 and 32gb ram + 9x RPI/LibreComputer SBCs + 2x EdgeSwitch 8 150w + EdgeRouter 4 + EdgeRouter X + AirCube AC. EdgeSwitch is a huge Pita. takes lots of space and it is heavy Oct 28 12:27:02 stintel: do you expect it to be L3 ? :) Oct 28 12:27:27 damex: no need for that Oct 28 12:28:51 i heard very good stuff about https://www.ruckussecurity.com/ICX-7150-C12P.asp Oct 28 12:29:47 damex: my huawei does wirespeed 10GbE L3 ;) Oct 28 12:30:27 how many 10GbE ports you have there ? Oct 28 12:32:03 svanheule[m]: actually it is not about <19' rack at home> - it is about changing jobs every 1 or 2 years and travel to other country (or change apartments in between). i prefer to keep all the hardware Oct 28 12:32:21 no way i am moving to another country with 19' rack Oct 28 12:32:33 but <20L homelab? doable Oct 28 12:32:42 even <10L maybe Oct 28 12:37:51 haha yeah if I need to move I'm going to have fun Oct 28 12:38:32 dangole: decided to replace the busybox ntpd functionality with chrony so that i can use its nts feature, also replaced dnsmasq with unbound so that i can use some of its advanced features like dot, router setup is pretty neat now Oct 28 12:38:37 but not planning on doing that anytime soon. as long as they don't touch the 10% tax I'll be here Oct 28 12:39:32 grift: do not need other dnsmasq features? atleast tftp/dhcp? Oct 28 12:39:55 i let odhcpd also do ipv4 dhcp Oct 28 12:40:14 and i dont use tftp, so not sure yet if i am missing out there Oct 28 12:41:38 i boot that SBCs over network. pxe use tftp to pull kernel+initrams (or just kernel, depends) Oct 28 12:42:07 i bet one can make tftp work without dnsmasq Oct 28 12:42:12 yeah, sure Oct 28 12:42:30 grift: what made you choose to use odhcpd for dhcp4? Oct 28 12:43:19 well i wanted to use unbound dot , and the how to said either disable dnsmasq dns or remove it althother and use odhcp for ip4 dhcp Oct 28 12:43:36 so i just removed it Oct 28 12:43:43 less is more Oct 28 12:48:30 so i now have pretty much the ultimate setup and the selinux policy supports it: https://termbin.com/jcj5 Oct 28 12:48:52 added wireguard vpn, and tightened selinux: Oct 28 12:49:04 root@OpenWrt:~# setenforce 0 Oct 28 12:49:13 setenforce: setenforce() failed: Permission denied Oct 28 12:49:32 [ 2399.981265] audit: type=1400 audit(1603889336.615:5): avc: denied { setenforce } for pid=5735 comm="setenforce" scontext=u:r:sys.subj tcontext=u:r:selinux tclass=security permissive=0 Oct 28 12:49:38 no mor fun and games Oct 28 12:58:02 ntp nts is also pretty neat, i was basically reading this: https://fedoramagazine.org/secure-ntp-with-nts/ and then i saw this: https://github.com/openwrt/packages/commit/65d37343587cd5c23ed8fff765f210773293750e Oct 28 12:58:44 so i just had to do it Oct 28 13:00:00 thus yanked out the ntpd support from busybox and went with chrony Oct 28 13:00:20 and thats what i like about openwrt Oct 28 13:00:27 grift: why not dnsdist (powerdns) for doh ? :) Oct 28 13:00:39 too complex / requires boost and all Oct 28 13:00:48 unbound is superior Oct 28 13:01:54 hello, anyone here involved with the Prpl Foundation that I could ask some questions about it? Oct 28 13:02:42 because as I understand it is supposed to make OpenWrt more usable by network equipment OEMs and such Oct 28 13:13:22 but otherwise i would like into knot-resolver, see what it can do Oct 28 13:13:38 i use knot as my dns server and very happy with it Oct 28 13:14:12 decisions decisions Oct 28 13:14:53 we have here powerdns+dnsdist - we're gonna split part of the company to its own infra and need to decide what to use. pdns+dnsdist will make things overly complicated in a current setup. Oct 28 13:15:19 been thinking about automating unbound+bind Oct 28 13:15:32 look into knot Oct 28 13:17:47 same people that made bird? Oct 28 13:18:51 yes i guess (same org at least cz.nic) Oct 28 13:20:25 thanks, never heard about that one. would be happy to ditch powerdns + postgresql setups Oct 28 13:22:11 do we need to pick this in mac80211? https://patchwork.kernel.org/project/linux-wireless/patch/20201019160113.350912-1-Mathy.Vanhoef@kuleuven.be/ Oct 28 14:02:26 [3663919.981117] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen Oct 28 14:02:32 meh. filesystem ro Oct 28 14:04:33 have someone tried edgerouter 10x ? i wonder if it is oversized edgerouter x Oct 28 14:05:11 nasty Oct 28 14:05:16 how come? Oct 28 14:05:20 that's a miniPCIe SSD in the APU2 :/ Oct 28 14:05:43 stintel: bad mpcie ssd? Oct 28 14:05:51 stintel: mSATA usually Oct 28 14:06:35 build #608 of mediatek/mt7623 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/mediatek%2Fmt7623/builds/608 Oct 28 14:09:25 svanheule[m]: you sure it's mSATA ? Oct 28 14:09:37 you're right Oct 28 14:09:51 cool. I have a "spare" 256GB mSATA somewhere Oct 28 14:10:15 :-) Oct 28 14:10:51 I've once used an APU to recover data from the mSATA SSD built into a Samsung T3 portable SSD :P Oct 28 14:21:43 what am I going to do with all this extra storage though :P if I replace 16GB with 256GB :P Oct 28 14:24:08 i already have that with 256mb flash on my router (currently 59MiB sitting there empty going to waste) Oct 28 14:25:07 pi-hole container seems to use almost 5GB (including logs) Oct 28 14:26:07 stintel: 16 GB on an APU, for OpenWrt? Oct 28 14:26:34 rsalvaterra: well that was the smallest SSD PCengines offered Oct 28 14:27:40 I have a 16 GB SLC SSD in the APU at the office. It's complete overkill, let alone 256 GB. :) Oct 28 14:28:21 grift: remember that this is NAND flash, so having some spare blocks for wear leveling and to replace bad blocks before shit hits the fan is a good idea... Oct 28 14:28:59 dangole o right Oct 28 14:29:36 rsalvaterra: well with my pi-hole container some of it is not wasted Oct 28 14:30:05 especially for me , this router is less than a month old and must have reflashed it over a 1000 times already Oct 28 14:30:23 i finally got procd-ujail + uxc ready to replace 'runc' or 'crun' well enough for podman to work :) Oct 28 14:30:26 heck i bricked in less than 15 minutes after it was delivered Oct 28 14:30:29 stintel: Why a container with pi-hole? Have you tried banip? Oct 28 14:31:43 dangole: Ah, forgot to ask you! Is ntpd supposed to run with uid 123 all the time, or only with jails? Oct 28 14:32:40 rsalvaterra: never heard of banip Oct 28 14:33:19 and a container because pihole is not properly packagable Oct 28 14:33:20 https://github.com/openwrt/packages/blob/master/net/banip/files/README.md Oct 28 14:34:13 ok not entirely the same Oct 28 14:34:46 rsalvaterra: it can do it only with ujail because that's needed to retain ambient capabilities. without that it'd need to run as root. hance the logic in the init script detecting /sbin/ujail Oct 28 14:34:51 True. For ads: https://github.com/openwrt/packages/blob/master/net/adblock/files/README.md Oct 28 14:35:21 rsalvaterra: but does it come with fancy graphs :) Oct 28 14:35:33 dangole: I see, thanks for the explanation. :) Oct 28 14:36:27 stintel: Right, I forgot you like pretty GUIs. :P Oct 28 14:36:38 rsalvaterra: for stats I do Oct 28 14:37:23 but I might cook something myself and build a grafana dashboard for it Oct 28 14:37:31 I had rrdtool running on the APU at the office. It was cute. :) Oct 28 14:37:32 if I ever find time :P Oct 28 14:40:46 Ok, so I implemented ADC entropy collection for AR5008-AR9002 (ath9k) on Linux 5.10-rc1… now I just need to test this on the AR5008 I ordered yesterday… Oct 28 14:40:58 … and find the courage/patience to send it upstream. :P Oct 28 14:45:10 rsalvaterra: nice work! does that entropy collection start right after probing the hardware or does the interface have to be up for that? Oct 28 14:45:25 (While also addressing nbd's concerns, like having the AR_PHY_TST_ADC register all the time configured for I/Q sampling.) Oct 28 14:46:43 dangole: It works just like on AR9003. It spawns a kthread which reads the sample register as needed, until the entropy pool reaches a certain threshold, then blocks until the entropy pool drops below another threshold. Oct 28 14:48:31 But to answer your question, the radio must be up. It doesn't have to be associated. Oct 28 14:49:36 rsalvaterra: was asking because was wondering if that helps key generation on firstboot... especially now that we might generate both, SSH and TLS keys.... Oct 28 14:50:13 I'm… sorry. :P Oct 28 14:50:54 rsalvaterra: is having a monitor interface up enough? Oct 28 14:51:10 dangole: Haven't tested that. Oct 28 14:51:45 Do you want to give it a spin yourself? I can send you the patch. :) Oct 28 14:51:49 because that wouldn't hurt much to just do as soon as the radio gets detected... Oct 28 14:51:57 i don't have any ath9k hardware at hand Oct 28 14:52:42 but i'd like to see the patch anyway :) Oct 28 14:52:47 As crazy as it may sound, me neither… Well, apart from my AirGrid M2, which is running my patch perfectly. Oct 28 14:53:32 dangole: Sure! I'll mail it to you. It's against Linux 5.10-rc1. Oct 28 14:54:41 Oh, and AR9001 hardware (Buffalo WZR-HP-AG300H) has also been thoroughly tested by a friend of mine, a couple of months ago. Oct 28 14:59:12 dangole: you've got mail. Oct 28 15:10:36 build #312 of ath79/mikrotik is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/ath79%2Fmikrotik/builds/312 Oct 28 15:12:52 rsalvaterra: thanks Oct 28 15:45:29 dangole: Oh, wait! It doesn't compile! XD Oct 28 15:46:16 (I didn't wait for it to finish building before sending the patch, admittedly.) Oct 28 15:49:10 haha sounds familiar Oct 28 15:50:27 Bah… forgot to delete a line. *facepalm* Oct 28 15:52:47 Don't you just love fixing problems by deleting code? :P Oct 28 16:07:48 build #615 of ramips/rt288x is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/ramips%2Frt288x/builds/615 blamelist: Sven Eckelmann , David Bauer , Daniel Golle Oct 28 16:07:54 build #678 of ath25/generic is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/ath25%2Fgeneric/builds/678 blamelist: David Bauer , Daniel Golle Oct 28 16:08:01 build #678 of octeontx/generic is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/octeontx%2Fgeneric/builds/678 blamelist: David Bauer , Daniel Golle Oct 28 16:08:07 build #673 of oxnas/ox820 is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/oxnas%2Fox820/builds/673 blamelist: David Bauer , Daniel Golle Oct 28 16:08:14 build #534 of mpc85xx/p2020 is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/mpc85xx%2Fp2020/builds/534 blamelist: David Bauer , Daniel Golle Oct 28 16:08:20 build #664 of at91/sam9x is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/at91%2Fsam9x/builds/664 blamelist: David Bauer , Daniel Golle Oct 28 16:08:26 build #491 of ipq40xx/generic is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/ipq40xx%2Fgeneric/builds/491 blamelist: David Bauer , Daniel Golle Oct 28 16:08:32 build #496 of sunxi/cortexa8 is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/sunxi%2Fcortexa8/builds/496 blamelist: David Bauer , Daniel Golle Oct 28 16:08:38 build #547 of x86/legacy is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/x86%2Flegacy/builds/547 blamelist: David Bauer , Daniel Golle Oct 28 16:08:44 build #511 of mxs/generic is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/mxs%2Fgeneric/builds/511 blamelist: David Bauer , Daniel Golle Oct 28 16:08:51 build #539 of lantiq/xrx200 is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/lantiq%2Fxrx200/builds/539 blamelist: David Bauer , Daniel Golle Oct 28 16:08:57 build #579 of mvebu/cortexa9 is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/mvebu%2Fcortexa9/builds/579 blamelist: David Bauer , Daniel Golle Oct 28 16:09:03 build #528 of octeon/generic is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/octeon%2Fgeneric/builds/528 blamelist: David Bauer , Daniel Golle Oct 28 16:09:09 build #600 of at91/sama5 is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/at91%2Fsama5/builds/600 blamelist: David Bauer Oct 28 16:09:16 build #524 of ath79/generic is complete: Failure [failed] Build details are at http://buildbot.openwrt.org/master/images/builders/ath79%2Fgeneric/builds/524 blamelist: David Bauer Oct 28 16:09:30 \o/ Oct 28 16:15:35 Ye, gods! Oct 28 18:24:05 https://gist.github.com/damex/010880e0ecf08a432551e115acc6eed1 that is how i am trying to add interface rename by label. https://gist.github.com/damex/75510a0a7ee6ad0627af6fb676cec94e this is the log get. what am i doing wrong or maybe i am missing something? it attempts to rename interface to a correct one but says that correct one is unintialized Oct 28 18:24:54 i have used dev_change_name to rename interface Oct 28 18:27:24 damex: have you seen that after the error the rename appears to be working (15-16s)? or is that the script? Oct 28 18:27:34 adrianschmutzler: that is the script Oct 28 18:37:03 i will try allocating that device name first before actually doing rename Oct 28 18:40:46 why is device_rename even reached inside dev_change_name? Oct 28 18:43:16 what do you mean why is device_rename reached? Oct 28 18:43:57 forget it, I misread the strncmp condition Oct 28 18:45:42 adrianschmutzler: so i need to allocate device name first (one to rename to) Oct 28 18:45:47 it works now ;p Oct 28 18:46:46 https://gist.github.com/damex/d97c201351625b2c326b5e15e65ae80a Oct 28 18:48:48 okay, but renames are not printed anymore interestingly Oct 28 18:49:09 how's your code looking now? Oct 28 18:49:50 https://github.com/openwrt/openwrt/pull/3531/commits/07f83e616d29e8758e38f7db53cad600cab50485#diff-588509975c156eb9ea416eb8eab80141f0fd9c0030078c8b0ba2ef7f8a54cd11R21-R24 Oct 28 18:50:23 Will it also work if you just alloc and drop rename? Oct 28 18:50:45 I assume you actually run into the strncmp with return 0 ... Oct 28 18:51:15 lets see if dropping rename possible Oct 28 18:53:25 looks like dev_alloc_name is just a more complex variant of the strlcpy(eth->netdev[id]->name, name, IFNAMSIZ); from mt7621 Oct 28 18:55:09 I assume that Oct 28 18:55:11 ret = __dev_alloc_name(net, name, buf); Oct 28 18:55:17 if (ret >= 0) Oct 28 18:55:41 essentially does the same as the "if (name)" for mt7621? Oct 28 18:59:07 seems so Oct 28 18:59:16 adrianschmutzler: so just allocating device name is enough Oct 28 19:00:08 That's nice, I think this is a better solution and since mt7621 does the same, it should acceptable although it's essentially a hack. Oct 28 19:00:43 so it does initialization for 4 interface device per qsgmii without even checking for node state. i wonder if there is a way to tell it to not do that? Oct 28 19:00:43 Please add a header to the (kernel) patch, just something short like for the mt7621 one (you probably can just copy-paste the text) Oct 28 19:01:14 sorry, can't help you with that Oct 28 19:02:04 sure, would having just that properly named lan* devices enough to get device in a tree? (without caring about the rest for now, they don't affect anything) Oct 28 19:02:08 I do not know much about ethernet drivers, I'm just reading code in this context Oct 28 19:02:48 what do you mean by "get device in a tree"? Oct 28 19:04:45 adrianschmutzler: like get device support merged. or we definitely need to fix all the possible quirks? basically we need to patch kernel at this point Oct 28 19:05:22 I have no idea whether a patch like that would be acceptable upstream. Oct 28 19:06:08 well, yeah. but am more interested in this context to get device support into the openwrt. Oct 28 19:07:23 I would create a separate (OpenWrt) commit just like https://github.com/openwrt/openwrt/commit/3211c983fd7a51208f22866193df64a009b64fdb Oct 28 19:07:42 in the ER4 PR, just before the commit adding device support Oct 28 19:08:01 adrianschmutzler: sure. Oct 28 19:08:02 that separate commit would just add the kernel patch locally Oct 28 19:08:27 Then add the labels in the device support commit Oct 28 19:09:26 And I would consider that particular issue solved. Oct 28 19:09:55 The problem is that I personally cannot review the entire device support PR Oct 28 19:10:47 What I understand looks okay, but there is a lot that needs to be checked by somebody else. Oct 28 19:12:08 I will have another look during the rest of the week, though Oct 28 19:13:45 the biggest problem will obviously be the kernel config changes, as they might affect other devices which would need to be tested. Oct 28 19:33:39 well, i 'tested' it on edgerouter lite and edgerouter 4. there is just 4 devices in a tree. edgerouter lite, edgerouter and itus shield where 'edgerouter' does not even boot due to lack of needed kernel option to enable board specific hack Oct 28 19:34:13 4 including new edgerouter 4 Oct 28 19:34:27 > 'edgerouter' does not even boot due Oct 28 19:34:41 that is with a current kernel openwrt have. enabling such option degrade performance heavily Oct 28 19:35:34 and you have the "generic" device, which at least was used with some device we don't know Oct 28 19:39:29 adrianschmutzler: it is irrelevant since they can not be #1 flashed, #2 they don't preserve configs #3 they are not listed in compatibility list of openwrt Oct 28 19:40:58 well, I cannot discuss too much about generic devices anyway, they are a concept from before my time here Oct 28 19:41:36 adrianschmutzler: how about that DTS_DIR, could i just use DEVICE_DTS_DIR in Device/Default like other targets do? Oct 28 19:41:57 or i better put DTS_DIR to /Makefile? Oct 28 19:42:18 but it does not matter anyway; somebody will be needed to review your PR anyway, and that one will also review the kernel config changes eventually Oct 28 19:42:38 just keep the same line, and put it _before_ the Device/Default block Oct 28 19:42:56 DEVICE_DTS_DIR does something different than DTS_DIR Oct 28 19:43:21 this is actually considerably complex if you try to disentangle it Oct 28 19:43:49 but since we have a target-wide DTS directory, using DTS_DIR actually seems appropriate to me Oct 28 19:44:03 DEVICE_DTS_DIR is more meant for subfolders and stuff Oct 28 19:44:41 like here: https://github.com/openwrt/openwrt/blob/3f14f034fb5e191f4a537998379d8e922ec31e8a/target/linux/lantiq/image/Makefile#L56 Oct 28 19:44:49 that's what you should do IMO Oct 28 19:45:41 yeah, just did that Oct 28 19:45:49 thanks Oct 28 19:46:52 btw reviewers don't have to be people with commit access; if you find other developers that thoroughly review the code and are willing to provide a Reviewed-by: with their name, this will also help Oct 28 19:48:51 same with Tested-by :) Oct 28 19:49:39 stintel: indeed. Although I would e.g. be willing to merge something I only partially understand with 2 Reviewed-by, but not with 2 Tested-by ... Oct 28 19:49:58 depending on what we are talking about, obviously Oct 28 19:50:03 makes sense Oct 28 19:52:41 completely different subject: Oct 28 19:53:11 is https://github.com/openwrt/openwrt/commit/c9e9b8c342d918cedfc4d2e1c2f7fd1fcaf0b56b no finally fixing the jffs2 problem, so we can finally remove kernel 4.19? Oct 28 19:53:19 no->now Oct 28 21:10:34