**** BEGIN LOGGING AT Mon Feb 15 02:59:58 2021 Feb 15 03:12:37 mangix: what did dango do? Feb 15 03:19:49 nevermind found it Feb 15 03:20:15 lipnitsk: did you test your script somewhere? Feb 15 03:25:05 locally Feb 15 03:25:15 by forcing PKG on a dirty package Feb 15 03:28:12 aparcar[m]: basically tested that a dirty PKG is marked as dirty, but once clean, the script doesn't error. There is a chance that make package/PKG/refresh does not work on some packages, though I did a pass and fixed all of them a week or two ago Feb 15 03:28:53 I think one improvement might be to fail with a different message if make package/$PKG/refresh failed for whatever reason Feb 15 03:29:39 or at least do a || exit $? after make Feb 15 03:34:54 aparcar[m]: I've tested every branch of the script locally and it performs as intended. I also just added the || exit $? to the make command as an improvement Feb 15 03:38:29 aparcar[m]: I've removed dnsmasq before as an experiment. odhcpd works as a DHCP server. The issue is DNS Feb 15 03:41:40 still quite a few build errors related to ubus, "incompatible with the architectures configured" https://pastebin.ubuntu.com/p/ZgY2ssVhZ5/ Feb 15 03:42:15 Cannot satisfy the following dependencies for base-files:libblobmsg-json20201212 Feb 15 03:43:11 tplink,archer-a7-v5, master branch fresh checkout Feb 15 03:43:57 mangix: iI think you're pretty good at C, can't you just code something? Feb 15 03:44:20 DNS is something I don't dare touch Feb 15 03:44:32 lipnitsk: okay I'll run an actual test with the CI in a bit Feb 15 03:44:34 thanks for the PR Feb 15 03:45:54 okay, no problem. hope it makes mangix's life easier Feb 15 03:55:31 aparcar[m]: Looking at the entrypoint.sh script, should V=s be replaced with V=$V everywhere? Feb 15 03:56:57 now there's the question of that treewide PR. As I alluded to, some patches need to be manually edited as they're two in one. Feb 15 03:57:09 lipnitsk: sounds good Feb 15 04:00:07 hahaha manual git am of that patch doesn't apply. of course now. Feb 15 04:00:09 *not Feb 15 04:03:14 aparcar[m]: okay, pushed V=s -> V="$V" to same PR Feb 15 04:04:34 lipnitsk: I don't like how it changed utils/open-vm-tools/patches/0008-Rename-poll.h-to-vm_poll.h.patch . I remember manually adjusting it. Having said that, I wonder if the patch is even needed. Feb 15 04:04:40 mangix: Yeah I can re-run the check (some packages are probably out of date now). Well the automated refresh shouldn't really make things worse, right? That's what quilt already does when preparing the package for building (even the horribly broken one) Feb 15 04:05:54 it doesn't but the change in that patch is questionable Feb 15 04:06:07 utils/mc/patches/010-subshell.patch also looks strange Feb 15 04:06:16 mangix: agreed - actually I ran into the same thing with a patch I'm hoping to get merged in. Basically, quilt doesn't handle "rename from/rename to" well Feb 15 04:06:28 build #714 of zynq/generic is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/zynq%2Fgeneric/builds/714 Feb 15 04:07:13 LOL the issue with utils/mc/patches/010-subshell.patch is actually quite hillarious. it's missing a - Feb 15 04:07:30 oh. Feb 15 04:08:33 that is funny. why didn't it just remove the old stuff Feb 15 04:09:17 looks like maybe we need to patch quilt itself :) Feb 15 04:11:06 to be fair, the patch is illformer Feb 15 04:11:10 *illformed Feb 15 04:11:23 yeah, really just need a - in the first line Feb 15 04:11:40 but I don't like that quilt can't handle renames, or is that a feature, not a bug? Feb 15 04:13:58 unfortunately i have no idea. maybe there's some option. it is bad though. when refreshing a patch, if the original file was changed, a quilt refresh will not keep the source file changes AFAIK. Feb 15 04:14:55 net/rpcbind/patches/002-fix_stack_buffer_overflow.patch is interesting in that quilt removed the description. I think it needs to be manually edited to remove the ==== Feb 15 04:18:07 lang/python/python-requests/patches/0001-idna-dependency-bump.patch also needs to be split in two Feb 15 04:18:12 well that's one disadvantage of forcing this I think is that quilt does seem to remove descriptions. Feb 15 04:18:16 that's all problems i see so far Feb 15 04:18:41 not usually. for that file specifically it's getting tripped up on the ========= Feb 15 04:19:35 okay, so renames are really the only showstopper here? Feb 15 04:20:41 yeah. Maybe I can get rid of that rename patch in open-vm-tools Feb 15 04:21:42 fortunately that's the only one, at least in packages feed Feb 15 04:22:11 my proposed patch will go into openwrt repo, so I'm okay.. But it's strange that quilt can't handle it. Seems like a potential feature Feb 15 04:25:08 hmmmm Feb 15 04:25:25 i think one way to fix it is with --diff=utility Feb 15 04:28:01 what does it use by default? diff? git diff is probably what we want, if we can make it accept two files without a repo Feb 15 04:28:19 git diff [] --no-index [--] might work Feb 15 04:28:44 I'll do some tests once my toolchain compiles Feb 15 04:29:27 let me see if I can make open-vm-tools refresh happier with git diff Feb 15 04:30:29 maybe passing diff -s also works Feb 15 04:30:32 no idea yety Feb 15 04:30:34 *yet Feb 15 04:32:53 build #761 of apm821xx/nand is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/apm821xx%2Fnand/builds/761 Feb 15 04:34:21 build #794 of ramips/rt3883 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/ramips%2Frt3883/builds/794 Feb 15 04:35:00 build #786 of lantiq/xway_legacy is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/lantiq%2Fxway_legacy/builds/786 Feb 15 04:41:58 build #784 of archs38/generic is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/archs38%2Fgeneric/builds/784 Feb 15 04:45:32 build #721 of bcm53xx/generic is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/bcm53xx%2Fgeneric/builds/721 Feb 15 05:14:30 mangix: dug up this patch, looks like it never got merged into quilt: https://lists.gnu.org/archive/html/quilt-dev/2015-06/msg00002.html Feb 15 05:15:10 although I'm not sure if renames would just work with that. Unlikely. His test cases didn't feature any renames: https://lists.gnu.org/archive/html/quilt-dev/2015-06/msg00001.html Feb 15 05:17:23 it does seem like quilt is hard-coded to use GNU diff Feb 15 05:17:45 well, good news is that the open-vm-tools patch is useless Feb 15 05:17:54 seems some other ones are too Feb 15 05:18:00 https://git.savannah.nongnu.org/cgit/quilt.git/tree/quilt/scripts/patchfns.in#n744 Feb 15 05:18:50 yeah that is good news. But we may still need a way to allow exceptions with renames, if we are going to enforce this in CI Feb 15 05:20:21 or maybe there is some other kludgy way to achieve that - like handle renames as some separate task, not with quilt, or not with patches? Feb 15 05:25:47 build #773 of mediatek/mt7623 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/mediatek%2Fmt7623/builds/773 Feb 15 05:25:57 build #783 of mvebu/cortexa72 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/mvebu%2Fcortexa72/builds/783 Feb 15 05:27:07 build #769 of armvirt/32 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/armvirt%2F32/builds/769 Feb 15 05:29:59 build #766 of mediatek/mt7622 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/mediatek%2Fmt7622/builds/766 Feb 15 05:47:24 build #784 of layerscape/armv8_64b is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/layerscape%2Farmv8_64b/builds/784 Feb 15 05:57:09 build #645 of layerscape/armv7 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/layerscape%2Farmv7/builds/645 Feb 15 06:01:53 build #645 of mediatek/mt7629 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/mediatek%2Fmt7629/builds/645 Feb 15 06:16:57 build #532 of bcm63xx/generic is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/bcm63xx%2Fgeneric/builds/532 Feb 15 06:25:54 build #754 of x86/geode is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/x86%2Fgeode/builds/754 Feb 15 06:26:54 build #761 of kirkwood/generic is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/kirkwood%2Fgeneric/builds/761 Feb 15 06:27:43 build #294 of mpc85xx/p1010 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/mpc85xx%2Fp1010/builds/294 Feb 15 06:41:19 build #540 of bcm47xx/legacy is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/bcm47xx%2Flegacy/builds/540 Feb 15 06:43:45 Grommish: Can you comment on this? https://github.com/neheb/openwrt/commit/1e81d2afde2becfa82bdf4fdc1fb404756ac5ca4 Feb 15 06:51:37 wait a minute.... Feb 15 06:51:48 o32 is specific to mips32 only Feb 15 07:06:33 build #774 of ramips/rt288x is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/ramips%2Frt288x/builds/774 Feb 15 07:14:11 build #834 of ath25/generic is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/ath25%2Fgeneric/builds/834 Feb 15 08:00:29 build #644 of ath79/tiny is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/ath79%2Ftiny/builds/644 Feb 15 08:15:42 build #683 of lantiq/xrx200 is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/lantiq%2Fxrx200/builds/683 Feb 15 09:21:03 rsalvaterra: you using turrisos? Feb 15 09:22:10 mangix: I used before OpenWrt supported the Omnia, yes. Feb 15 09:22:27 build #450 of ath79/mikrotik is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/ath79%2Fmikrotik/builds/450 Feb 15 09:22:29 But I haven't used it in years. Feb 15 09:33:57 build #775 of lantiq/ase is complete: Success [build successful] Build details are at http://buildbot.openwrt.org/master/images/builders/lantiq%2Fase/builds/775 Feb 15 09:56:49 nbd: you just reverted the revert of the ABI changes? Feb 15 09:57:41 yes, because the reason for the revert is resolved Feb 15 09:57:51 there was a bug in patchelf Feb 15 09:57:54 and i merged the fix Feb 15 10:05:59 Hauke: I just merged the fix I wanted to have in 19.07.7, so it's good to go from my side Feb 15 10:06:04 I'll prepare the release notes Feb 15 10:10:16 pkgadd: thanks for the info! I'm wondering if openwrt2020 luci theme could be fixed, handling