**** BEGIN LOGGING AT Sat May 09 02:59:59 2015 May 09 07:33:57 morning May 09 08:02:55 Tofe: yeah May 09 08:26:50 Tofe: Rebased my kb work on yours from y'day. Looking good already need to iron out a few minor things and URL/email KB layout (but that's minor) and should be able to do a PR :) May 09 08:27:56 Only tested it on desktop for now, but looks good. Caret looks better but still not 100% :P May 09 08:28:10 Could be the left and caret image are too wide? May 09 08:40:12 Herrie: no, that side is alright, but the whole popover should shifted a bit to the left May 09 08:41:03 the key, the caret and the first key in the popover are supposed to be Y-center-aligned May 09 08:59:23 Tofe yeah it's already better now but still not 100% May 09 09:03:05 Let me make a screenshot shortly of where I am currently May 09 11:43:44 Tofe: Sorry for delay, fell asleep with the little one while Mrs was at the gym :P http://tinypic.com/r/2di0ozm/8 May 09 11:44:20 This is where I'm at now. I need to re-align return button to the right and fix the symbol button (probably broke the label while I was fixing CharKey behavior) May 09 14:12:18 Tofe: Did a PR against your current branch. It still needs quite a bit of work, but it looks a lot like LunaCE one already :) May 09 14:43:36 Herrie: looks very good ! I'll have a look at the PR :) May 09 15:14:56 Herrie: some remarks, but overall it's good May 09 15:16:59 I don't like how the ubuntu guys reference some objects (panel, fullscreenItem...) that are not directly defined in the qml file. But cleanup after cleanup, we'll have something more simple and more intelligible. May 09 16:50:49 Tofe: Yeah ;) May 09 16:55:38 Tofe: Commented on your comments ;) May 09 16:56:04 All is tested on desktop I didn't do any build or on device tests yet. Happy to do so when you have an IPK ;) May 09 16:56:08 yep, received the mails May 09 16:56:46 JaMa: ping May 09 16:57:34 I just pushed it and PR-ed it so we can take it from there. It pretty much covers all LunaCE bits now. Need to fix the URL buttons still on the bottom in URL/Search layout. And add some more extended chars May 09 16:57:46 Other than that it seems to work pretty much like LunaCE one :) May 09 16:58:21 Some things are a bit hacky but had to be because of how legacy was dealing with things and how Ubuntu/maliit does it differently May 09 16:58:46 I've been comparing it side by side with my LunaCE VKB screenshots ;) May 09 17:01:05 Herrie: what's actually special with , and . ? the color of key ? May 09 17:02:22 And that it has an annotation as well, similar to num, just in different position May 09 17:02:38 Num are on horizontal axis, , . on vertical May 09 17:02:49 ah yes ! so obvious that I missed it May 09 17:03:18 So in order to get this to work needed to do some hacky things :P May 09 17:04:06 Not always pretty but seems to work ;) May 09 17:04:16 I still think we can improve the test a bit, but before I would need to understand it completely May 09 17:04:29 Let's merge it then May 09 17:04:33 Tofe: Sure ;) May 09 17:04:45 Anyway the status will be better than the current one May 09 17:04:47 It's just a WIP so I don't need to rebase all the time ;) May 09 17:04:50 Yup ;) May 09 17:05:23 I liked the round globe on the 2.x VKB will ask Benjamin to recreate it :) May 09 17:05:29 done May 09 17:06:37 I'll finish the remaining things for the tablet layout and will then move onto the phone one I guess May 09 17:07:34 We should also see if we can optimize the regular + url/search layout a bit May 09 17:07:48 There's a lot of duplication for only the bottom row being different May 09 17:08:42 yep May 09 17:09:01 ah, something different: the "..." should appear only when in popover mode May 09 17:09:13 although I believe there is no such mode today ;) May 09 17:10:22 ok, looks good May 09 17:10:48 I'll try to improve this , and . tests that I didn't like by introducing a parameter in the qml file May 09 17:13:05 Tofe: YEah that's what legacy did, but imho it's more logical right away so you know which keys have "extra" features May 09 17:13:14 Otherwise it's a guess a bit **** ENDING LOGGING AT Sun May 10 02:59:59 2015