**** BEGIN LOGGING AT Mon May 25 02:59:59 2015
May 25 04:05:52 <carla_> hello, anyone awake?
May 25 04:07:08 <carla_> what's the difference between webos and luneos?
May 25 06:23:26 <Tofe> morning!
May 25 09:02:23 <Herrie|Veer> morning
May 25 09:02:44 <Herrie|Veer> Tofe: Seen you been busy will give it a go when I got a chance
May 25 09:03:10 <Tofe> Herrie|Veer: yes, I changed things here and there :)
May 25 09:03:57 <Tofe> Herrie|Veer: the biggest chance I'd like your opinion on is the fact that I know have a predefined key height (plus a size ratio), instead of computing it indirectly from the screen's height
May 25 09:04:01 <Tofe> change*
May 25 09:04:06 <Tofe> now*
May 25 09:04:58 <Herrie|Veer> Yeah saw that one not sure why you'd want that?
May 25 09:05:18 <Tofe> It allows us to have a better control over the keyboard look&feel, while still controlling a bit its space occupation thanks to gridUnit
May 25 09:06:20 <Tofe> also it makes it easier to have rows of different height
May 25 09:07:50 <Tofe> In the end, we have an almost identical look&feel with changes, w.r.t. previously (I've computed the keyHeight from what we had before, as we made it so that it looked identical to legacy)
May 25 09:09:22 <Herrie|Veer> I guess this could address the issue we have with widescreen devices like N4 where the ratio doesn't really work
May 25 09:09:35 <Tofe> Also, there was another reason for the change I now remember
May 25 09:10:00 <Tofe> The keys are fundamentally going to be used with fingers
May 25 09:10:38 <Tofe> so specifying a height in gridUnits ensures that the size isn't useless, whatever the device/configuration is
May 25 09:11:18 <Tofe> if a 0.34 ratio ends up with a 2mm height for the keys, it's not good
May 25 09:12:54 <Tofe> Herrie|Veer: the rest of the changes, though quite invasive, is mainly about refactoring. Not one pixel moved.
May 25 09:15:21 <Herrie|Veer> Tofe: Yeah not opposing it from the go, need to have a look just :)
May 25 09:21:21 <Tofe> Herrie|Veer: sure sure, and there's no hurry. I just wanted to explain the rational behind this strange modification
May 25 09:46:33 <Herrie|Veer> Tofe: It might be good to still have some fallback in case we don't have a device specific configuration
May 25 09:48:46 <Tofe> Herrie|Veer: what do you mean, no device specific configuration ?
May 25 09:49:09 <Tofe> don't we always have gridUnits ?
May 25 09:49:31 <Herrie|Veer> Maybe I need to check the code first :P I understood from your descriptions that we'd need to specify something per device
May 25 09:49:36 <Herrie|Veer> Besides Gu
May 25 09:50:12 <Tofe> What you need to look at, mainly, are UI.qml and the beginning of key_constants.js
May 25 09:50:51 <Herrie|Veer> OK will check when I get a chance to download it, no wifi here in apt only at reception :P
May 25 09:50:55 <Tofe> the latter has constants for the keyHeight, for all known variations (phone or tablet and portrait or landscape)
May 25 09:51:26 <Tofe> don't spend too much time on GH, there's a whole country out there ;)
May 25 10:00:43 <Herrie|Veer> I don't :P Just check some emails every once in a while. Nothing too much you can do with a little one but been enjoying the city, sun, see & swimming pool ;) Little one loves water and waves especially :P
May 25 13:51:08 <Herrie|Veer> Tofe: In general looks good, just 1 bug so far: Mako size gets adjusted after I adjust kb size (XS, S, M, L) for Tenderloin while it shouldn't.
May 25 13:54:12 <Herrie|Veer> I mean the vkb height. When I set Tenderloin to XS then switch to Mako it's wrong
May 25 14:09:08 <Tofe> Herrie: ah, yes, that must be a bug in the test framework. I'll fix it.
May 25 14:17:00 <Tofe> fixed.
**** ENDING LOGGING AT Tue May 26 02:59:58 2015