**** BEGIN LOGGING AT Wed Jun 17 02:59:59 2015 Jun 17 07:16:35 morning Jun 17 07:16:39 Tofe: ping Jun 17 08:05:09 Morning! Jun 17 08:05:20 Herrie|Veer: pong Jun 17 08:06:15 Herrie|Veer: Yesterday evening I was too tired to think about an alternative to the thumbKeyboard property, I'll retry today :) But the rest of the PR looks ok Jun 17 08:07:30 Tofe: morning Jun 17 08:08:17 OK, happy for better suggestion. I'm not a big fan of this solution (it's a bit dirty, but works) Jun 17 08:16:03 Nizovn had provided me some screenshots so I'll finish work based on current state and we can refactor based on your suggestion. Jun 17 08:18:52 Herrie|Veer: yes, please continue, it's great work already :) Jun 17 08:20:09 Just, the keys looks very compressed, do you think it will be easy to use? Jun 17 08:20:29 We can make them wider Jun 17 08:20:37 It was Nizovn's concern as well Jun 17 08:21:13 I just took his pixel for pixel. Adjusting is fairly easy Jun 17 08:22:44 Then again I'm OK with my Veer with it's small keys and I don't have small hands Jun 17 08:22:49 :P Jun 17 08:26:22 Yes, but touchscreen is less precise, moreover with a thumb -- but we'll adjust with what we experience in practice Jun 17 08:27:15 Yup :) Jun 17 10:15:44 Tofe: Updated PR with proper bottom row (OK on Tenderloin, needs some tweaking on Grouper still). Also added symbols kb for thumb :) Jun 17 10:58:15 :) Jun 17 13:59:19 Tofe: few more additions to PR: Russian thumb for nizovn :) Jun 17 14:02:41 Yes, just saw that, no pb Jun 17 14:02:52 I'll digg into the thumbKeyboard topic tonight Jun 17 14:04:17 Tofe: I can't think of a clever joke for that comment because I always used del.icio.us instead of digg :P Jun 17 14:04:39 For the font it's not very shocking (though we could use an agnostic term like "compactFontSize"), but I feel like we could avoid things like "thumbKeyboard ? keyWidth/12 : keyWidth/6" Jun 17 14:04:50 GodGinrai: :p Jun 17 14:08:07 Tofe: Just the offset needs to be less based on the thumb because the keys are less wide Jun 17 14:08:32 And the key width is calculated based on width of vkb devided by number of keys Jun 17 14:09:09 So for thumb we need to force a custom width and we cannot use the keyWidth for it ;) Jun 17 14:09:17 I'm open for a better solution. Jun 17 16:01:52 Herrie|Veer: a better solution would be to have correct keyWidth value Jun 17 16:16:15 Herrie|Veer: one possibility would be to introduce a 'keyMargin' property in KeyPad, and use it when computing the key width Jun 17 16:16:58 by default it's zero Jun 17 16:17:43 and the thumb kbd would set it to keyPadRoot.width/3 for instance Jun 17 16:18:24 I'll propose a PR tonight based on this idea Jun 17 16:18:48 Tofe: Looking fwd to it Jun 17 17:10:10 Tofe: ping Jun 17 17:13:27 Herrie|Veer: pong Jun 17 17:13:54 For implementing a Tweak: All is there for me to test? We just need updated bb? Jun 17 17:14:05 I think so Jun 17 17:18:51 OK since I'm pretty much done with vkb layouts for now (yeah still need to do FI, HU and a few others), wanted to look at this arrows/trackball tweak next first :) Jun 17 17:19:31 :) Jun 17 17:22:34 Not sure what we need to add in bb to copy over the Tweaks json? I think just some inherit webos-tweaks. Maybe JaMa or morphis have an idea? Jun 17 17:23:31 Herrie|Veer: I propose this: https://github.com/webOS-ports/webos-keyboard/pull/72 Jun 17 17:24:39 I'll try to rebase your current PR on top of that Jun 17 17:25:20 Herrie|Veer: tweaks for the keyboard? Jun 17 17:25:22 Herrie|Veer: when you put your tweaks into file/tweaks within the repository everything is fine by inheriting from webos_tweaks Jun 17 17:25:51 Herrie|Veer: it checks for that directory and if present installs all files from it into the right tweaks directory Jun 17 17:25:58 morphis: OK :) Already thought so thnx for confirmation :) Jun 17 17:26:16 Will get this tweak sorted soon then I guess :% Jun 17 17:26:17 :) Jun 17 17:27:33 good Jun 17 17:27:48 just do a PR against meta-webos-ports or tell me when I should do the bump Jun 17 17:27:56 OK :) Jun 17 17:28:19 I guess I'll have it ready before weekend sometime. Should be fairly easy :) Jun 17 17:28:34 Already implemented arrows with thumb kb :) Jun 17 17:28:46 So reusing + adding tweak :) Jun 17 17:42:09 Herrie|2: what is the thumb kbd image on which you based your work? Jun 17 17:43:50 Tofe: I just took latest master Jun 17 17:43:52 Why? Jun 17 17:43:58 Before you did your PR Jun 17 17:44:04 no I mean for thumb kbd Jun 17 17:44:14 Ah let me fwd you some Jun 17 17:44:44 You got some nizovn screenshots in your mail shortly Jun 17 17:44:52 thanks! Jun 17 17:45:54 I tried to take that pretty much to the pixel Jun 17 17:46:08 :) I trust you on that Jun 17 17:46:09 S, M, L look fine. XS might need some tweaking still Jun 17 18:11:02 Herrie|2: I must have missed something, but isn't your kbd height far too small? Jun 17 18:11:45 on the screenshots you sent, we should match with the notes_M_landscape, for the tablet default M size Jun 17 18:43:22 I've reworked your PR, getting rid of most of the thumb-specific things Jun 17 18:43:54 But I still need to rebase on top of a modified tofe/work and so on, it'll take a bit Jun 17 18:44:17 Also, I've made the rows higher, to follow the screenshots you sent Jun 17 18:44:33 (actually, it's the usual height of keys) Jun 17 19:10:37 Herrie|2: ping Jun 17 19:23:41 Tofe: pong Jun 17 19:23:54 The height: Well nizovn's looked odd a bit sometimes Jun 17 19:23:58 I think mine looked better Jun 17 19:28:27 well, you still get yours when selecting the "XS" size :p Jun 17 19:30:08 Herrie|2: I've push my changes on tofe/herrie-master-rebased (it's rebased on top of my current tofe/work PR) Jun 17 19:30:56 The bottom-row still looks a bit incorrect though Jun 17 19:31:14 but we use almost only the generic features of our vkb Jun 17 19:36:42 OK will give it a go later tonight or tomorroq Jun 17 19:36:45 thnx Jun 17 19:37:04 Herrie|2: no pb, and it may be that you don't like what I did :p Jun 17 19:38:17 however I've just added my stuff on top of yours, so if we disagree we can always merge your first PR and then converge Jun 17 20:21:53 Tofe: Sorry but mine really looked a lot better Jun 17 20:22:08 Yours is broken in so many places where mine was quite polished Jun 17 20:23:16 margins between keys are too big, symbol key text is too large for button, symbols don't fit etc Jun 17 20:23:27 images run over key borders etc Jun 17 20:23:32 Stuff that was OK with mine :P Jun 17 20:25:51 Your portrait is not too good either Jun 17 21:23:13 Tofe: I suggest to merge my PR Jun 17 21:23:28 I'll cherry pick a few of your suggestions and include that in a next PR? **** ENDING LOGGING AT Thu Jun 18 02:59:59 2015