**** BEGIN LOGGING AT Tue Nov 24 03:00:53 2015 Nov 24 05:15:20 Morning Nov 24 05:20:11 Tofe_: Nothing too much, just that the setRedirects seems to originate from the BrowserAdapter which we got rid off when we moved away from the BrowserServer/BrowserAdapter model when we moved from Webkit1 to Webkit2. So it seems that it has been broken all that time. I'm not sure that's the cause for the email contents not showing (need to look into that more, but I guess eventually it Nov 24 05:20:11 would be good to get it implemented and working again) Nov 24 05:24:15 See https://github.com/webOS-ports/enyo-1.0/blob/webOS-ports/master/framework/source/palm/controls/WebView.js#L139, https://github.com/webOS-ports/enyo-1.0/blob/webOS-ports/master/framework/source/palm/controls/BasicWebView.js#L256 and https://github.com/webOS-ports/BrowserAdapter/blob/master/BrowserAdapter.cpp#L1945 Nov 24 05:26:11 At least if I read it correctly that's where the setRedirects eventually will get processed. We implemented a lot of the other adapters in the webview already in one way or another: https://github.com/webOS-ports/BrowserAdapter/blob/master/BrowserAdapter.cpp#L181 Nov 24 05:28:31 That also seems to deal with cut, copy & paste functionality that we're currently missing as well: https://github.com/webOS-ports/BrowserAdapter/blob/master/BrowserAdapter.cpp#L3401 Not sure that's a system wide one though Nov 24 06:43:44 Morning Nov 24 06:43:46 morphis: ping Nov 24 06:43:59 Tofe_: pong Nov 24 06:44:29 morphis: I see we should update our libhybris to get the latest fixes, including caching properties read/write Nov 24 06:44:42 Tofe_: sounds good Nov 24 06:45:32 Tofe_: morning Nov 24 06:45:52 Also, does the rework you're working on in libhybris, to have an "android version-independant" base, have an impact on our recipes ? Nov 24 06:46:20 (my sentences aren't that good before first coffee...) Nov 24 06:47:18 morphis: You reckon it's a good idea to disable the parts from luna-systemui we don't use/are not available? Things like AppManagerService, StoragedService etc? https://github.com/webOS-ports/luna-systemui/tree/webOS-ports/master/data Nov 24 06:47:40 Herrie: if that doesn't cause any regressions, yes Nov 24 06:47:50 Tofe: no it doesn't Nov 24 06:48:04 morphis: ok Nov 24 06:48:05 basically for LuneOS that isn't of much interest as we're building a device specific rootfs Nov 24 06:48:09 Ubuntu does not Nov 24 06:48:23 Ubuntu has one tar.gz rootfs it uses on all devices Nov 24 06:48:42 pretty ambitious Nov 24 06:49:33 Herrie: I'll have a look at this BrowserServer thing, I didn't know we used that before Nov 24 06:50:33 morphis: I'll test that first of course :) Some could work with some modifications for our current apps I guess. Will check and act accordingly Nov 24 06:51:11 Tofe: I'm not 100% sure this setRedirects is the cause for the email problem, but I've seen it used in about 100 or so apps altogether that are on GitHub, so I'm quite sure it's quite widespread in general Nov 24 06:51:25 So it would be good to have implemented anyway. Nov 24 06:51:35 yeah Nov 24 06:51:47 It basically does a rewrite of URl's before loading it seems based on regex Nov 24 06:52:24 ok, like on a webserver Nov 24 06:53:23 Tofe: Yeah, we had browserserver running in the background and then browseradapter was basically the webview in the browser Nov 24 06:53:30 And used for other bits as well Nov 24 06:55:20 I see how to adapt that to webengine Nov 24 06:56:31 https://github.com/isis-project/BrowserAdapter/blob/master/README.md Nov 24 06:56:45 https://github.com/isis-project/BrowserServer/blob/master/README.md Nov 24 06:57:48 Lots of what was there is now standard functionality in QtWebkit/QtWebEngine but some things might still be good to have, like the copy, paste etc. And maybe a few others Nov 24 08:11:42 morning Nov 24 08:21:45 morning. Nov 24 08:23:04 Tofe, Herrie|Veer: we have/had something similar, but very basic, with InAppBrowser. Maybe that is a good start? Nov 24 08:23:35 btw: my daughter is here, now. :) Currently we are suffering from a lack of sleep. Nov 24 08:27:22 Garfonso: Good morning & congratulations! When was the big day? All going OK with your wife & daughter? Nov 24 09:24:40 Garfonso: hey, congrats! And bye bye sleep :) Nov 24 09:25:02 Garfonso: one good thing is that you'll be able to discuss with Herrie on IRC at 5:15AM :P Nov 24 12:34:17 Herrie|2 & Tofe: Thanks. :) Big day was 17th of November. Daughter is fine, wife recovers from a caesarean, but is very active already. Nov 24 19:02:18 ok, for Clock I debugged a bit more, and it just looks like there is a bug in clock... Nov 24 19:03:00 there is simply no "onOpenAppMenu" handle in the ApplicationEvents component (see https://github.com/openwebos/core-apps/blob/master/com.palm.app.clock/main/main.js ), so the event isn't delivered. Nov 24 19:15:04 Tofe: Well you might be right with your assessment, but when you check the 3.0.5 clock app in TP Doctor, you'll see that there's no onOpenAppMenu as well, but I'm quite sure we have an app Menu there :P Nov 24 19:15:34 Just not a home now to confirm. Nov 24 19:17:37 s/a/at Nov 24 19:21:46 Herrie|Veer: but then I don't know how it shows up... Nov 24 19:25:03 Tofe: I'm not sure either :P I'll check when at home to see if there's an app menu or not. I remember there is.... Nov 24 19:25:31 And for Testr (Enyo 2.5.1.1), is looks for a "onmenubutton" handleer, which it doesn't find anywhere Nov 24 19:25:39 I think I'm missing something here Nov 24 19:29:22 Problem is clock doesn't work in Chrome for me so can't check CTRL + ~ there Nov 24 19:31:26 Well, it certainly wouldn't follow the same path anyway Nov 24 19:32:01 I saw some key handlers, so I guess it may work with keyboard while not working with relaunch Nov 24 19:32:34 but it doesn't make sense that the same js code stopped working suddenly Nov 24 19:34:40 Tofe: Hmmz when I copy the 3.0.5 clock app and add owo mock data it runs on Chrome but no app menu with CTRL+~ Nov 24 19:34:40 Plot thickens LOL :P Nov 24 19:34:40 Need to compare both first to see why OWO clock app doesn't run in browser Nov 24 19:36:38 What is AppMenu refering to ? An Enyo standard component ? https://github.com/openwebos/core-apps/blob/master/com.palm.app.clock/main/main.js#L48 Nov 24 19:38:23 Tofe: https://github.com/enyojs/enyo-1.0/blob/master/framework/source/palm/controls/menu/AppMenu.js, probably Nov 24 19:40:57 ah yes Nov 24 19:51:38 mmh there are some listeners that were not added, like the AppMenu one Nov 24 19:59:26 ok, I think I got it: we have two instances of enyo.dispatcher.rootHandler. I don't know if that's normal. Nov 24 20:16:49 Herrie|Veer: I think I have a lead Nov 24 20:17:51 Tofe: Nice :D Nov 24 20:29:24 Tofe: I have a feeling this might somehow fix the email issue as well... Nov 24 20:30:01 yes, probably Nov 24 20:30:03 ie two instances of rootHandler could cause the email issues too. Nov 24 20:30:35 well, that's normal I think; however, getting the active window is not handled correctly Nov 24 20:30:48 our isActive implementation is a bit broken Nov 24 20:40:05 Tofe: So the pointers from last week weren't that much off :P Nov 24 20:40:10 I.e. focus Nov 24 20:40:40 right Nov 24 20:47:39 ah but of course, isActive isn't implemented by QtWayland... Nov 24 20:52:40 Tofe: That explains :P Nov 24 21:03:37 Taking a look at the [core] clock app. I can see why I can't delete alarms: the code is ridiculously broken. Nov 24 21:04:08 There is loads of commented out code too. Anyone know where this came from. I suppose it is not the Touchpad clock app. Nov 24 21:09:01 elvispre: Not sure. You'd have to compare the source code. I didn't have a chance for that yet today. 2.x was quite reliable, you might be able to borrow some ideas there to get 3.x/OWO version more reliable. I found it very unreliable when I used it on T Nov 24 21:09:01 P. Nov 24 21:09:12 My phone actually never failed me in 4 years :P Nov 24 21:10:12 Herrie: There's no way the code I'm looking at has ever worked. Nov 24 21:10:18 As quick compare you might push both to GH in separate branches and do a PR to spot the differences :) Nov 24 21:10:33 ElvisPre: The 3.x code worked a bit but it was buggy Nov 24 21:10:50 OWO seems different, doesn't run in Chrome for me. Nov 24 21:10:59 Herrie: And, yes, I still use my 2.x clock (Pre 3) as my alarm clock today. Nov 24 21:10:59 While 3.x does :s Nov 24 21:11:35 It never failed me... So it's reliable. It shouldn't be rocket science. From what I've seen it are just LS2 calls. Nov 24 21:12:16 Herrie: I think it can probably be fixed quite easily; it just looks like a rushed hack. Nov 24 21:14:27 For the record, if you want a laugh, onConfirmDelete_itemAlarm in alarmlist.js just changes its mind about what its arguments are called at a crucial moment. Nov 24 21:16:49 Herrie|Veer: do you remember what command to send to the Contacts app for the test ? Nov 24 21:17:00 Can't find it on google nor in my logs Nov 24 21:17:59 Tofe: See issue 1011 :) Nov 24 21:18:08 It's there in description Nov 24 21:18:21 ah yes! of course Nov 24 21:26:37 doesn't contacts, nor testr menu :( Nov 24 21:26:39 fix Nov 24 21:27:13 Tofe: Hmmmz. $ Nov 24 21:27:58 both are enyo2, right? Nov 24 21:28:46 maybe not Contacts Nov 24 21:28:47 Tofe: Yeah Nov 24 21:28:51 But they're not headless Nov 24 21:29:12 Contacts is rewrite in Enyo 2 Nov 24 21:49:22 There's no menu in Testr, isn't it ?... Nov 24 21:53:29 Tofe: I'm not sure, could be. We don't use it much currently. I know Calculator in Enyo 2 has one :) Nov 24 21:53:40 In case you're looking for an Enyo 2 one :) Nov 24 21:56:06 it works :) Nov 24 21:59:52 https://github.com/webOS-ports/luna-webappmanager/pull/45 Nov 24 22:03:29 That'll be all for tonight :) gn8 ! Nov 24 22:06:30 Tofe: Nice, you have an ipk for me? Nov 24 22:08:25 Herrie|Veer: https://dl.dropboxusercontent.com/u/4679068/luna-next/luna-webappmanager_0.2.0-8%2Bgit7%2B2eaff4cbc0-r0.10_armv7a-vfp-neon.ipk Nov 24 22:08:42 Thnx Nov 24 22:09:04 Will give that a go before merging. This is only for app menu or also for other relaunch things? Nov 24 22:09:13 So I know what I should test :) **** ENDING LOGGING AT Wed Nov 25 03:00:54 2015