**** BEGIN LOGGING AT Sat Dec 26 02:59:58 2015 Dec 26 10:14:56 Tofe: I'll mock something up for the missing banner params Dec 26 10:18:32 Tofe: I noticed that iconUrl was defined as const QUrl in notification plugin, but as QString in palmsystemextension.cpp. This could be the cause of the issue we had earlier? Dec 26 10:18:45 Not sure if it would be best to use QString or QUrl in all cases here? Dec 26 10:18:48 Any advice? Dec 26 10:19:19 I guess QString? Dec 26 10:54:56 Morning, merry Christmas! Dec 26 10:56:24 Tofe: morning ;) Dec 26 10:56:28 How are things up north? Dec 26 10:56:31 Warm there too? Dec 26 10:57:03 Herrie: QUrl doesn't work well with ListModel, but otherwise it's a bit more formal Dec 26 10:57:30 Herrie: it has just begun snowing ! Dec 26 10:58:20 Tofe: Hehe at least a bit of x-masy feel to it then ;) Dec 26 10:58:37 yes :) Dec 26 10:59:31 Tofe: I'm fine either way ;) We should just be consistent ;) Dec 26 11:00:34 We anyway need to update the existing few calls to make sure we're API compatible with the added fields Dec 26 11:01:19 Messaging & Update service are the only ones that do calls to org.webosports.notifications for now Dec 26 11:01:39 And it are 2 single calls Dec 26 11:02:07 yes, agrees Dec 26 11:03:21 But seems that legacy expects QString: https://github.com/openwebos/webappmanager/blob/d5d40487cc28bcf15ed2cc836b78de56920da22f/Src/webbase/PalmSystem.cpp#l64 Dec 26 11:03:35 So for compatibility it might be better to keep it QString? Or you want to convert it? Dec 26 11:04:47 I.e. legacy apps might do a dashboard/banner call with a string which might not necessarily be a correct QUrl ? Dec 26 11:05:14 Not sure how Qt would deal with that Dec 26 11:10:05 Tofe: Also seems that sqlite DB that's used doesn't support boolean as type, but stores integer (0 or 1) instead Dec 26 11:10:12 So for the doNotSuppress we'd have to deal with that Dec 26 11:10:17 Not sure how to do that in C++ :P Dec 26 11:11:06 doNotSuppress is not used anywhere, so we could just force the user to send 1 or 0 and define it as int istead of bool? Dec 26 11:11:12 In various places Dec 26 11:11:36 Or parse true/false to 0 and 1 somehow ;) Dec 26 11:16:32 yes, we can do that ; I don't have the code right there on my phone, so I'm staying a bit vague ;) Dec 26 11:21:45 Tofe: OK Dec 26 11:21:55 It seems parsing QString into QUrl is easy Dec 26 11:22:03 So will pull QUrl everywhere Dec 26 11:27:45 ok :) Dec 26 11:28:07 Well it's only for the iconUrl and soundFile Dec 26 11:28:16 there is also QUrl::toString when needed Dec 26 11:28:34 (or asString, maybe) Dec 26 11:29:53 Yeah... I think I got it covered, only part I'm not sure about is how to convert the bool to 0 and 1 when inserting into SQLIte Dec 26 11:48:58 Seems I pushed to wrong branch :S Dec 26 11:49:07 Fork even Dec 26 11:49:09 Well I'll just try a build then :P Dec 26 14:49:44 Hi! Been a while since I've been on here. Wondering: how is telephony support going and what are the obstacles to it working? Is there a feature development page for it? Dec 26 14:57:12 tyrok_laptop1: To be honest we've been busy with many other things lately.... OpenEmbedded/Yocto update, migration to QtWebEngine so we didn't have much time to work on it. But it's on our to-do list for the near future... Back end stuff mainly is there Dec 26 14:58:24 I.e. Incoming call shows, outgoing call makes the other side ring, just we need to sort audio routing and things Dec 26 15:01:13 Herrie: Cool. Just wondering how realistic it would be for me to start doing development on an active phone like I used to. Dec 26 15:01:48 Probably not far off if I could get some time to help, then. Roughly how many active developers are around in the project nowadays? Dec 26 15:14:49 tyrok_laptop1: It shouldn't be too hard I'd guess Dec 26 15:15:06 We really haven't looked much into it. Active devs. I'd say probably between 5 and 10 Dec 26 15:15:14 Some more active then others Dec 26 15:33:01 I think we have about a dozen or so not so regular contributors who work on things now and then Dec 26 15:41:36 Our phone bits are basically commonly available things RILD from Android, oFono, ConnMan and we use a modified VoiceCall from Nemo guys Dec 26 16:55:33 nizovn: You around? Dec 26 16:55:39 Need some help with some C++ stuffs :P Dec 26 16:55:42 Herrie: yes Dec 26 16:55:48 ok Dec 26 16:57:10 I'm trying to extend notification API a bit so it's compatible with legacy... I.e. supports soundClass, soundFile, duration and doNotSuppress Dec 26 16:57:35 Problem I'm running into is that for the org.webosports.notifications we use a SQLite DB which doesn't support boolean type Dec 26 16:57:42 And doNotSuppress is a boolean ;) Dec 26 16:57:49 So I need to somehow convert it to int :S Dec 26 16:57:53 And I'mm horrible with C++ :P Dec 26 17:05:18 maybe (int)doNotSuppress ? Dec 26 17:05:44 Let me push what I have Dec 26 17:06:12 https://github.com/Herrie82/luna-next/commit/35ea4a5fbcd719c2f6d08349bca0e24b6575db05 Dec 26 17:13:24 i think there should be no problems with bool->int Dec 26 17:14:14 what doesn't work? restored value is wrong? Dec 26 17:30:12 It doesn't build Dec 26 17:30:59 ok let me see Dec 26 17:36:10 Problem with the current code is that https://github.com/Herrie82/luna-next/commit/35ea4a5fbcd719c2f6d08349bca0e24b6575db05#diff-51a4211d09878afa5b907b2f32dfadf7R320 expects a boolean for doNotSuppress and it's an int above it Dec 26 17:37:59 We should somewhere convert between boolean and int, just not sure where exactly Dec 26 17:40:19 Herrie: i think the best way is to get rid of & for duration and doNotSuppress in Nofirication constructor Dec 26 17:46:26 i would also delete "&" in setDuration() and setDoNotSuppress() to be 100% perfect :) Dec 26 17:51:59 wait, you are not using set* functions, do you need them? Dec 26 17:57:45 nizovn: Yeah I wasn't sure about the & for duration and doNotSuppress Dec 26 17:58:13 I put the set functions because the other values also had them Dec 26 18:01:39 they seems all to be redundant, as there is no WRITE in Q_PROPERTY's Dec 26 18:01:54 :) Dec 26 18:13:59 ah, sorry, you use it here https://github.com/Herrie82/luna-next/commit/35ea4a5fbcd719c2f6d08349bca0e24b6575db05#diff-51a4211d09878afa5b907b2f32dfadf7R112 Dec 26 18:14:31 Yes ;) Dec 26 18:15:03 sorry for confusion Dec 26 18:15:40 No prop ;) Dec 26 18:16:22 I mainly did a c&p from existing code to add the missin gbits :) Dec 26 18:23:17 nizovn: https://github.com/Herrie82/luna-next/commit/c81b1b435b6419b44ce47af64c11edb4ee99c358 Dec 26 18:23:26 Fixed some spacing issues & your comments Dec 26 18:43:58 Herrie: i think you should add toBool here https://github.com/Herrie82/luna-next/commit/c81b1b435b6419b44ce47af64c11edb4ee99c358#diff-51a4211d09878afa5b907b2f32dfadf7R317 Dec 26 18:45:06 and delete "&" in setDuration and setDoNotSuppress :P Dec 26 18:52:16 OK done ;) Dec 26 18:52:27 You think it should build OK like this? Dec 26 18:56:34 yes, it should be ok Dec 26 19:00:33 Hmmz seems Jenkins is down :P Dec 26 19:00:38 Cannot build now LOL Dec 26 19:00:48 502 bad gateway Dec 26 19:02:28 yes, it's down for me too Dec 26 19:08:36 Will try my local build then :P Dec 26 19:08:40 Might take a while Dec 26 19:11:45 i can confirm it builds for x86 Dec 26 19:12:25 :D Dec 26 19:12:33 Should be fine then :) Dec 26 20:51:45 nizovn: dkirker was looking into fixing legacy location-services Dec 26 20:52:16 He stumbled upon ours and was wondering how everything relates (i.e. location-services that uses GeoClue 2), QtLocation etc Dec 26 20:52:23 I got a bit lost myself too **** ENDING LOGGING AT Sun Dec 27 02:59:59 2015