**** BEGIN LOGGING AT Fri Jan 29 02:59:59 2016 Jan 29 06:40:29 morning Jan 29 08:09:54 Morning! Jan 29 08:15:31 Tofe: Phone work looks nice :) Jan 29 08:15:35 Didn't check on device yet Jan 29 08:33:45 Neither did I :p Jan 29 08:34:31 I'm a bit worried I made a callhistory layout that doesn't work well with other devices, I'll have to check Jan 29 08:40:51 Tofe: It looks a lot better already compared to what was before Jan 29 08:43:26 I picked the colors from Pre3 screenshots :p Jan 29 08:43:53 Tofe: Yeah it looked very familiar :P Jan 29 08:44:05 It's still too "square" for a real LuneOS feeling, but it's a beginning Jan 29 08:44:12 Though ugly on desktop :P because of stretching :P Jan 29 08:44:50 Right now I'm trying to add the section headers in the call history list Jan 29 08:45:15 with the separation for days Jan 29 08:45:27 :) Jan 29 08:45:31 And I have a db8 question related to that Jan 29 08:45:36 Curious how you'll do that ;) Jan 29 08:45:48 Need something like that in browser history too :P Jan 29 08:46:43 What if I add a new property to the callgroup kind, giving the timestamp in days instead of seconds? It would be redundant of course, but it would help greatly for my view :p Jan 29 08:47:08 Also it means we lose a bit of compatibility with legacy's kind Jan 29 08:48:09 Tofe: I don't think so. Jan 29 08:48:41 I think db8 works in such a way that if you were put an extra "field" it would be ignored when it's not used ;) Jan 29 08:48:48 But I'm no db8 expert Jan 29 08:49:07 Garfonso, DougReeder or Feniksa might know better :P Jan 29 08:49:50 I mean the date field will be empty, and the callhistory won't be split in sections Jan 29 08:50:52 But frankly, at that point, we can expect someone to write a little script to export/import and adapt the fields on the fly... Isn't it Garfonso ;) Jan 29 08:52:41 Ok, I'll add that field. Jan 29 08:57:29 Tofe: I think you can even import it without the field :P Jan 29 08:57:40 But yeah if someone wants they can write a script Jan 29 08:57:50 There is already an export one for legacy Jan 29 08:58:00 And that can import too Jan 29 08:58:16 Shouldn't be too hard to modify for our needs :P Jan 29 09:02:45 well, it's just setting the new field to the value of Math.floor(timestamp/nb_of_ms_in_a_day) Jan 29 10:28:03 Herrie|Veer: if you fetch my 2 PRs, you'll be able to see how I regrouped the items in "day" sections Jan 29 10:32:47 Tofe: Nice! Jan 29 10:32:54 Looking good :) Jan 29 10:33:27 Well layout is broken a bit on desktop (font size might need a bit of tweaking here and there but that's minor) Jan 29 10:35:11 Font color for missed calls shouldn't be red Jan 29 10:36:36 Herrie|Veer: I thought it could be a good idea... no? maybe not :p Jan 29 10:37:05 No it will hurt the eyes Jan 29 10:37:11 The red icon is enough :p Jan 29 10:37:19 It's difficult to read on blue bg Jan 29 10:39:31 ok, updated PR, now it's white Jan 29 10:39:53 Tofe: OK :) Jan 29 10:40:06 They're OK to merge now or you want to do more first? Jan 29 10:45:41 I just would like to see it on device first Jan 29 10:45:57 But it should be fine Jan 29 10:46:22 luneos-components can be merged anyway Jan 29 10:54:32 Tofe: I'll merge both. Jan 29 10:54:44 Probably font sizes and image sizes need some work Jan 29 10:55:04 But I can look at that tonight and pixel f*ck a bit :P Jan 29 10:56:00 I might do that shortly actually :P Jan 29 10:56:15 Will check legacy code and adjust a little Jan 29 11:34:32 Tofe: Heading to gym now, will do some PR after lunch to make it look better. Jan 29 12:04:24 Herrie|Veer: ok! Jan 29 13:39:15 Tofe: PR is done Jan 29 13:39:26 Makes it look a lot nicer on desktop at least Jan 29 13:39:41 Still need to see on device but it's more true to legacy like this Jan 29 14:19:15 Great, let me see that :) Jan 29 14:23:42 Commented a bit, I saw some mistakes here and there Jan 29 15:50:19 Tofe: Updates Jan 29 15:50:22 Updated Jan 29 16:03:44 merged Jan 29 16:04:07 Tofe: Looks better right? Jan 29 16:04:18 Or you didn't check? Jan 29 16:05:11 I didn't check yet, but I see what you've done with the section text, and I was just lazy not doing it :p Jan 29 16:05:24 Tofe: LOL :P Jan 29 16:05:51 And we need to make sure the divider line (the thin one) is not shown for the last item on a particular day Jan 29 16:06:51 Also legacy does TODAY, YESTERDAY, WEDNESDAY until beginning of week and then uses short date format. But that's fairly easy to tweak. I saw some code in legacy we can use :p Jan 29 16:09:14 Herrie|Veer: yes, having the text customized will be easy Jan 29 16:09:41 But having the divider line not show up for last call in day will be tricky :p Jan 29 16:10:12 Tofe: Yeah I also didn't know how to solve that quickly Jan 29 16:10:21 So I left it for now :P Jan 29 16:11:08 we'll figure it out Jan 29 16:11:13 Kicked off some new nightly so we can see it on device :D Jan 29 16:11:19 now I'd like to improve the look of the individual calls Jan 29 16:11:34 (deployed view) Jan 29 16:12:40 You mean the right arrow that does the dropdown? Jan 29 16:14:16 no, the actual expanded view Jan 29 16:14:23 which is very minimal right now Jan 29 16:14:39 You saw that you can expand by clicking on the photo, right? Jan 29 16:26:45 Tofe: no didn't see that Jan 29 16:26:54 Ah see it now Jan 29 16:27:05 The image on the button should be bigger though Jan 29 16:33:39 Herrie|Veer: well, this part needs lots of TLC Jan 29 16:33:55 Tofe: Yeah :P Jan 29 16:34:12 But it's already in 500% better state compared to last week :P Jan 29 16:34:26 :) Jan 29 16:36:01 so, we definitely need the arrow on the side of the image Jan 29 16:36:23 Yup Jan 29 16:37:07 btw, does all/missed work on device? Jan 29 16:37:37 Wil ask Benjamin to mock up some images when he got time so we have nice 4* ones Jan 29 16:37:49 The phone app ones aren't too difficult in general Jan 29 16:38:18 yeah that'd be nice Jan 29 16:39:13 Just he recently moved and is stuck to his Chromebook instead of something proper :P Jan 29 16:39:29 Until he gets properly settled in :P Jan 29 16:41:37 :) Jan 29 17:40:40 mmmh I think your modification on the size of the contact image was not that great Jan 29 17:45:59 I wonder why I see so much difference between desktop and N4 Jan 29 18:34:05 Tofe: It looks OK on Desktop for me Jan 29 18:35:45 Well, for me too, but on device the image takes all the available width (but not the height) Jan 29 18:36:15 I'm investigating. Jan 29 18:44:08 Seems to be related to the Button handling Jan 29 18:44:47 Maybe the implementation on mobile device is a bit wrong Jan 29 18:45:30 Layouts + Controls was a bit too much for good ol' Qt :p Jan 29 18:48:48 ah, yes, that must be because of the style thing Jan 29 18:53:50 Tofe: CAn't we use something else instead of button? Jan 29 18:56:35 https://github.com/webOS-ports/org.webosports.app.phone/pull/31 Jan 29 19:03:54 Tofe: LGTM, merged Jan 29 19:04:37 I also saw that the All/Missed buttons don't refresh the UI Jan 29 19:04:46 looks like the stub works better than the real code :p Jan 29 19:05:11 LOL Jan 29 19:12:50 Was quite an obvious bug hopefully; I'm already testing my fix Jan 29 19:16:56 ... fix works: https://github.com/webOS-ports/luneos-components/pull/32 Jan 29 19:42:36 Tofe: OK merged & new nightly running Jan 29 19:42:44 Let Bonaire do something useful :P Jan 29 19:48:45 :) **** ENDING LOGGING AT Sat Jan 30 02:59:58 2016