**** BEGIN LOGGING AT Wed Apr 13 02:59:58 2016 Apr 13 05:16:19 morning Apr 13 05:16:21 Tofe: ping Apr 13 05:30:00 Tofe: I cleaned things up a bit: https://github.com/Herrie82/fingerterm/commit/239d9f58790397a00ab55eddb18b13a817222121 & https://github.com/Herrie82/fingerterm/commit/4be14a5baacf0d27fb6a2ca4a3f77403a08ad8ac & https://github.com/webOS-ports/meta-webos-ports/commit/346bcd08ea55343e89a126965b55085f3d9a6f5f Apr 13 05:30:18 Happy to get your feedback. I'm not sure about a few things still, but this works it seems. Apr 13 05:30:50 Herrie, what TZ is elvispre i? Apr 13 05:30:52 in? Apr 13 05:36:03 ka6sox: He's in the UK, so I'm 1 hr ahead of him Apr 13 05:36:17 AFAIK Apr 13 05:55:34 okay thanks... Apr 13 06:39:01 Morning Apr 13 06:39:03 Herrie: pong Apr 13 06:40:00 ka6sox: that would explain the absence of pong at 1:00am :) Apr 13 06:50:14 Tofe: morning Apr 13 06:50:19 See my links above. Apr 13 06:50:33 I'm not sure I'm doing the right thing for the font. Apr 13 06:51:42 Herrie|Veer: I've inserted some comments Apr 13 06:52:27 In general, we avoid having target-specific conditions in the code when it's actually related to a functionality Apr 13 06:53:09 And for the font, in the same spirit, I would externalize the definition of the default font family to the qmake file Apr 13 06:59:57 Tofe, yup Apr 13 07:00:51 ka6sox: you never sleep? :) Apr 13 07:31:42 Tofe, unfortunately NO Apr 13 07:46:20 Tofe: I'm also not very pleased with my "solution" for the orientationLock I put in the patch. This was the easiest way but not a very proper one. Problem is the return values given by lockModeStringToQtEnum seem to cause issues. Apr 13 07:46:51 And I had no idea how else to do it. Apr 13 07:47:07 For the font: Is this a default font defined by Qt somehow? Apr 13 07:47:18 Because it seems to be there from the early start. Apr 13 07:47:30 Or maybe not on a virgin system, I didn't try that. Apr 13 07:48:25 I guess my emulator already had the /.config/Fingerterm/settings.ini from a previous run :s Apr 13 07:48:36 That's why I had issues I guess. Apr 13 08:01:04 Herrie|Veer: there's a default in Qt which is builtin, but fingerterm overloaded it with monospace Apr 13 08:02:23 Tofe: Seems it writes a settings.ini at first launch. I'll test it with deleting the settings.ini first :) Apr 13 08:03:03 Herrie|Veer: yes, the defaults of settings.ini is exactly what you patched in your commit :p Apr 13 08:04:31 Tofe: Yeah but I kept getting monospace but I didn't read there's a settings.ini so got confused where it got that from :P Apr 13 08:04:39 Took me forever to figure out :P Apr 13 08:06:38 :) Apr 13 08:07:02 Oh, GH introduced the smileys... Not sure yet if I like that... Apr 13 08:18:35 Tofe: LOL Apr 13 08:18:58 Any suggestions for the orientationLock patch I did? Apr 13 08:46:47 a moment, let me see more closely Apr 13 08:47:22 I just disabled it for now which is nasty :P Apr 13 08:56:24 Herrie|Veer: where is the PageStackWidnow.qml file? Apr 13 08:57:08 Tofe: Ehm I forgot to push that one :P Apr 13 08:57:17 Just like my change to Page.qml :P Apr 13 08:59:23 The patch you did could actually be fine; in LuneOS the card window's rotation is handled by the window manager, not by the app itself Apr 13 08:59:37 Tofe: I took http://bpaste.net/show/54c0915ab584 and stripped all unnecessary bits basically. Apr 13 08:59:59 And made ApplicationWindow into Item as you suggested. Apr 13 09:00:15 Tofe: rotation seemed fine on qemu Apr 13 09:21:07 Tofe: Is there any preference of where to put the DEFINES? in the .bb recipe or .pro file? Seems both work :P Apr 13 09:27:57 If the symbol is used in the cpp, I'd say it should also appear in the .pro, to have a consistent source code repo Apr 13 09:41:06 Tofe: That's what I thought too. I'll change that back to the .pro files. Makes more sense to me there anyway. Apr 13 16:56:55 Tofe: ping Apr 13 16:57:03 I guess I'm doing this incorrectly? https://github.com/Herrie82/fingerterm/blob/4ddceedc083ced7e5e5da5cf6867f61406f8c495/fingerterm.pro#L5 Apr 13 16:57:08 How should I do this properly? Apr 13 17:06:27 Herrie: seems DEFINES += DEFAULT_FINGERTERM_FONTFAMILY="monospace" Apr 13 17:10:16 nizovn: I did that Apr 13 17:10:20 Then I have a problem in my CPP code Apr 13 17:11:08 I think I did this wrong: https://github.com/Herrie82/fingerterm/blob/master/main.cpp#l219 Apr 13 17:13:50 OK Seems I need to do "_DEFAULT_FINGERTERM_FONTFAMILY" there :S Apr 13 17:18:34 Herrie: sorry, some problems with internet connection here Apr 13 17:19:01 nizovn: Yup that seems to work Apr 13 17:19:46 Oh well maybe not :P Apr 13 17:19:59 After I deleted my settings.ini file it didn't :P Apr 13 17:24:53 you don't need _ before DEFAULT Apr 13 17:49:27 Still not working adding some debug stuff now Apr 13 23:53:08 Herrie|2, would a publicly (subscription) builder help the project developers? **** ENDING LOGGING AT Thu Apr 14 02:59:58 2016